Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions which block rendering Legalpad signatures
ClosedPublic

Authored by aklapper on May 13 2023, 11:04.
Tags
None
Referenced Files
F2936628: D25226.1737932674.diff
Sat, Jan 25, 23:04
F2935630: D25226.1737858795.diff
Sat, Jan 25, 02:33
F2935629: D25226.1737858794.diff
Sat, Jan 25, 02:33
F2935579: D25226.1737856652.diff
Sat, Jan 25, 01:57
F2935549: D25226.1737855697.diff
Sat, Jan 25, 01:41
F2935511: D25226.1737853132.diff
Sat, Jan 25, 00:58
F2932977: D25226.1737749345.diff
Thu, Jan 23, 20:09
F2871485: D25226.1736857359.diff
Mon, Jan 13, 12:22

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15395

Test Plan

Applied these two changes; afterwards "All Signatures" page at /legalpad/signatures/1/ gets rendered in web browser.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks for this patch (again!)

I tested this locally with fuzzy tests in the Name Contains and Email Contains input fields, without any nuclear implosion.

The function phutil_nonempty_string() will report any alien value that is not string or null, and I verified that this is OK here.

sgtm

This revision is now accepted and ready to land.May 19 2023, 10:45