Page MenuHomePhorge

PhabricatorPhabricatorAuthProvider: Remove unnecessary Remarkup
ClosedPublic

Authored by aklapper on Fri, May 19, 15:13.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 4, 19:24
Unknown Object (File)
Sun, Jun 4, 06:33
Unknown Object (File)
Fri, Jun 2, 12:39
Unknown Object (File)
Wed, May 31, 06:46
Unknown Object (File)
Tue, May 30, 15:06
F292983: Phorge Auth fixed.png
Fri, May 19, 18:24
F292970: Auth screenshot Remarkup problem.png
Fri, May 19, 15:24

Details

Summary

This is a small fix in a specific user message example. See other messages in the very same file which also use <tt>.

Here the problematic phrase:

Auth screenshot Remarkup problem.png (204×759 px, 24 KB)

See the example in the phrase "Use lowercase letters, digits, and periods. For example: ...".

Test Plan

After this change, the specific message "The URI where the OAuth server is installed. For example" from the page /auth/config/edit/?provider=PhabricatorPhabricatorAuthProvider does not have anymore backticks shown to the end user.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

(I have a déjà vu about this patch, I do not know why)

Thanks so much. Just for more context, here the fixed thing:

Phorge Auth fixed.png (259×1 px, 32 KB)

Tested locally following the test plan, nothing explodes.

To test that, I had to destroy my local Auth configuration to have a clean environment. I've done that with:

DELETE FRom auth_providerconfig WHERE providerClass != 'PhabricatorPasswordAuthProvider';

lgtm

This revision is now accepted and ready to land.Fri, May 19, 18:24