Page MenuHomePhorge
Feed All Stories

All Stories
Use Results
Edit Query

May 12 2023

valerio.bozzolan updated the diff for D25148: Config page: add lovely git-related error messages in standard error log.

last fixes

May 12 2023, 11:32
valerio.bozzolan updated the diff for D25148: Config page: add lovely git-related error messages in standard error log.

create a very useful "tip generator"

May 12 2023, 11:29
valerio.bozzolan updated the summary of D25148: Config page: add lovely git-related error messages in standard error log.
May 12 2023, 11:28
valerio.bozzolan updated the task description for T15282: Fix/avoid/simplify similar fatal: detected dubious ownership in repository at '/var/www/phorge'.
May 12 2023, 10:35 · User-valerio.bozzolan
valerio.bozzolan updated the summary of D25148: Config page: add lovely git-related error messages in standard error log.
May 12 2023, 10:31
valerio.bozzolan updated the diff for D25148: Config page: add lovely git-related error messages in standard error log.

use resolve() → resolvex() that natively throws a nice exception message

May 12 2023, 10:21
valerio.bozzolan added inline comments to D25108: PHP Pitfalls: mention strlen() deprecation since PHP 8.1.
May 12 2023, 10:12 · Documentation
aklapper closed T15384: PHP 8.1 "strlen(null)" exceptions block rendering Log In page after user logout, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 12 2023, 10:06 · PHP 8 support
aklapper closed T15384: PHP 8.1 "strlen(null)" exceptions block rendering Log In page after user logout as Resolved by committing rP4d1adf69392a: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after….
May 12 2023, 10:06 · PHP 8 support
aklapper closed D25217: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after user logout.
May 12 2023, 10:06
aklapper committed rP4d1adf69392a: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after….
May 12 2023, 10:06
aklapper closed T15381: PHP 8.1 "strlen(null)" and preg_match() exceptions block rendering "Browse Subscribers" overlay dialog, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 12 2023, 10:02 · PHP 8 support
aklapper closed D25214: Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering "Browse Subscribers" overlay dialog.
May 12 2023, 10:02
aklapper closed T15381: PHP 8.1 "strlen(null)" and preg_match() exceptions block rendering "Browse Subscribers" overlay dialog as Resolved by committing rP3a3112f67b4e: Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering….
May 12 2023, 10:02 · PHP 8 support
aklapper committed rP3a3112f67b4e: Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering….
May 12 2023, 10:02
aklapper closed T15380: PHP 8.1 "strlen(null)" exceptions block rendering "Browse Projects" overlay dialog, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 12 2023, 10:00 · PHP 8 support
aklapper closed T15380: PHP 8.1 "strlen(null)" exceptions block rendering "Browse Projects" overlay dialog as Resolved by committing rPbac87ca2646b: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects"….
May 12 2023, 10:00 · PHP 8 support
aklapper closed D25213: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects" overlay dialog.
May 12 2023, 10:00
aklapper committed rPbac87ca2646b: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects"….
May 12 2023, 10:00
aklapper closed T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 12 2023, 09:58 · PHP 8 support
aklapper closed T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages, a subtask of T15334: PhabricatorProjectCoreTestCase: fix "Implicit conversion from float ", as Resolved.
May 12 2023, 09:58 · User-valerio.bozzolan, Projects
aklapper closed T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages as Resolved by committing rPc2856b479fbd: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar….
May 12 2023, 09:58 · PHP 8 support
aklapper closed D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
May 12 2023, 09:58
aklapper committed rPc2856b479fbd: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar….
May 12 2023, 09:58
aklapper added a comment to D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.

Thanks for the additional checking and docs!

May 12 2023, 09:58
valerio.bozzolan added a reviewer for D25025: Unify user-select CSS directives: Matthew.

Hi @Leon95: green light :)

May 12 2023, 09:29
valerio.bozzolan removed a reviewer for D25025: Unify user-select CSS directives: Matthew.

Hoping to be useful I try to reset the Block from our kind Matthew since it was related to a past merge conflict

May 12 2023, 09:26
valerio.bozzolan awarded D25212: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment a Yellow Medal token.
May 12 2023, 08:13
valerio.bozzolan requested changes to D25212: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment.

Thanks for addressing this issue

May 12 2023, 08:12
valerio.bozzolan accepted D25214: Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering "Browse Subscribers" overlay dialog.

Thanks again

May 12 2023, 08:00
valerio.bozzolan updated the diff for D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.

fix typo (sorry)

May 12 2023, 07:50
valerio.bozzolan updated the diff for D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.

add minor inline documentation

May 12 2023, 07:48
valerio.bozzolan accepted D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.

I double-checked this multiple times and I think the approach is really the minimal necessary to achieve this goal in a safe way.

May 12 2023, 07:47
valerio.bozzolan added inline comments to D25165: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole.
May 12 2023, 07:10

May 11 2023

valerio.bozzolan added a comment to D25213: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects" overlay dialog.

To other reviewers: the related lint errors will be fixed also thanks to aklapper: D25209

May 11 2023, 17:00
valerio.bozzolan accepted D25213: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects" overlay dialog.

I tested this patch locally following the test plan. No implosions.

May 11 2023, 16:53
valerio.bozzolan updated subscribers of D25148: Config page: add lovely git-related error messages in standard error log.

I noticed that it exists a ExecFuture#resolvex() method that is the exact replacement of ExecFuture#resolve() but throws a CommandException.

May 11 2023, 16:48

May 10 2023

avivey accepted D25217: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after user logout.
May 10 2023, 20:25
aklapper requested review of D25217: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after user logout.
May 10 2023, 18:32
aklapper added a revision to T15384: PHP 8.1 "strlen(null)" exceptions block rendering Log In page after user logout: D25217: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after user logout.
May 10 2023, 18:32 · PHP 8 support
aklapper created T15384: PHP 8.1 "strlen(null)" exceptions block rendering Log In page after user logout.
May 10 2023, 18:31 · PHP 8 support
avivey closed T15241: arc tab-complete hangs on some flows as Invalid.

It hadn't happened in a while, so I guess it was something strange in my machine.

May 10 2023, 18:21 · Bug Reports, Arcanist
aklapper requested review of D25216: Fix PHP 8.1 "strlen(null)" exceptions setting up Username/Password Authentication Provider.
May 10 2023, 18:09
aklapper added a revision to T15383: PHP 8.1 "strlen(null)" exceptions setting up Username/Password Authentication Provider: D25216: Fix PHP 8.1 "strlen(null)" exceptions setting up Username/Password Authentication Provider.
May 10 2023, 18:09 · PHP 8 support
aklapper created T15383: PHP 8.1 "strlen(null)" exceptions setting up Username/Password Authentication Provider.
May 10 2023, 18:08 · PHP 8 support
aklapper requested review of D25215: Fix PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to Contact Number.
May 10 2023, 17:59
aklapper added a revision to T15382: PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to Contact Number: D25215: Fix PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to Contact Number.
May 10 2023, 17:59 · PHP 8 support
aklapper created T15382: PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to Contact Number.
May 10 2023, 17:58 · PHP 8 support
bfs accepted D25191: Auto-subscription: little less verbose.

Seems reasonable and simple enough. Can we get a Blessed Committer to accept this?

May 10 2023, 17:21 · UX
aklapper requested review of D25214: Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering "Browse Subscribers" overlay dialog.
May 10 2023, 14:46
aklapper added a revision to T15381: PHP 8.1 "strlen(null)" and preg_match() exceptions block rendering "Browse Subscribers" overlay dialog: D25214: Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering "Browse Subscribers" overlay dialog.
May 10 2023, 14:46 · PHP 8 support
aklapper created T15381: PHP 8.1 "strlen(null)" and preg_match() exceptions block rendering "Browse Subscribers" overlay dialog.
May 10 2023, 14:45 · PHP 8 support
aklapper updated the test plan for D25213: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects" overlay dialog.
May 10 2023, 14:41
aklapper updated the test plan for D25213: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects" overlay dialog.
May 10 2023, 14:40
aklapper requested review of D25213: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects" overlay dialog.
May 10 2023, 14:27
aklapper added a revision to T15380: PHP 8.1 "strlen(null)" exceptions block rendering "Browse Projects" overlay dialog: D25213: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects" overlay dialog.
May 10 2023, 14:27 · PHP 8 support
aklapper created T15380: PHP 8.1 "strlen(null)" exceptions block rendering "Browse Projects" overlay dialog.
May 10 2023, 14:26 · PHP 8 support
aklapper requested review of D25212: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment.
May 10 2023, 13:59
aklapper added a revision to T15379: PHP 8.1 "ltrim(null)" exception blocks rendering first Meme comment: D25212: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment.
May 10 2023, 13:59 · PHP 8 support
aklapper created T15379: PHP 8.1 "ltrim(null)" exception blocks rendering first Meme comment.
May 10 2023, 13:35 · PHP 8 support
aklapper closed T15377: PHP 8.1 "strlen(null)" exception when trying to add empty user email address, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 10 2023, 08:29 · PHP 8 support
aklapper closed T15377: PHP 8.1 "strlen(null)" exception when trying to add empty user email address as Resolved by committing rP4d9719539773: Fix PHP 8.1 "strlen(null)" exception when trying to add empty user email address.
May 10 2023, 08:29 · PHP 8 support
aklapper closed D25211: Fix PHP 8.1 "strlen(null)" exception when trying to add empty user email address.
May 10 2023, 08:29
aklapper committed rP4d9719539773: Fix PHP 8.1 "strlen(null)" exception when trying to add empty user email address.
May 10 2023, 08:29
aklapper closed T15374: PHP 8.1 "strlen(null)" exceptions block rendering user page after creation with Welcome Email enabled, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 10 2023, 08:28 · PHP 8 support
aklapper closed T15374: PHP 8.1 "strlen(null)" exceptions block rendering user page after creation with Welcome Email enabled as Resolved by committing rPc86364c2aa6d: Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after….
May 10 2023, 08:28 · PHP 8 support
aklapper closed D25208: Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after creation with Welcome Email enabled.
May 10 2023, 08:28
aklapper committed rPc86364c2aa6d: Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after….
May 10 2023, 08:28
valerio.bozzolan accepted D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.

I tried to write down the input domain:

May 10 2023, 07:11
valerio.bozzolan updated the summary of D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
May 10 2023, 06:47
valerio.bozzolan added inline comments to D25206: Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc look remotes".
May 10 2023, 06:22
valerio.bozzolan accepted D25208: Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after creation with Welcome Email enabled.

Thanks again

May 10 2023, 06:13
valerio.bozzolan accepted D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.

Please see my inline comment, probably just adding 3 characters fixes, and that would be probably the approach from O1

May 10 2023, 05:49
valerio.bozzolan accepted D25211: Fix PHP 8.1 "strlen(null)" exception when trying to add empty user email address.

Tested locally. Adding an email. Adding no email. Multiple fuzz tests. No implosions.

May 10 2023, 05:47
aklapper created T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly".
May 10 2023, 00:04 · Bug Reports

May 9 2023

aklapper requested review of D25211: Fix PHP 8.1 "strlen(null)" exception when trying to add empty user email address.
May 9 2023, 21:09
aklapper added a revision to T15377: PHP 8.1 "strlen(null)" exception when trying to add empty user email address: D25211: Fix PHP 8.1 "strlen(null)" exception when trying to add empty user email address.
May 9 2023, 21:09 · PHP 8 support
aklapper created T15377: PHP 8.1 "strlen(null)" exception when trying to add empty user email address.
May 9 2023, 21:08 · PHP 8 support
aklapper requested review of D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.
May 9 2023, 21:04
aklapper added a revision to T15376: PHP 8.1 "ltrim(null)" exception blocks adding additional user email address: D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.
May 9 2023, 21:04 · PHP 8 support
aklapper created T15376: PHP 8.1 "ltrim(null)" exception blocks adding additional user email address.
May 9 2023, 20:57 · PHP 8 support
valerio.bozzolan updated the task description for T15282: Fix/avoid/simplify similar fatal: detected dubious ownership in repository at '/var/www/phorge'.
May 9 2023, 20:38 · User-valerio.bozzolan
aklapper added a comment to D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
In D25209#6204, @valerio.bozzolan wrote:

Just to clarify, do you have an idea about the input domain of $a? (I will test this tomorrow)

May 9 2023, 20:30
valerio.bozzolan closed T15334: PhabricatorProjectCoreTestCase: fix "Implicit conversion from float " as Invalid.

So apparently this is not a problem in the unit test itself but just with T15375

May 9 2023, 19:47 · User-valerio.bozzolan, Projects
valerio.bozzolan added a parent task for T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages: T15334: PhabricatorProjectCoreTestCase: fix "Implicit conversion from float ".
May 9 2023, 19:46 · PHP 8 support
valerio.bozzolan added a subtask for T15334: PhabricatorProjectCoreTestCase: fix "Implicit conversion from float ": T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
May 9 2023, 19:46 · User-valerio.bozzolan, Projects
valerio.bozzolan removed a subtask for T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages: T15334: PhabricatorProjectCoreTestCase: fix "Implicit conversion from float ".
May 9 2023, 19:46 · PHP 8 support
valerio.bozzolan removed a parent task for T15334: PhabricatorProjectCoreTestCase: fix "Implicit conversion from float ": T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
May 9 2023, 19:46 · User-valerio.bozzolan, Projects
valerio.bozzolan added a parent task for T15334: PhabricatorProjectCoreTestCase: fix "Implicit conversion from float ": T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
May 9 2023, 19:46 · User-valerio.bozzolan, Projects
valerio.bozzolan added a subtask for T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages: T15334: PhabricatorProjectCoreTestCase: fix "Implicit conversion from float ".
May 9 2023, 19:46 · PHP 8 support
valerio.bozzolan added a comment to D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.

Just to clarify, do you have an idea about the input domain of $a? (I will test this tomorrow)

May 9 2023, 19:28
valerio.bozzolan added a comment to D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.

I DON'T BELIEVE THIS

May 9 2023, 19:07
aklapper requested review of D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
May 9 2023, 19:03
aklapper added a revision to T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages: D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
May 9 2023, 19:02 · PHP 8 support
aklapper created T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
May 9 2023, 19:01 · PHP 8 support
ton updated subscribers of T15364: arc land complaints summary by FreeBSD community.
May 9 2023, 18:48 · Arcanist, Differential, Affects-FreeBSD
ton updated subscribers of T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends.
May 9 2023, 18:48 · Affects-FreeBSD, Differential
ton updated subscribers of T15250: Raw use of "git diff" provides insufficient Diff Context.
May 9 2023, 18:47 · Affects-FreeBSD, Differential
ton updated subscribers of T15096: Discuss Arcanist as a barrier to adoption of Phorge and how to address the underlying issues..
May 9 2023, 18:47 · Discussion Needed, Arcanist
aklapper requested review of D25208: Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after creation with Welcome Email enabled.
May 9 2023, 18:24
First
Prev
Next
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0