Page MenuHomePhorge
Create Task
Maniphest T15334

PhabricatorProjectCoreTestCase: fix "Implicit conversion from float "
Closed, InvalidPublic
Actions

Description

Look at the errors in this patch:

D25173: Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure Menu page

Sometime the unit tests in PhabricatorProjectCoreTestCase say something weird like:

EXCEPTION (RuntimeException): Implicit conversion from float 178.5 to int loses precision
#0 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(192): PhutilErrorHandler::handleError(8192, '...', '...', 192)
#1 /var/www/html/phorge/phorge/src/applications/files/builtin/PhabricatorFilesComposeAvatarBuiltinFile.php(148): PhabricatorFilesComposeAvatarBuiltinFile::rgba2gd(Array)

That is probably a nonsense and deserves a fix, to avoid to scary code proposers with weird unit test errors, and without unrelated false positives.

Related Objects
Search...

Event Timeline

valerio.bozzolan created this task.May 3 2023, 10:16
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptMay 3 2023, 10:16
valerio.bozzolan triaged this task as Normal priority.May 3 2023, 10:18
valerio.bozzolan updated the task description. (Show Details)
valerio.bozzolan added a project: User-valerio.bozzolan.
valerio.bozzolan mentioned this in D25173: Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure Menu page.May 3 2023, 10:24
valerio.bozzolan mentioned this in D25199: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a project's page when Reports prototype enabled.May 8 2023, 11:51
valerio.bozzolan closed this task as Invalid.May 9 2023, 19:46
valerio.bozzolan added a parent task: T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
valerio.bozzolan removed a parent task: T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
valerio.bozzolan added a subtask: T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.

So apparently this is not a problem in the unit test itself but just with T15375

aklapper closed subtask T15375: PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages as Resolved.May 12 2023, 09:58
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0