Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after user logout
ClosedPublic

Authored by aklapper on May 10 2023, 18:32.
Tags
None
Referenced Files
F3322821: D25217.1743378902.diff
Sat, Mar 29, 23:55
F3322151: D25217.1743365831.diff
Sat, Mar 29, 20:17
F3319740: D25217.1743314486.diff
Sat, Mar 29, 06:01
F3318887: D25217.1743292921.diff
Sat, Mar 29, 00:02
F3303498: D25217.1743081719.diff
Wed, Mar 26, 13:21
F3252757: D25217.1742409766.diff
Tue, Mar 18, 18:42
F3221028: D25217.1741813440.diff
Tue, Mar 11, 21:04
F3221027: D25217.1741813437.diff
Tue, Mar 11, 21:03

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15384

Test Plan

Applied these four changes; logged in again; logged out again; finally saw "Log In" page with "Username or Email" and "Password" field on /auth/loggedout/ rendered in web browser.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable