Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after user logout

Authored by aklapper on Wed, May 10, 18:32.
Referenced Files
Unknown Object (File)
Thu, Jun 1, 11:57
Unknown Object (File)
Wed, May 31, 06:43
Unknown Object (File)
Thu, May 25, 08:47
Unknown Object (File)
Thu, May 25, 07:12
Unknown Object (File)
Thu, May 25, 05:45
Unknown Object (File)
Sun, May 21, 10:20
Unknown Object (File)
Thu, May 11, 01:16



strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15384

Test Plan

Applied these four changes; logged in again; logged out again; finally saw "Log In" page with "Username or Email" and "Password" field on /auth/loggedout/ rendered in web browser.

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable