Paths

Table of Contentst

Differential D25165

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole
ClosedPublic
Actions

Authored by valerio.bozzolan on May 1 2023, 14:21.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15315: Fix PHP 8.1 exception from DarkConsole: strlen(): Passing null to parameter #1 ($string) of type string is deprecated

Commits

rPc1c7699c9891: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole

Summary

Since PHP 8.1 the function call strlen(null) is deprecated.

Since Phabricator/Phorge elevates deprecation warnings to exceptions, the
specific fix implies dealing with null, and dealing with real strings.

In the specific case, a simple cast was made to deal with real strings.

Closes T15315

Test Plan

Visit the Home Page with DarkConsole enabled in your configuration: no crashes

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

valerio.bozzolan created this revision.May 1 2023, 14:21

Owners added a reviewer: O1: Blessed Committers.May 1 2023, 14:21

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMay 1 2023, 14:21

valerio.bozzolan requested review of this revision.May 1 2023, 14:21

Harbormaster completed remote builds in B318: Diff 596.May 1 2023, 14:21

Putting in CC @aklapper so we don't do both this specific fix

aklapper mentioned this in T15344: PHP 8.1 "strlen(null)" exception when DarkConsole is enabled.May 4 2023, 15:33

aklapper mentioned this in D25188: Fix PHP 8.1 "strlen(null)" exception when DarkConsole is enabled.May 4 2023, 15:34

aklapper mentioned this in rPf4d28119e849: Fix PHP 8.1 "strlen(null)" exception when DarkConsole is enabled.May 5 2023, 12:51

valerio.bozzolan added inline comments.May 12 2023, 07:10

src/applications/console/core/DarkConsoleCore.php
127–129	Note that this comment from Evan somehow supports the above line: https://secure.phabricator.com/T13588#257338

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

valerio.bozzolan mentioned this in Z1: Phorge.May 20 2023, 12:40

avivey accepted this revision.May 20 2023, 17:12

This revision is now accepted and ready to land.May 20 2023, 17:12

Closed by commit rPc1c7699c9891: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole. · Explain WhyMay 20 2023, 17:18

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rPc1c7699c9891: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

console/

core/

DarkConsoleCore.php

3 lines

O1: Blessed Committers

Diff 769

View Options

src/applications/console/core/DarkConsoleCore.php

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsoleClosedPublicActions