In D25015#678, @speck wrote:

It looks like there is a JX.phtize() which appears to be used to create a function that mimics pht() in JavaScript but I believe requires that whatever is passed to phtize() is effectively a map of translations which is presumably passed from the server somewhere. I've not yet uncovered this later part.

In T15044#1193, @speck wrote:

Functionally I think this makes sense, though from a higher perspective the concept of "multiple authors on a revision" might need to be discussed and fleshed out.

Technically this workflow can be supported today as arcanist will allow you to make updates to a diff that was originated/authored by someone else however in my experience this tends to be fraught with issues [...]

I didn't manage to get #phorge:libera.chat to work, but here's what I did:

Ref also Git Commit Message Conventions. Adding a Co-authored-by: name <name@example.com> trailer to the commit message seems fairly well-accepted, at least for Git. GitHub and GitLab both recognize and parse it when present.

Thanks for landing, and sorry for the delay; was away on vacation. I'll try to be more responsive in the future!

Automated Landing should be what adds the "Land Revision" button to revisions -- so not fully automated but allows someone to land without needing a local clone to manage.

Functionally I think this makes sense, though from a higher perspective the concept of "multiple authors on a revision" might need to be discussed and fleshed out.

I agree with @CSharp that option 3 is probably the best approach here. It looks like on https://secure.phabricator.com/T6409 the initial request was that items get automatically moved based on state change and the main pushback is against the design of an approach like 1 or 2. I think setting this up utilizing Herald makes sense though. I wasn't aware that triggers/transactions weren't fired from both locations though. That might be a bit involved.

I'll try to look into feasibility of this later this week. Presumably it shouldn't be too difficult, adding a few configs to point to the certificate files and updating the DAO (I think is named Lisk?).

In T15035#1188, @speck wrote:

@TitanNano with the matrix bridge up could you provide instructions on how to connect to that? I setup the Element client on my machine but I'm not sure how to get on that phorge channel.

@TitanNano with the matrix bridge up could you provide instructions on how to connect to that? I setup the Element client on my machine but I'm not sure how to get on that phorge channel.

I would support using approach number 3 and actually consider moving the triggers into Herald in the long run. Triggers are only dispatched from Javascript when moving the items on the board, but moving them within a task using the "Add action..." dropdown does not trigger them.

In D25019#617, @speck wrote:

This looks good to me.

I'm curious how often these scripts are used. I haven't used them for any of the installs I set up but I largely wasn't aware that they existed.

Thanks for submitting these changes!

Thanks for submitting this!

Also when I look at a diff on upstream phabricator i see a land revision button - but I don’t see that for diffs on this instance.

It looks like there is a JX.phtize() which appears to be used to create a function that mimics pht() in JavaScript but I believe requires that whatever is passed to phtize() is effectively a map of translations which is presumably passed from the server somewhere. I've not yet uncovered this later part.

@speck for rARC Trusted Contributors can land but rP is restricted to Blessed Committers

I'd suggest starting of the starmap by shedding some/most of the applications that were not part of the core of Phabricator or have been in the Prototype phase for a long time, allowing the project to regain focus and improve on the things that make Phorge unique. This would provide a number of advantages:

I think these changes look good. Prior to landing this should pass unit test runs. I created T15042 as a means to make landing changes easier and it should also involve setting up a staging area which then runs both lints and unit tests.

Thank you for the submission @roguelazer!

I'm going to look at trying to land this today. Additionally I created T15042 to avoid situations like this where the changes are accepted but don't get landed for some time.

Reference to the last Phabricator starmap prior to deletion. Phorge's starmap will likely align very closely with Phabricator's, initially.

With this change these log messages are being written out, even though the default of $this->quiet is true. I think this is because rebuild-map.php script unconditionally calls setQuiet() with the value it's passed from the command-line, however ArcanistLiberateWorkflow does not specify or pass in a quiet argument.

Turns out there is Javelin support for "copy text" already implemented - I think it's used when copying from 2-up display, or when white-space is visible.
Anyway, I have an example code at https://secure.phabricator.com/P2080 for a button that copies arbitrary text.

I think I just set that via "Global Default": https://we.phorge.it/settings/builtin/global/

I think it is complete for Review. But: What ist the Plan for new Features? Or Plans for Prototype Applications? I see they are disabled in this install and there is no Calendar Project. If the Priority is to get Phorge rebrand and related Things done first, this diff can safely lay around until Things are sorted.

the only global config option I can find is the timezone, so either way changes to phorge core would be required. Timezone has no default value. (It's typically controlled by the php date.timezone setting)

Hey everyone, I just learned about the Phabricator situation and I'd love to contribute to the project in any capacity I can. I've been around the discourse for some time and love Phabricator to bits and would love to keep it and see it thrive again!

(by the way, this task was intended to the Phorge tracker, not for the Phorge project tracker if both will be maintained separately)

In T15035#1086, @MacFan4000 wrote:

Matrix - not sure

For irc there is Phorge on Libera.chat. I’ve submitted a ticket for community registration after speaking with staff, but I haven’t heard back. (Ticket was submitted 3 weeks ago). Matrix - not sure

I think this looks good, and based on the (non-search-engine) conduit API stuff I'm familiar with I think everything looks correct.

• reflow

• add additional constraints as requested

Is there information about the IRC channel or Matrix channel on how to get set up? If there's chat I'll try to join in but I won't be able to be always-connected.

I added you both as well! Welcome to the team. If anyone has pre-existing functionality that they feel would be good to include in the upstream feel free to submit the changes. There's ongoing work (unfortunately slowly) to rebrand the project, but that's not holding up other changes at this time.

In D25015#633, @avivey wrote:

In this case I think the error text is agnostic of the instance of the dialog.

I was thinking about this use-case, which implies to me that the dialog author should be involved in the error text:

For the case of email headers

In https://secure.phabricator.com/T13658#256009, @epriestley wrote:

One other case where "Phabricator" appears is in HTTP and Email headers, e.g. X-Phabricator-XYZ. For a separate project wanting to update these I think a slow migration approach is needed, to allow recipients currently expecting the existing fields. I'm guessing there isn't a reasonable change here for the upstream.

Depending on how many of these we end up with, I think an email-header-prefix sort of config option might be reasonable.

Leave the default storage namespace as phabricator

I like the idea of having an easily greppeable token...

what about egrohp? ("phorge" backwards)?

Does anyone like, not like, or have additional thoughts on the general idea of making one or more unique identifiers that isn't "phorge", for the purpose of an identifier that is unmistakably greppable? I outlined some notes on this idea here: T15006#831

Per https://we.phorge.it/source/phorge/manage/policies/ the push policy for this repo is set to Blessed Committers

In D25014#624, @MacFan4000 wrote:

Could a member of Blessed Committers please land this? I can't do it my self (no write access) and I would appreciate it.

Ok my implementation had a couple of additional search constraints which are missing here. Otherwise this looks good to me and is more complete. I'll probably abandon my patch and apply this one if you don't mind including the additional search constraints. (See suggested edits.)

FWIW here is my implementation which overlaps somewhat:

What are the implications of making changes to the javelinjs.com https://github.com/phacility/javelin/ library?

I'd be happy to contribute. I currently maintain an installation with over 4,000 git repos and over 2,000 users since 2016. Our company apparently had the highest karma count by a wide margin with our Phacility Support Pact, for whatever that's worth :)

• DRY up LegalpadDocumentSignature::generatePHID()

Could a member of Blessed Committers please land this? I can't do it my self (no write access) and I would appreciate it.

I would also love to contribute to Phorge. I have signed the legalpad doc.

Also I don’t believe javelin.io is related to the Javalin used in Phab.

Ah I did not look closely enough. Dang. We should be attaching the message to the view on the server then, somehow.

Oh, another potential concern...