Page MenuHomePhorge
Differential D25741

Fix undefined variable in HeraldAction
ClosedPublic
Actions

Authored by aklapper on Jul 24 2024, 15:48.
Tags
None
Referenced Files
F2991935: D25741.1740198750.diff
Fri, Feb 21, 04:32
F2991934: D25741.1740198748.diff
Fri, Feb 21, 04:32
F2990376: D25741.1740177356.diff
Thu, Feb 20, 22:35
F2981947: D25741.1739943108.diff
Tue, Feb 18, 05:31
F2934969: D25741.1737811004.diff
Fri, Jan 24, 13:16
F2933287: D25741.1737759454.diff
Thu, Jan 23, 22:57
F2930319: D25741.1737675515.diff
Wed, Jan 22, 23:38
F2904839: D25741.1737334824.diff
Jan 19 2025, 01:00
View All 10 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP0b93685cc999: Fix undefined variable in HeraldAction
Summary

$no_permission is only defined within if ($object instanceof PhabricatorPolicyInterface), thus move the check for if ($no_permission) into that clause.

Test Plan

Read the code.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSizePackages
src/
applications/
herald/
action/
7 linesO1: Blessed Committers

Diff 2266

View Options

src/applications/herald/action/HeraldAction.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0