Page MenuHomePhorge

Fix undefined variable in HeraldAction
ClosedPublic

Authored by aklapper on Jul 24 2024, 15:48.
Tags
None
Referenced Files
F3314512: D25741.1743230695.diff
Fri, Mar 28, 06:44
F3313414: D25741.1743219037.diff
Fri, Mar 28, 03:30
F3312646: D25741.1743213085.diff
Fri, Mar 28, 01:51
F3295292: D25741.1742953283.diff
Tue, Mar 25, 01:41
F3294866: D25741.1742946113.diff
Mon, Mar 24, 23:41
F3294774: D25741.1742943267.diff
Mon, Mar 24, 22:54
F3290355: D25741.1742864033.diff
Mon, Mar 24, 00:53
F3290170: D25741.1742861357.diff
Mon, Mar 24, 00:09

Details

Summary

$no_permission is only defined within if ($object instanceof PhabricatorPolicyInterface), thus move the check for if ($no_permission) into that clause.

Test Plan

Read the code.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable