Remove unused parameter from PhabricatorMailEmailEngine::newEmailThreadingHeaders() call
ClosedPublic
Actions

Authored by aklapper on Jul 25 2024, 18:34.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPc5c2b8ce5a67: Remove unused parameter from PhabricatorMailEmailEngine…

Summary

Method PhabricatorMailEmailEngine::newEmailThreadingHeaders() invoked with 1 parameter, 0 required.
Thus remove the parameter from its call in the same class.
The called private function does $mailer = $this->getMailer() anyway.

Test Plan

Read the code.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jul 25 2024, 18:34

Owners added a reviewer: O1: Blessed Committers.Jul 25 2024, 18:34

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 25 2024, 18:34

aklapper requested review of this revision.Jul 25 2024, 18:34

Harbormaster completed remote builds in B1457: Diff 2271.Jul 25 2024, 18:34

valerio.bozzolan accepted this revision.Jul 26 2024, 10:02

This revision is now accepted and ready to land.Jul 26 2024, 10:02

Closed by commit rPc5c2b8ce5a67: Remove unused parameter from PhabricatorMailEmailEngine…. · Explain WhyJul 26 2024, 10:06

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPc5c2b8ce5a67: Remove unused parameter from PhabricatorMailEmailEngine….

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

metamta/

engine/

PhabricatorMailEmailEngine.php

2 lines

O1: Blessed Committers

Diff 2273

View Options

src/applications/metamta/engine/PhabricatorMailEmailEngine.php

Remove unused parameter from PhabricatorMailEmailEngine::newEmailThreadingHeaders() callClosedPublicActions