Remove unused parameter from PhabricatorConfigConsoleController::newLibraryVersionTable() call
ClosedPublic
Actions

Authored by aklapper on Jul 25 2024, 13:50.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP4e31cadb54d2: Remove unused parameter from PhabricatorConfigConsoleController…

Summary

Method PhabricatorConfigConsoleController::newLibraryVersionTable() invoked with 1 parameter, 0 required.
Thus remove the parameter from its only call across the codebase.

Test Plan

Read the code.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Jul 25 2024, 13:50

Owners added a reviewer: O1: Blessed Committers.Jul 25 2024, 13:50

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJul 25 2024, 13:50

aklapper requested review of this revision.Jul 25 2024, 13:50

Harbormaster completed remote builds in B1455: Diff 2269.Jul 25 2024, 13:50

Thanks.

I cannot imagine any situation where the incoming viewer from handleRequest(AphrontRequest $request) could be different from the implicit viewer from AphrontController#getViewer() ($this->getRequest()->getViewer()).

Also, practically, the objects are the same:

https://we.phorge.it/source/phorge/browse/master/src/aphront/configuration/AphrontApplicationConfiguration.php$264-284

So I wonder why handleRequest(AphrontRequest $request) has such parameter. Maybe it should have no parameters and just rely on $this->getRequest(). But this is an unrelated story.

Safe change. Thanks

This revision is now accepted and ready to land.Jul 26 2024, 07:08

Closed by commit rP4e31cadb54d2: Remove unused parameter from PhabricatorConfigConsoleController…. · Explain WhyJul 26 2024, 08:24

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP4e31cadb54d2: Remove unused parameter from PhabricatorConfigConsoleController….