Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Today

aklapper retitled D25992: Remove unused anchor-target CSS for Conpherence message pane from Conpherence message pane CSS: Fix typo in selector name

Wed, May 28, 14:31

aklapper planned changes to D25992: Remove unused anchor-target CSS for Conpherence message pane.

These selectors currently do not get applied at all in Conpherence rooms when opening or creating URIs with anchors.

Wed, May 28, 14:28

aklapper closed D26030: Fix project typeahead query with columns when string is not name prefix.

Wed, May 28, 13:23

aklapper closed T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)" as Resolved by committing rP87da4d2a33e6: Fix project typeahead query with columns when string is not name prefix.

Wed, May 28, 13:23 · Bug Reports

aklapper committed rP87da4d2a33e6: Fix project typeahead query with columns when string is not name prefix.

Wed, May 28, 13:22

aklapper closed D26033: Search-related PhpDoc additions.

Wed, May 28, 10:41

aklapper committed rP93d9e1b05dd2: Search-related PhpDoc additions.

Wed, May 28, 10:41

aklapper retitled D26033: Search-related PhpDoc additions from Search related PhpDoc additions

Wed, May 28, 10:40

aklapper closed D25998: Remove orphan CSS selectors in base/main-menu-view.css.

Wed, May 28, 07:47

aklapper committed rP0347f1f619bb: Remove orphan CSS selectors in base/main-menu-view.css.

Wed, May 28, 07:47

Yesterday

aklapper updated the diff for D25998: Remove orphan CSS selectors in base/main-menu-view.css.

git rebase master

Tue, May 27, 21:27

aklapper closed D26014: Remove orphan CSS selectors in phui/phui-document*.css.

Tue, May 27, 21:20

aklapper committed rPf4f616410c23: Remove orphan CSS selectors in phui/phui-document*.css.

Tue, May 27, 21:20

aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

Not really what we expected, but nice try

Tue, May 27, 21:06

valerio.bozzolan accepted D25998: Remove orphan CSS selectors in base/main-menu-view.css.

Tue, May 27, 19:55

valerio.bozzolan accepted D26014: Remove orphan CSS selectors in phui/phui-document*.css.

Tue, May 27, 19:54

valerio.bozzolan accepted D26033: Search-related PhpDoc additions.

Tue, May 27, 19:51

valerio.bozzolan updated the name of F4381076: TOTP warning.png from "image.png" to "TOTP warning.png".

Tue, May 27, 19:49

valerio.bozzolan added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

Not really what we expected, but nice try

Tue, May 27, 19:49

aklapper updated the diff for D26033: Search-related PhpDoc additions.

@param loves $name

Tue, May 27, 17:56

aklapper requested review of D26033: Search-related PhpDoc additions.

Tue, May 27, 17:52

valerio.bozzolan accepted D26031: Allow using PCRE's just-in-time compilation.

Can't wait to enjoy the production Grafana CPU graph of Wikimedia Phabricator after this change

Tue, May 27, 14:05

aklapper updated the summary of D26026: Add a Before-Destruction Engine.

Tue, May 27, 11:51

aklapper added a comment to T15903: Logged exceptions/errors should ignore user's language setting and be always in English.

In T15903#18783, @avivey wrote:

pht() also does some escaping, formatting, and other safety related stuff

Tue, May 27, 10:10 · Localization

valerio.bozzolan created T16087: Setup: Show Setup Warning if PHP opcache is Not Effective.

Tue, May 27, 08:15 · User-valerio.bozzolan, Feature Requests

Mon, May 26

aklapper added a comment to D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.

In D26032#27637, @valerio.bozzolan wrote:

Probably one screenshot is missing (?)

Mon, May 26, 15:58

valerio.bozzolan added inline comments to D26026: Add a Before-Destruction Engine.

Mon, May 26, 14:10

valerio.bozzolan added a comment to D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.

In D26032#27621, @aklapper wrote:

Feed before applying the patch (T3922) and after applying the patch (T3923):

Mon, May 26, 11:54

aklapper added inline comments to D26026: Add a Before-Destruction Engine.

Mon, May 26, 11:52

valerio.bozzolan updated the summary of D26026: Add a Before-Destruction Engine.

Mon, May 26, 11:11

valerio.bozzolan added inline comments to D26026: Add a Before-Destruction Engine.

Mon, May 26, 11:09

valerio.bozzolan updated the diff for D26026: Add a Before-Destruction Engine.

add more and more PHPDoc, and fix typos - thanks

Mon, May 26, 11:09

valerio.bozzolan awarded T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes a Yellow Medal token.

Mon, May 26, 08:56 · PHP 8 support

valerio.bozzolan created T16086: PhabricatorApplicationTransactionEditor: triage TODO about getIsNewObject().

Mon, May 26, 08:56

valerio.bozzolan added a comment to T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes.

If I guess correctly, isNewObject is automatically guessed correctly, so, the root problem is probably here:

Mon, May 26, 08:46 · PHP 8 support

valerio.bozzolan added a comment to T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes.

Can you discover what's happening here? In theory the editor should detect isNewObject.

Mon, May 26, 08:37 · PHP 8 support

Sun, May 25

aklapper accepted D26026: Add a Before-Destruction Engine.

Some small nitpicks only. Makes sense to me, didn't spot any logic flaws, keeps close to already existing code in that very directory

Sun, May 25, 23:43

aklapper added a comment to D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.

Feed before applying the patch (T3922) and after applying the patch (T3923):

Screenshot From 2025-05-25 23-03-12.png (432×1 px, 101 KB)

Sun, May 25, 21:42

aklapper requested review of D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.

Sun, May 25, 21:40

aklapper added a revision to T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes: D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.

Sun, May 25, 21:40 · PHP 8 support

aklapper added a comment to T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes.

getIsCreateTransaction() should return true here but it doesn't.
I believe that this underlying problem can also trigger an exception, see https://phabricator.wikimedia.org/T361459

Sun, May 25, 20:59 · PHP 8 support

valerio.bozzolan added a project to T15236: Editing an Archived Project changes its color to Red: User-valerio.bozzolan.

Sun, May 25, 20:26 · User-valerio.bozzolan, Projects, Bug Reports

valerio.bozzolan added a project to T15978: Phriction: evaluate real page move (breaking change): User-valerio.bozzolan.

Sun, May 25, 20:25 · User-valerio.bozzolan, Discussion Needed, Phriction

valerio.bozzolan edited Description on User-valerio.bozzolan.

Sun, May 25, 20:23

valerio.bozzolan archived User-valerio.bozzolan.

Sun, May 25, 20:23

valerio.bozzolan moved T15213: Search: a Phriction entry does not mention "Phriction" nor "wiki" from Backlog to Feature Requests on the Phriction board.

Sun, May 25, 20:22 · Phriction, UX, User-valerio.bozzolan

aklapper created T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes.

Sun, May 25, 10:57 · PHP 8 support

aklapper closed T16059: Remove -webkit-font-smoothing and -moz-osx-font-smoothing from CSS as Resolved by committing rP555e569ff8c4: Remove macOS specific font smoothing CSS.

Sun, May 25, 10:04 · Wikimedia Hackathon 2025

aklapper closed D25989: Remove macOS specific font smoothing CSS.

Sun, May 25, 10:04

aklapper committed rP555e569ff8c4: Remove macOS specific font smoothing CSS.

Sun, May 25, 10:04

Sat, May 24

aklapper updated the diff for D25989: Remove macOS specific font smoothing CSS.

git rebase master

Sat, May 24, 16:13

aklapper updated the test plan for D26031: Allow using PCRE's just-in-time compilation.

Sat, May 24, 14:42

mainframe98 accepted D26031: Allow using PCRE's just-in-time compilation.

Sat, May 24, 14:08

aklapper added a revision to T16084: Stop disabling pcre.jit by default: D26031: Allow using PCRE's just-in-time compilation.

Sat, May 24, 12:49

aklapper requested review of D26031: Allow using PCRE's just-in-time compilation.

Sat, May 24, 12:49

aklapper created T16084: Stop disabling pcre.jit by default.

Sat, May 24, 12:46

aklapper closed T16075: TypeError: idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php as Resolved by committing rPed7abd7c41f4: Ignore bogus cards parameter string values in Hovercards calls.

Sat, May 24, 08:40

aklapper closed D26023: Ignore bogus cards parameter string values in Hovercards calls.

Sat, May 24, 08:40

aklapper committed rPed7abd7c41f4: Ignore bogus cards parameter string values in Hovercards calls.

Sat, May 24, 08:40

aklapper closed D26007: Remove unused CSS file aphront/panel-view.css.

Sat, May 24, 07:28

aklapper committed rPd784533cf71d: Remove unused CSS file aphront/panel-view.css.

Sat, May 24, 07:28

pppery added a comment to Q177: Should it be easier for non-community-members to submit security reports? (Answer 219).

Agreed.

Sat, May 24, 01:30

pppery added a comment to Q181: "Auth" - Multiple LDAP Servers (Answer 223).

Now you do.

Sat, May 24, 01:29

pppery added a member for Trusted Contributors: jgrammen-agilitypr.

Sat, May 24, 01:29

• l2dy created T16083: Replace remaining MyISAM tables with InnoDB.

Sat, May 24, 01:10

Fri, May 23

aklapper updated the diff for D26007: Remove unused CSS file aphront/panel-view.css.

git rebase master

Fri, May 23, 21:44

aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

no no I rock like a grapstar

Fri, May 23, 17:32

valerio.bozzolan accepted D26007: Remove unused CSS file aphront/panel-view.css.

You grep like a rockstar

Fri, May 23, 17:29

aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

Uh right, thanks! Let's do as mainframe98 says

Fri, May 23, 17:28

valerio.bozzolan removed a reviewer for D26007: Remove unused CSS file aphront/panel-view.css: valerio.bozzolan.

Fri, May 23, 17:26

valerio.bozzolan resigned from D26007: Remove unused CSS file aphront/panel-view.css.

Unlocking patch

Fri, May 23, 17:26

aklapper requested review of D26007: Remove unused CSS file aphront/panel-view.css.

Fri, May 23, 17:21

aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

In D26007#26996, @aklapper wrote:

@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.

Fri, May 23, 17:21

valerio.bozzolan added a subtask for T15018: Make Harbormaster more generally usable and extendable: T16041: Harbormaster Build Plan: improve input "Depends On".

Fri, May 23, 06:53 · Connor Gurney, Almanac/Drydock/Harbormaster

valerio.bozzolan added a parent task for T16041: Harbormaster Build Plan: improve input "Depends On": T15018: Make Harbormaster more generally usable and extendable.

Fri, May 23, 06:53 · User-valerio.bozzolan, UX, Feature Requests, Almanac/Drydock/Harbormaster

valerio.bozzolan added a project to T16041: Harbormaster Build Plan: improve input "Depends On": User-valerio.bozzolan.

Fri, May 23, 06:53 · User-valerio.bozzolan, UX, Feature Requests, Almanac/Drydock/Harbormaster

aklapper closed D25995: Remove orphan CSS selectors in PHUIFormView.

Fri, May 23, 00:08

aklapper committed rP5e64a0a81903: Remove orphan CSS selectors in PHUIFormView.

Fri, May 23, 00:08

Thu, May 22

aklapper added a comment to D26030: Fix project typeahead query with columns when string is not name prefix.

You're right, thank you (as usual)!

Thu, May 22, 17:13

aklapper updated the test plan for D26030: Fix project typeahead query with columns when string is not name prefix.

Thu, May 22, 17:13

aklapper updated the diff for D25995: Remove orphan CSS selectors in PHUIFormView.

git rebase master

Thu, May 22, 16:35

aklapper closed D25978: Fix wrong argument count in numerous calls' signatures.

Thu, May 22, 16:28

aklapper committed rPb174cce279aa: Fix wrong argument count in numerous calls' signatures.

Thu, May 22, 16:28

valerio.bozzolan requested changes to D26007: Remove unused CSS file aphront/panel-view.css.

Flagging as "andre is merging stuff https://we.phorge.it/D26007#26996"

Thu, May 22, 12:49

valerio.bozzolan updated the summary of D25995: Remove orphan CSS selectors in PHUIFormView.

Thu, May 22, 12:47

valerio.bozzolan accepted D25995: Remove orphan CSS selectors in PHUIFormView.

Very good job as usual 👍

Thu, May 22, 12:47

valerio.bozzolan accepted D26030: Fix project typeahead query with columns when string is not name prefix.

Nice. I'm 99% sure about the test plan, please see https://we.phorge.it/T16068#22703 before landing to adjust it, eventually.

Thu, May 22, 12:38

valerio.bozzolan added a comment to T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)".

Questions about the steps:

Thu, May 22, 12:24 · Bug Reports

aklapper updated the summary of D26030: Fix project typeahead query with columns when string is not name prefix.

Thu, May 22, 10:13

aklapper requested review of D26030: Fix project typeahead query with columns when string is not name prefix.

Thu, May 22, 10:10

aklapper added a revision to T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)": D26030: Fix project typeahead query with columns when string is not name prefix.

Thu, May 22, 10:10 · Bug Reports

aklapper closed D26006: Remove unused FatCow icon files.

Thu, May 22, 06:53

aklapper committed rP947b70441184: Remove unused FatCow icon files.

Thu, May 22, 06:53

Wed, May 21

jgrammen-agilitypr closed Q180: "Auth" - it is possible to have a provider (LDAP) configured via conf/custom as resolved.

Wed, May 21, 14:51 · Auth

valerio.bozzolan updated the diff for D26026: Add a Before-Destruction Engine.

fix last typo

Wed, May 21, 13:39

valerio.bozzolan updated the diff for D26026: Add a Before-Destruction Engine.

@return list<PhabricatorDestructionEngineExtension>

Wed, May 21, 13:33

aklapper added inline comments to D26026: Add a Before-Destruction Engine.

Wed, May 21, 12:59

valerio.bozzolan closed T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time), a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.

Wed, May 21, 09:59 · PHP 8 support

valerio.bozzolan closed D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.

Wed, May 21, 09:59

valerio.bozzolan closed T16082: Calendar: Fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72 when visiting the Event Create form with start and end dates (without time) as Resolved by committing rPaf4ac8bd9567: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from….

Wed, May 21, 09:59 · Calendar, PHP 8 support