These selectors currently do not get applied at all in Conpherence rooms when opening or creating URIs with anchors.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Today
Yesterday
git rebase master
Not really what we expected, but nice try
Not really what we expected, but nice try
@param loves $name
Can't wait to enjoy the production Grafana CPU graph of Wikimedia Phabricator after this change
In T15903#18783, @avivey wrote:pht() also does some escaping, formatting, and other safety related stuff
Mon, May 26
In D26032#27637, @valerio.bozzolan wrote:Probably one screenshot is missing (?)
In D26032#27621, @aklapper wrote:
add more and more PHPDoc, and fix typos - thanks
If I guess correctly, isNewObject is automatically guessed correctly, so, the root problem is probably here:
Can you discover what's happening here? In theory the editor should detect isNewObject.
Sun, May 25
Some small nitpicks only. Makes sense to me, didn't spot any logic flaws, keeps close to already existing code in that very directory
getIsCreateTransaction() should return true here but it doesn't.
I believe that this underlying problem can also trigger an exception, see https://phabricator.wikimedia.org/T361459
Sat, May 24
git rebase master
Agreed.
Now you do.
Fri, May 23
git rebase master
no no I rock like a grapstar
You grep like a rockstar
Uh right, thanks! Let's do as mainframe98 says
Unlocking patch
In D26007#26996, @aklapper wrote:@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.
Thu, May 22
You're right, thank you (as usual)!
git rebase master
Flagging as "andre is merging stuff https://we.phorge.it/D26007#26996"
Very good job as usual 👍
Nice. I'm 99% sure about the test plan, please see https://we.phorge.it/T16068#22703 before landing to adjust it, eventually.
Questions about the steps:
Wed, May 21
- fix last typo
- @return list<PhabricatorDestructionEngineExtension>