Page MenuHomePhorge
Feed All Stories

All Stories
Use Results
Edit Query

Today

bekay updated the answer details for Q172: Hover items are blocking the view (Answer 218).
Tue, Apr 15, 18:10
bekay claimed T16034: Stop blocking UX behavior of hovercards.
Tue, Apr 15, 18:09 · UX
bekay created T16034: Stop blocking UX behavior of hovercards.
Tue, Apr 15, 18:09 · UX
bekay updated the answer details for Q172: Hover items are blocking the view (Answer 218).
Tue, Apr 15, 17:36
bekay requested review of D25965: Disables opening of hovercard if trigger node is inside hovercard.
Tue, Apr 15, 17:35
bekay added a revision to T16029: Hovercard trigger inside hovercard content closes hovercard: D25965: Disables opening of hovercard if trigger node is inside hovercard.
Tue, Apr 15, 17:35 · UX, Bug Reports
bekay added a comment to D25962: Implements remarkup rendering with the drawio viewer component.

@mturdus the page option is now 1-indexed and I have fixes some css styles for a better rendering of different options.

Tue, Apr 15, 16:59
bekay updated the diff for D25962: Implements remarkup rendering with the drawio viewer component.
  • - make page option 1-indexed
Tue, Apr 15, 16:57
aklapper edited the content of Next Up.
Tue, Apr 15, 15:04
mainframe98 closed D25957: Replace usages of PhutilProxyException.
Tue, Apr 15, 14:46
mainframe98 committed rPbf2dc1194778: Replace usages of PhutilProxyException.
Replace usages of PhutilProxyException
Tue, Apr 15, 14:46
mainframe98 updated the diff for D25957: Replace usages of PhutilProxyException.

Rebase and re-run tests with expected LANG

Tue, Apr 15, 14:45
aklapper created T16033: "To:" and "CC:" Recipient Hint footers in mail notifications list disabled user accounts.
Tue, Apr 15, 06:24

Yesterday

aklapper closed T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery as Resolved by committing rP7a29a6d15278: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Mon, Apr 14, 20:21
aklapper closed D25964: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Mon, Apr 14, 20:21
aklapper committed rP7a29a6d15278: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery
Mon, Apr 14, 20:21
20after4 added a comment to Q173: Why do Milestones in parent project's Workboard seemingly randomly hide tasks?.

@nib please do submit a diff, I'd be happy to review it.

Mon, Apr 14, 15:53
valerio.bozzolan accepted D25964: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.

Thaanks

Mon, Apr 14, 13:21
aklapper requested review of D25964: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Mon, Apr 14, 12:18
aklapper added a revision to T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery: D25964: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Mon, Apr 14, 12:18
aklapper created T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Mon, Apr 14, 12:13
aklapper edited the content of Next Up.
Mon, Apr 14, 10:14
mturdus updated the test plan for D25963: Phriction: Invalid position actions sidebar when large image on top.
Mon, Apr 14, 08:24
mturdus requested review of D25963: Phriction: Invalid position actions sidebar when large image on top.
Mon, Apr 14, 08:24
mturdus added a revision to T16031: Phriction: Invalid position actions sidebar when large image on top: D25963: Phriction: Invalid position actions sidebar when large image on top.
Mon, Apr 14, 08:24
mturdus created T16031: Phriction: Invalid position actions sidebar when large image on top.
Mon, Apr 14, 08:16
bekay accepted D25959: Simplify project regex further.

Works for me. Tested on our firm instance.

Mon, Apr 14, 08:01
bekay added a comment to D25962: Implements remarkup rendering with the drawio viewer component.
In D25962#25652, @mturdus wrote:

This looks very pro !

I found one small issue:
the page parameter seems to be zero-based. Can you make it one-based, so that the first page can be accessed with page=1 instead of page=0 ?

Mon, Apr 14, 07:52
mturdus added a comment to D25962: Implements remarkup rendering with the drawio viewer component.

This looks very pro !

Mon, Apr 14, 07:46
aklapper updated the summary of D25957: Replace usages of PhutilProxyException.
Mon, Apr 14, 07:15
aklapper accepted D25957: Replace usages of PhutilProxyException.

Thanks! Accepting per testing in D25956#25577

Mon, Apr 14, 07:15

Sun, Apr 13

aklapper closed T16030: Expose time with File upload date as Resolved by committing rPafd21b827434: Expose time with File upload date.
Sun, Apr 13, 21:57
aklapper closed D25961: Expose time with File upload date.
Sun, Apr 13, 21:57
aklapper committed rPafd21b827434: Expose time with File upload date.
Expose time with File upload date
Sun, Apr 13, 21:57
valerio.bozzolan accepted D25961: Expose time with File upload date.

Nice!

Sun, Apr 13, 20:23
mainframe98 accepted D25961: Expose time with File upload date.
Sun, Apr 13, 12:01
bekay updated the test plan for D25962: Implements remarkup rendering with the drawio viewer component.
Sun, Apr 13, 10:52
mainframe98 updated the diff for D25899: Rebuild quickstart.sql.

Update quickstart with paste mailkey removal

Sun, Apr 13, 10:46
bekay added a revision to T15806: Use drawio viewer for rendering of diagrams: D25962: Implements remarkup rendering with the drawio viewer component.
Sun, Apr 13, 10:42 · Diagrams (Extension)
bekay requested review of D25962: Implements remarkup rendering with the drawio viewer component.
Sun, Apr 13, 10:42
mainframe98 closed D25956: Replace usages of PhutilProxyException.
Sun, Apr 13, 10:03
mainframe98 committed rARC08432f5a24b3: Replace usages of PhutilProxyException.
Replace usages of PhutilProxyException
Sun, Apr 13, 10:03
mainframe98 updated the diff for D25956: Replace usages of PhutilProxyException.

Capitalize consistently

Sun, Apr 13, 10:02
mainframe98 closed D25900: Remove the onboard "mailKey" from Paste.
Sun, Apr 13, 09:56
mainframe98 committed rP9c388c65f628: Remove the onboard "mailKey" from Paste.
Remove the onboard "mailKey" from Paste
Sun, Apr 13, 09:56
bekay committed R5:451e5cf8aca0: Reverts faulty git merge.
Reverts faulty git merge
Sun, Apr 13, 09:25
bekay closed D25960: Reverts faulty git merge.
Sun, Apr 13, 09:25
bekay updated the diff for D25960: Reverts faulty git merge.

Reset to original diff.

Sun, Apr 13, 09:16
bekay updated the diff for D25960: Reverts faulty git merge.

Update

Sun, Apr 13, 09:12
mturdus accepted D25960: Reverts faulty git merge.
Sun, Apr 13, 04:59

Sat, Apr 12

aklapper closed D25942: Herald Transcripts: Use μs instead of us for microseconds.
Sat, Apr 12, 23:24
aklapper committed rP08637ce082d0: Herald Transcripts: Use μs instead of us for microseconds.
Herald Transcripts: Use μs instead of us for microseconds
Sat, Apr 12, 23:24
aklapper added a revision to T16030: Expose time with File upload date: D25961: Expose time with File upload date.
Sat, Apr 12, 22:58
aklapper requested review of D25961: Expose time with File upload date.
Sat, Apr 12, 22:58
aklapper created T16030: Expose time with File upload date.
Sat, Apr 12, 22:55
aklapper closed D25880: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
Sat, Apr 12, 22:46
aklapper committed rP4d98c0a45586: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
Replace some AphrontView::setUser() calls with AphrontView::setViewer()
Sat, Apr 12, 22:46
aklapper updated the summary of D25957: Replace usages of PhutilProxyException.
Sat, Apr 12, 20:52
aklapper accepted D25900: Remove the onboard "mailKey" from Paste.
In D25900#25559, @mainframe98 wrote:

I had to go dig for this, but from what I understand of looking at PhabricatorMetaMTAMailProperties, which is the class now responsible for this functionality, creating a mail key only happens when its loadMailKey method is called. That method is only called when email functionality engaged.

Sat, Apr 12, 20:46
aklapper updated the summary of D25956: Replace usages of PhutilProxyException.
Sat, Apr 12, 20:46
aklapper accepted D25956: Replace usages of PhutilProxyException.

Thanks! Small nitpick: I'd probably change @deprecated call Exception::getPrevious directly. to @deprecated Call Exception::getPrevious() directly.

Sat, Apr 12, 20:45
bekay requested review of D25960: Reverts faulty git merge.
Sat, Apr 12, 13:43
bekay added a comment to D25612: Use more css and phorge standard elements for application view.

@mturdus I have landed this but have reintroduced this code which you have removed - I hope you can remove it again. Sorry for that!

Sat, Apr 12, 13:19 · Arcanist, Diagrams (Extension)
bekay closed D25612: Use more css and phorge standard elements for application view.
Sat, Apr 12, 13:12 · Arcanist, Diagrams (Extension)
bekay committed R5:3170bc15592e: Use more css and phorge standard elements for application view.
Use more css and phorge standard elements for application view
Sat, Apr 12, 13:12
mainframe98 added a comment to D25900: Remove the onboard "mailKey" from Paste.
In D25900#25554, @aklapper wrote:

What is (or rather was, I guess) that mailKey thingie good for?

Sat, Apr 12, 12:38
bekay added a comment to D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.
In D25619#22881, @aklapper wrote:

@bekay: Would you like to merge this?

Sat, Apr 12, 12:14
bekay closed T15809: Homepage will overflow on small screens when feed content is too long as Resolved by committing rPd3cbfd952e15: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav….
Sat, Apr 12, 12:12 · Feed, UX
bekay closed D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.
Sat, Apr 12, 12:12
bekay committed rPd3cbfd952e15: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav….
Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav…
Sat, Apr 12, 12:12
bekay updated the task description for T16029: Hovercard trigger inside hovercard content closes hovercard.
Sat, Apr 12, 11:39 · UX, Bug Reports
bekay claimed T16029: Hovercard trigger inside hovercard content closes hovercard.
Sat, Apr 12, 11:37 · UX, Bug Reports
bekay created T16029: Hovercard trigger inside hovercard content closes hovercard.
Sat, Apr 12, 11:37 · UX, Bug Reports
aklapper added a comment to D25900: Remove the onboard "mailKey" from Paste.

What is (or rather was, I guess) that mailKey thingie good for? Or more relevant, I assume it's intentionally after performing the Test Plan steps above that creating a new Paste does not create a new row in phabricator_metamta.metamta_mailproperties?
Apart from that, seems to work as expected. :) Thanks!

Sat, Apr 12, 11:06
aklapper updated the test plan for D25900: Remove the onboard "mailKey" from Paste.
Sat, Apr 12, 11:01

Fri, Apr 11

pppery updated the diff for D25959: Simplify project regex further.

Fix

Fri, Apr 11, 17:41
pppery updated the diff for D25959: Simplify project regex further.

Add test

Fri, Apr 11, 17:38
bekay awarded T15961: Should we adopt modern PHP type hints in Phorge source code? a Like token.
Fri, Apr 11, 15:47 · Phorge Development Tools, Discussion Needed
valerio.bozzolan added a comment to D25959: Simplify project regex further.

Wow, super fast thanks. Maybe nice to expand a bit the src/applications/project/remarkup/__tests__/ProjectRemarkupRuleTestCase.php

Fri, Apr 11, 15:33
pppery requested review of D25959: Simplify project regex further.
Fri, Apr 11, 15:27
pppery added a revision to T16028: New project remarkup rule misses some project names: D25959: Simplify project regex further.
Fri, Apr 11, 15:27 · Bug Reports, Remarkup
pppery added a comment to T16028: New project remarkup rule misses some project names.

That's true of all projects - Remarkup here for instance.

Fri, Apr 11, 15:13 · Bug Reports, Remarkup
bekay added a comment to T16028: New project remarkup rule misses some project names.
In T16028#21601, @pppery wrote:

{#js-draw-lib} does work.

Fri, Apr 11, 15:12 · Bug Reports, Remarkup
pppery added a comment to T16028: New project remarkup rule misses some project names.

{#js-draw-lib} does work.

Fri, Apr 11, 15:07 · Bug Reports, Remarkup
bekay added Q172: Hover items are blocking the view (Answer 218).
Fri, Apr 11, 15:07
bekay updated subscribers of T16028: New project remarkup rule misses some project names.

@pppery I don't know if you wanna step in, since the change was introduced by you.

Fri, Apr 11, 14:41 · Bug Reports, Remarkup
bekay created T16028: New project remarkup rule misses some project names.
Fri, Apr 11, 14:37 · Bug Reports, Remarkup
aklapper requested review of D25958: PHPDoc: Fix @return string for methods which can also return null.
Fri, Apr 11, 09:51
aklapper edited the content of Next Up.
Fri, Apr 11, 08:55
aklapper closed T15985: Fix UX regression in Phame as Resolved by committing rP12991c0d377a: Fix overlapping elements in Phame for >1791px width.
Fri, Apr 11, 08:54 · Phame, Bug Reports, UX
aklapper closed T15985: Fix UX regression in Phame, a subtask of T15920: Make table of contents visible when using wide screens, as Resolved.
Fri, Apr 11, 08:54 · UX, Feature Requests
aklapper closed D25873: Fix overlapping elements in Phame for >1791px width.
Fri, Apr 11, 08:54
aklapper committed rP12991c0d377a: Fix overlapping elements in Phame for >1791px width.
Fix overlapping elements in Phame for >1791px width
Fri, Apr 11, 08:54
aklapper updated the diff for D25873: Fix overlapping elements in Phame for >1791px width.

git rebase master

Fri, Apr 11, 08:53
avivey accepted D25873: Fix overlapping elements in Phame for >1791px width.
Fri, Apr 11, 07:55
mainframe98 accepted D25955: Unhandled Exception: Add last call to error message.

This is great.

Fri, Apr 11, 07:03
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Strip proceeding slash of path; wrap error message in quotation marks

Fri, Apr 11, 07:02

Thu, Apr 10

mainframe98 added a comment to D25955: Unhandled Exception: Add last call to error message.

Much better, two nitpicks:

Thu, Apr 10, 17:44
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Only expose last call location if phabricator.developer-mode is set

Thu, Apr 10, 11:21
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Thanks! Indeed I should have tested this more.

Thu, Apr 10, 11:17
Next
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0