I didn't give up on this one and, since I prefer using the dark theme on my day to day activity, I know there are a lot of work to be done to reach something nice.
I'll try to move forward on next weeks...
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Nov 22 2023
Nov 22 2023
bob closed T15629: PHP 8.1 "strlen(null)" exception when importing a subversion commit, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
bob committed rPcf8d5d60a594: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser
bob closed T15628: PHP 8.1 "strlen(null)" exception when displaying a 'recent' subversion commit, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
bob committed rPacfb44d6679e: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Nov 20 2023
Nov 20 2023
Great, I'm a little bit busy, professionally speaking but, I'll try to land it this week !
Sep 20 2023
Sep 20 2023
Honestly, I don't know why we have old commits improperly filled, you can maybe play with svnadmin command on a dummy repo as described here : Change author of SVN commit
Aug 28 2023
Aug 28 2023
bob requested review of D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.
bob updated the summary of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
bob updated the summary of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
bob updated the summary of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
bob requested review of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
bob added a comment to T15628: PHP 8.1 "strlen(null)" exception when displaying a 'recent' subversion commit.
Finally, after additional tests, I guess these issue are not related (as related in T15629)
You're right valerio, this sign in is an automatic reflex since my Phorge instance is private ;)
Fix answer background color when using Dark Mode in Ponder
Aug 18 2023
Aug 18 2023
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Ouch ! Thanks for reporting ! I'll have a look on UI examples (these pages are really cool !) to improve the proposal !
BTW, I'll be away next week so... This will not move forward right now...
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Great, let's prepare for landing ! BTW, I like your images, espacially this one...
bob closed T15605: PHP 8.1 "strlen(null)" exception when deploying a new instance of Phorge, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument
Great news ! I'll land it right now !
Aug 17 2023
Aug 17 2023
Revision has been updated. Any idea why tests/lint were skipped ?
Updating D25394: Simplify base_uri variable check
Fix hovercard background color when using Dark Mode
bob added a revision to T15056: Improve Dark Mode: D25403: Improve CelerityDarkModePostprocessor shade colors.
IMO, this depends on the objective of this check, I mean, does this check aim to verify if this parameter is defined or does it aim to verify if this parameter looks valid...
Maybe I'm wrong but I guess that the first option was in mind here else a regex would probable be a better approach since the "1" would be considered as a valid URI whereas "0" would not...
Several ideas/leads about the fact you cannot reproduce :
bob committed rP747d7db24161: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument
bob added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
As a minion, I'm only working for the glory of my boss ! :P
bob committed rP17befe9bca5b: Fix source code viewer background color when using Dark Mode in Diffusion.
Fix source code viewer background color when using Dark Mode in Diffusion
Updating D25399: Reverting formatUser method prototype
bob added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Thanks for the patch suggestion ! Then we can :
Fix a PHP 8.1 deprecated use of preg_match with a NULL argument
Aug 16 2023
Aug 16 2023
I removed another diff's modification included by Arcanist (there is definitely something about arc command that I'm missing...)
When an fatal exception is triggered :
bob updated the summary of D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
Because there are more and more referenced issues and, because some of them may need further discussion in order to find the best solution, IMHO it may be a good idea to create a sub task for each issue reported isn't it ?
bob updated the diff for D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
Updating D25396: Include updated celerity map file
bob requested review of D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
bob added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
I was updating the diff when I saw below that function getWebsocketURI may also be affected by a NULL issue :
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0