Thanks

I like your option names. I like to specify PHIDs and not numeric IDs so it's more portable against import/exports 👍 Let's add Discussion Needed to attract some +1 or nice suggestions.

About the implementation, maybe we can:

1. add some early lines in PhabricatorFileStorageEngine#loadStorageEngines($size) to throw an early exception if the $size is over this new configuration. Maybe adding a new parameter to receive the PhabricatorUser $viewer
2. perhaps a refactor inside FileAllocateConduitAPIMethod::execute() to pass the $viewer
3. SOME MAGIC STUFF to check if an user is in a group (I don't know lol) 🦄

Sounds reasonable.

I think files.ignore-file-size- can maybe be a Policy object, to allow maximum flexibility?

Uh, that would be so good. So you can say "When the moon is full".

Sub-task is maybe, add "Policy" type support for Config.

Yeah, I agree, though I would then only work on implementing files.maximum-file-size because we don't really care that much about adding exceptions to the rule (as far as I know lol)

add some early lines in PhabricatorFileStorageEngine#loadStorageEngines($size) to throw an early exception if the $size is over this new configuration. Maybe adding a new parameter to receive the PhabricatorUser $viewer

I've done it a bit earlier, in PhabricatorFile#buildFromFileData($data, $params). As for getting the viewer (which I presume is the uploader?), I nabbed it off from $params['authorPHID']

We can also ship this feature in two phases, so, first, adding the option files.maximum-file-size, and then the second one when it's ready or requested lol

So still patch welcome upstream (here), especially if you don't want to maintain that locally

Sounds good to me :p

Wrote the code for the first phase :p

Should I submit the patch right now, or after the Discussion Needed tag is removed?

Feel free to show something early :) That would attract more attention than the Discussion Needed tag I bet

(we can probably keep this ticket open, so that we have the 2nd part on the backlog. I'm pretty sure we want it to happen "eventually".)