You are totally right, I've never seen native browser notifications too. For some reasons I've always confused Phorge's popup with these since they are quite similar in my environment

Is there a possibility that you have a browser extension privacy-focused that automatically denies this permission?

Any error in your browser console?

Can you share a screenshot after you click on that button?

Another related bug is that also referenced/attached files are kept on the old page. Maybe different bug report under same umbrella.

Let's promote to bug :D

The current workaround I'm proposing is just:

Uh I'm very happy about this at work! Running since months smoothly. I can close Google Calendar forever 🎉

I see a red light in a unit test but it works on me after the patch src/parser/__tests__/ArcanistBundleTestCase.php - any comment on that? Anyway sgtm since it needs the foreach() stuff later.

It also works with icons that are spinning lol thanks

I've discovered a minor UX problem if an heading has a nice icon. Check it:

Welcome in the family of Trusted Contributors \o/ try again plz

In D25853#22877, @BlankEclair wrote:

$params has an optional authorPHID key, whose value is... well, the PHID of the author (if applicable). I suppose we can reuse that here?

Hoping to help: maybe maybe, we can be prepared to receive that User $actor but: null as default \o/ and we can just skip this additional limitation if it's null, assuming that null = SomebodyImportant™

Ouch we should maybe already skip this limit if the user has $user->isOmnipotent(), otherwise some daemons may crash.

Thanks folks 💃 Let's land and open visibility, so other people can read more and cherry-pick in their stable if they need.

I forgot to accept but please consider the little cute small comment to add the corner case for the background ajax request, that I suspect it may work too and I hope with less unexpected situations. There was probably a reason for that isFormPost(). For example see isContinueRequest() that is even stricter in a way. Thanks :)

I like it :) Thanks! It works on my machine following the test plan.

Feel free to show something early :) That would attract more attention than the Discussion Needed tag I bet

Yep, manually setting your unverified (and not verifiable) email would still be possible 👍 just two clicks are needed from this kind of pages:

(I cannot edit this task lol - I would like to add Spam mitigation tag to keep an additional eye on these nice things)

We can also ship this feature in two phases, so, first, adding the option files.maximum-file-size, and then the second one when it's ready or requested lol

last change promise lol

arc unit

harden

\o/

also tried to fix PhutilRemarkupEngineTestCase

but fails in link-edge-cases.txt now (thus it's likely not complete):

Double slam-accept

Uh, that would be so good. So you can say "When the moon is full".

Take for example this commit that has a default identity:

Limitation: to steal a commit identity, it must be the default. Sorry I forgot to say.

In T15965#20052, @speck wrote:

What can a malicious user accomplish by claiming unverified email for commits?

I like your option names. I like to specify PHIDs and not numeric IDs so it's more portable against import/exports 👍 Let's add Discussion Needed to attract some +1 or nice suggestions.