Page MenuHomePhorge
Feed All Stories

Aug 8 2024

valerio.bozzolan added a comment to T15908: More Useful "Quick Create" button on Workboard Columns.

I wonder if "Workboard Triggers" may do the job here.

Aug 8 2024, 15:04 · Feature Requests, Workboard
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

I've filed T15908 for the "quick create from column to do what I mean".

Aug 8 2024, 14:54
avivey created T15908: More Useful "Quick Create" button on Workboard Columns.
Aug 8 2024, 14:52 · Feature Requests, Workboard
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

(@arp - the images you pasted did not get Attached, so they are Private; Please set them manually to Public so they can be seen. We have an open ticket for that somewhere)

Aug 8 2024, 14:24
valerio.bozzolan retitled D25363: Calendar Import: calendar uploader is not anymore an alien from Match yourself from Imported Events Invitees
Aug 8 2024, 12:00
valerio.bozzolan updated the diff for D25363: Calendar Import: calendar uploader is not anymore an alien.

be based on unit tests

Aug 8 2024, 11:54
revi published D25617: docs/file_domain: remove cloudflare mention of autominify for review.

It's 3 days past the scheduled execution date but the settings in dashboard and docs are still there.

Aug 8 2024, 10:28
valerio.bozzolan requested review of D25767: Calendar Import: add unit tests to cover participants.
Aug 8 2024, 10:27
valerio.bozzolan added a revision to T15564: Allow yourself to be Invited in Imported Events: D25767: Calendar Import: add unit tests to cover participants.
Aug 8 2024, 10:27 · User-valerio.bozzolan, Calendar
valerio.bozzolan added a revision to T15906: Add unit tests for Calendar imports: D25767: Calendar Import: add unit tests to cover participants.
Aug 8 2024, 10:27 · User-valerio.bozzolan, Calendar
arp added a comment to Q144: Support for arc work T12345 (workOnTask workflow).

I see. So, is that functionality already a part of arc diff? In other words, if arc work T123 would have worked exactly the same way as arc work branch-name (by creating a branch that's called either T123 or branch-name), then arc diff would correctly link it?

Aug 8 2024, 06:13 · Feature Requests, Arcanist

Aug 7 2024

Ekubischta added a comment to Q144: Support for arc work T12345 (workOnTask workflow).

Yes - it works seamlessly because if the local branch has a task number in it, the diff is automatically linked to that task when you run arc diff

Aug 7 2024, 19:33 · Feature Requests, Arcanist
aklapper closed D25762: Fix 404 link in Diviner to "Configuring File Storage" article.
Aug 7 2024, 15:41
aklapper committed rPb74f1ad519e8: Fix 404 link in Diviner to "Configuring File Storage" article.
Fix 404 link in Diviner to "Configuring File Storage" article
Aug 7 2024, 15:41
valerio.bozzolan abandoned D25766: Arcanist Text Linter: do not break the "ics" special format.

OK thanks

Aug 7 2024, 14:38
aklapper created T15907: Make Open Graph protocol meta tags code apply to any objects.
Aug 7 2024, 11:59
avivey added a comment to D25766: Arcanist Text Linter: do not break the "ics" special format.

It's probably better to exclude ICS files from TXT in .arclint, or define their own section, rather then add hard-coded exceptions in here.

Aug 7 2024, 11:57
aklapper closed T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 7 2024, 11:57 · PHP 8 support
aklapper closed T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction as Resolved by committing rP88225b99f2fc: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.
Aug 7 2024, 11:57 · PHP 8 support
aklapper closed D25765: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.
Aug 7 2024, 11:57
aklapper committed rP88225b99f2fc: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.
Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction
Aug 7 2024, 11:57
aklapper closed T15472: Support Open Graph protocol (at least in Maniphest) as Resolved by committing rP89778dc9e617: Add Open Graph protocol meta tags to Maniphest task pages.
Aug 7 2024, 11:54 · User-valerio.bozzolan, Affects-Wikimedia, Maniphest
aklapper closed D25668: Add Open Graph protocol meta tags to Maniphest task pages.
Aug 7 2024, 11:54
aklapper committed rP89778dc9e617: Add Open Graph protocol meta tags to Maniphest task pages.
Add Open Graph protocol meta tags to Maniphest task pages
Aug 7 2024, 11:54
valerio.bozzolan updated the diff for D25766: Arcanist Text Linter: do not break the "ics" special format.

remove unuseful newline

Aug 7 2024, 10:43
valerio.bozzolan requested review of D25766: Arcanist Text Linter: do not break the "ics" special format.
Aug 7 2024, 10:09
valerio.bozzolan added a revision to T15905: Linter: do not break "ics" files: D25766: Arcanist Text Linter: do not break the "ics" special format.
Aug 7 2024, 10:08 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan triaged T15905: Linter: do not break "ics" files as Normal priority.
Aug 7 2024, 09:58 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan added a parent task for T15905: Linter: do not break "ics" files: T15906: Add unit tests for Calendar imports.
Aug 7 2024, 09:57 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan added a subtask for T15906: Add unit tests for Calendar imports: T15905: Linter: do not break "ics" files.
Aug 7 2024, 09:57 · User-valerio.bozzolan, Calendar
valerio.bozzolan created T15906: Add unit tests for Calendar imports.
Aug 7 2024, 09:56 · User-valerio.bozzolan, Calendar
valerio.bozzolan claimed T15905: Linter: do not break "ics" files.
Aug 7 2024, 09:47 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan created T15905: Linter: do not break "ics" files.
Aug 7 2024, 09:47 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
arp updated the answer details for Q146: How to tag? (Answer 182).
Aug 7 2024, 09:46
arp added a comment to Q146: How to tag? (Answer 181).

Oh wow, that is a really unexpected way to create tags.

Aug 7 2024, 09:46
arp added Q146: How to tag? (Answer 182).
Aug 7 2024, 09:45
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

We have a public project tag used by a team. Some tasks associated with that public project tag are public tasks visible to everyone and anyone, so they are not in an access-restricted Space but default S1. Some tasks associated with that public project tag are temporarily non-public, "secret" tasks that should only be visible to that team and nobody else, so they are in an access-restricted Space that can only be accessed by team members.

Aug 7 2024, 09:40
valerio.bozzolan accepted D25762: Fix 404 link in Diviner to "Configuring File Storage" article.

yesyes

Aug 7 2024, 09:19
aklapper added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

In my installation this would not be a reasonable expectation. We have a public project tag used by a team. Some tasks associated with that public project tag are public tasks visible to everyone and anyone, so they are not in an access-restricted Space but default S1. Some tasks associated with that public project tag are temporarily non-public, "secret" tasks that should only be visible to that team and nobody else, so they are in an access-restricted Space that can only be accessed by team members.
So I'd rather envision a Herald rule: for a Maniphest task, if is newly created is true && Space is Sxx, then add project tag #whatever. (The other way round is not particularly feasible: The task would have a default view setting for a moment and potentially visible to outsiders, before moving it to a view-restricted Space).

Aug 7 2024, 09:02
aklapper added Q146: How to tag? (Answer 181).
Aug 7 2024, 08:51
arp asked Q146: How to tag?.
Aug 7 2024, 08:39
arp added a comment to T15546: Terminology inconsistency: Hashtags vs Tags vs Projects.

I was confused about why I couldn't tag a task with any random tag that I wanted to create on the fly as I'd do in Meta's Phabricator. It took me some time to realize that tags mean projects.

Aug 7 2024, 08:31
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

To clarify: currently existing auto-tagging is not about the column from which the task is created. It's about tagging with the project to which the column belongs.

Aug 7 2024, 08:17
avivey added a member for Trusted Contributors: arp.
Aug 7 2024, 07:47
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

It's not "impossible" on the technical level, it's just not obviously the right solution.

Aug 7 2024, 07:46
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

But also, why is it impossible? When a task is created from a column, it automatically pre-populates the tag column with the project it is created from. It seems trivial to implement a patch that would auto-detect the project's space and set it accordingly for the task.

Aug 7 2024, 07:06
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

Then, if every project could choose its own Task Create/Edit Form Configuration, it would solve the issue. Maybe form configurations could be tagged with projects, and when no tag = show for all projects?

Aug 7 2024, 06:57
arp added a comment to Q144: Support for arc work T12345 (workOnTask workflow).

I'd assume that it also links the task and the diff together and optionally allows to close the task automatically on diff land?

Aug 7 2024, 05:11 · Feature Requests, Arcanist

Aug 6 2024

Ekubischta added a comment to Q144: Support for arc work T12345 (workOnTask workflow).

Just adding references

Aug 6 2024, 23:30 · Feature Requests, Arcanist
avivey added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

...set it by default to the space that the project belongs to...

Aug 6 2024, 13:59
arp added a comment to Q145: Auto-set user task access depending on the project visibility (Answer 180).

Thanks, that's useful to know!

Aug 6 2024, 12:48
avivey updated the answer details for Q145: Auto-set user task access depending on the project visibility (Answer 180).
Aug 6 2024, 12:03
avivey added Q145: Auto-set user task access depending on the project visibility (Answer 180).
Aug 6 2024, 12:00
arp asked Q145: Auto-set user task access depending on the project visibility.
Aug 6 2024, 07:36 · Maniphest
avivey added a comment to T15903: Logged exceptions/errors should ignore user's language setting and be always in English.

Ideally strings not shown to the user would also not be wrapped in pht(...) at all to avoid wasting translator's time.

Aug 6 2024, 06:41

Aug 5 2024

aklapper updated the task description for T15903: Logged exceptions/errors should ignore user's language setting and be always in English.
Aug 5 2024, 16:55
aklapper updated the diff for D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

Remove unneeded if statements.

Aug 5 2024, 16:33
aklapper added a comment to D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

Thanks. Have you already tried with just CSS? Any issue in that?

Aug 5 2024, 16:29
pppery added a comment to T15903: Logged exceptions/errors should ignore user's language setting and be always in English.

Ideally strings not shown to the user would also not be wrapped in pht(...) at all to avoid wasting translator's time. This is contrary to the documentation inherited from old upstream at https://we.phorge.it/book/contrib/article/internationalization/, though,

Aug 5 2024, 16:22
aklapper created T15904: Replace calls to PhutilProxyException with PhutilErrorHandler.
Aug 5 2024, 15:39
aklapper created T15903: Logged exceptions/errors should ignore user's language setting and be always in English.
Aug 5 2024, 15:29
aklapper updated the diff for D25765: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.

Remove typo

Aug 5 2024, 15:04
aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.

Aug 5 2024, 12:44 · Bug Reports, Remarkup, Affects-Wikimedia
valerio.bozzolan accepted D25765: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.

lgtm

Aug 5 2024, 12:17
aklapper requested review of D25765: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.
Aug 5 2024, 11:43
aklapper added a revision to T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction: D25765: Fix PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.
Aug 5 2024, 11:43 · PHP 8 support
aklapper created T15902: PHP 8.1 "strlen(null)" exception in ManiphestTaskPointsTransaction.
Aug 5 2024, 11:38 · PHP 8 support
avivey added a comment to D25743: Fix stripping headers from proxy requests to other cluster nodes.

I did some digging:

Aug 5 2024, 04:02

Aug 4 2024

aklapper closed T15810: Exception when "limit" (page size) API parameter is float, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Aug 4 2024, 10:16 · PHP 8 support
aklapper closed T15810: Exception when "limit" (page size) API parameter is float as Resolved by committing rP1cc04fb83cd5: Explicitly cast "limit" (page size) API parameter to int.
Aug 4 2024, 10:16 · PHP 8 support
aklapper closed D25614: Explicitly cast "limit" (page size) API parameter to int.
Aug 4 2024, 10:16
aklapper committed rP1cc04fb83cd5: Explicitly cast "limit" (page size) API parameter to int.
Explicitly cast "limit" (page size) API parameter to int
Aug 4 2024, 10:16
aklapper updated the diff for D25614: Explicitly cast "limit" (page size) API parameter to int.

Create $page_size var to avoid casting twice

Aug 4 2024, 10:13
aklapper closed T15897: Allow to copy file path from file header in web changeset view as Resolved by committing rPec6ba6966686: Add Copy file path button to file header bar in Differential/Diffusion.
Aug 4 2024, 09:53
aklapper closed D25757: Add Copy file path button to file header bar in Differential/Diffusion.
Aug 4 2024, 09:53
aklapper committed rPec6ba6966686: Add Copy file path button to file header bar in Differential/Diffusion.
Add Copy file path button to file header bar in Differential/Diffusion
Aug 4 2024, 09:53
aklapper closed D25737: Log Herald rules with invalid actions via phlog().
Aug 4 2024, 09:36
aklapper committed rP0bfe9ca88f41: Log Herald rules with invalid actions via phlog().
Log Herald rules with invalid actions via phlog()
Aug 4 2024, 09:36
aklapper closed D25736: Log Herald rules having disabled Herald rules as condition via phlog().
Aug 4 2024, 09:35
aklapper committed rP71615f4b9917: Log Herald rules having disabled Herald rules as condition via phlog().
Log Herald rules having disabled Herald rules as condition via phlog()
Aug 4 2024, 09:35
aklapper closed D25735: Log Herald rules with invalid keys via phlog().
Aug 4 2024, 09:35
aklapper committed rPf6302c7ee300: Log Herald rules with invalid keys via phlog().
Log Herald rules with invalid keys via phlog()
Aug 4 2024, 09:35
aklapper updated the summary of D25735: Log Herald rules with invalid keys via phlog().
Aug 4 2024, 09:32
aklapper renamed T15885: Herald rule referring to an invalid key silently fails from Fail more verbosely in Herald rules for invalid keys to Herald rule referring to an invalid key silently fails.
Aug 4 2024, 09:32 · Herald
aklapper updated the summary of D25736: Log Herald rules having disabled Herald rules as condition via phlog().
Aug 4 2024, 09:32
aklapper closed T15899: Do not add actor as subscriber when removing a comment as Resolved by committing rP93c9afd2f387: Do not add actor as subscriber when removing a comment.
Aug 4 2024, 09:30
aklapper closed D25760: Do not add actor as subscriber when removing a comment.
Aug 4 2024, 09:30
aklapper committed rP93c9afd2f387: Do not add actor as subscriber when removing a comment.
Do not add actor as subscriber when removing a comment
Aug 4 2024, 09:30
aklapper closed T15889: Apache 2.4.61 throws a 403 Forbidden for links containing %3F as Resolved by committing rP4da3b096b081: Configuration Guide: Set UnsafeAllow3F for Apache RewriteRule.
Aug 4 2024, 07:59
aklapper closed D25739: Configuration Guide: Set UnsafeAllow3F for Apache RewriteRule.
Aug 4 2024, 07:59
aklapper committed rP4da3b096b081: Configuration Guide: Set UnsafeAllow3F for Apache RewriteRule.
Configuration Guide: Set UnsafeAllow3F for Apache RewriteRule
Aug 4 2024, 07:59
aklapper updated the summary of D25739: Configuration Guide: Set UnsafeAllow3F for Apache RewriteRule.
Aug 4 2024, 07:58
avivey raised the priority of T15401: Make the Remarkup Help Page Extensible from Wishlist to Low.
Aug 4 2024, 07:54 · Documentation, Remarkup
avivey added a comment to D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

This entire method looks very hacky to me. I guess at the bottom of every useful UI, there's a bunch of if statements that map icon names to code.

Aug 4 2024, 07:49
valerio.bozzolan added a comment to D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.

Thanks. Have you already tried with just CSS? Any issue in that? Maybe something like this:

Aug 4 2024, 06:44
aklapper requested review of D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.
Aug 4 2024, 00:19
aklapper added a revision to T15901: "Upload File" and "Meme" dialogs display behind fullscreen editor: D25764: Leave fullscreen editor when displaying "Upload File" and "Meme" dialogs.
Aug 4 2024, 00:19
aklapper created T15901: "Upload File" and "Meme" dialogs display behind fullscreen editor.
Aug 4 2024, 00:14

Aug 3 2024

aklapper closed T15898: Restrict maximum task title length as Resolved by committing rP62aaa0fcbef5: Restrict maximum task title length to 255 characters.
Aug 3 2024, 23:44 · Maniphest
aklapper closed D25759: Restrict maximum task title length to 255 characters.
Aug 3 2024, 23:43