Page MenuHomePhorge
Feed Advanced Search

Dec 5 2023

aklapper closed D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.
Dec 5 2023, 03:28
aklapper committed rARCe46025f7a914: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect….
Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect…
Dec 5 2023, 03:28
aklapper requested review of D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.
Dec 5 2023, 03:23
aklapper added a revision to T15685: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured: D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.
Dec 5 2023, 03:23 · PHP 8 support
aklapper created T15685: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.
Dec 5 2023, 03:21 · PHP 8 support
aklapper requested review of D25488: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured.
Dec 5 2023, 03:15
aklapper added a revision to T15684: PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured: D25488: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured.
Dec 5 2023, 03:15 · PHP 8 support
aklapper created T15684: PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured.
Dec 5 2023, 03:13 · PHP 8 support
aklapper retitled D25487: Fix PHP 8.1 exceptions rendering task when custom select field configured from Fix PHP 8.1 exceptions rendering task when custom text field configured
Dec 5 2023, 03:06
aklapper renamed T15683: PHP 8.1 "strlen(null)" exceptions rendering Maniphest task when custom select field configured from PHP 8.1 "strlen(null)" exceptions rendering Maniphest task when custom text field configured to PHP 8.1 "strlen(null)" exceptions rendering Maniphest task when custom select field configured.
Dec 5 2023, 03:05 · PHP 8 support
aklapper added a revision to T15683: PHP 8.1 "strlen(null)" exceptions rendering Maniphest task when custom select field configured: D25487: Fix PHP 8.1 exceptions rendering task when custom select field configured.
Dec 5 2023, 03:03 · PHP 8 support
aklapper requested review of D25487: Fix PHP 8.1 exceptions rendering task when custom select field configured.
Dec 5 2023, 03:03
aklapper created T15683: PHP 8.1 "strlen(null)" exceptions rendering Maniphest task when custom select field configured.
Dec 5 2023, 03:00 · PHP 8 support

Nov 29 2023

aklapper added a comment to D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.

As I just ran into this again spinning up another machine and had to look this up again, I'd really appreciate if a Blessed Committer could give an "Accepted" state. Thanks in advance!

Nov 29 2023, 22:53
aklapper added a comment to T15642: Feed Transaction Logs: Exception: Query overheated: examined more than 1,010 raw rows without finding 101 visible objects..

so something like this might work?

Nov 29 2023, 19:37
aklapper added a comment to D25479: Display default "Page Size" value in Maniphest Advanced Search form.

maybe use an PhabricatorSearchIntField with a default provided in the buildCustomSearchFields() ?

Nov 29 2023, 18:35
aklapper added a comment to D25482: Fix exception in Transaction Log after renaming Pholio Mock image: Call to undefined method PholioImageSequenceTransaction::renderHandleLink().
In D25482#13939, @speck wrote:

Was this the result of a recent change?

Nov 29 2023, 17:00
aklapper updated the summary of D25482: Fix exception in Transaction Log after renaming Pholio Mock image: Call to undefined method PholioImageSequenceTransaction::renderHandleLink().
Nov 29 2023, 14:57
aklapper added a comment to T15676: Empty "Page Size" field in Maniphest Advanced Search should display "100" by default.

What kind of operation are you doing that involves loading all tasks in a browser?

Nov 29 2023, 14:50
aklapper requested review of D25482: Fix exception in Transaction Log after renaming Pholio Mock image: Call to undefined method PholioImageSequenceTransaction::renderHandleLink().
Nov 29 2023, 14:45
aklapper added a revision to T15680: Transaction Log after renaming Pholio Mock image: Unhandled Exception: Call to undefined method PholioImageSequenceTransaction::renderHandleLink(): D25482: Fix exception in Transaction Log after renaming Pholio Mock image: Call to undefined method PholioImageSequenceTransaction::renderHandleLink().
Nov 29 2023, 14:45 · Bug Reports
aklapper created T15680: Transaction Log after renaming Pholio Mock image: Unhandled Exception: Call to undefined method PholioImageSequenceTransaction::renderHandleLink().
Nov 29 2023, 14:35 · Bug Reports
aklapper added a comment to T15676: Empty "Page Size" field in Maniphest Advanced Search should display "100" by default.

I'd really prefer not to do that. I pretty often need to work with complete search results (e.g. batch-editing), not with only the first 100 and then repeat all steps for the next 100.

Nov 29 2023, 14:14
aklapper created T15679: Pholio image upload triggers Passing null is deprecated at PhabricatorPolicyQuery.php:314.
Nov 29 2023, 13:52 · PHP 8 support

Nov 28 2023

aklapper closed T15678: PHP 8.1 "strlen(null)" exception after removing custom alt text from image file, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Nov 28 2023, 13:52 · PHP 8 support
aklapper closed T15678: PHP 8.1 "strlen(null)" exception after removing custom alt text from image file as Resolved by committing rPc3850a3c1530: Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file.
Nov 28 2023, 13:52 · PHP 8 support
aklapper closed D25481: Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file.
Nov 28 2023, 13:52
aklapper committed rPc3850a3c1530: Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file.
Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file
Nov 28 2023, 13:52
aklapper requested review of D25481: Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file.
Nov 28 2023, 12:47
aklapper added a revision to T15678: PHP 8.1 "strlen(null)" exception after removing custom alt text from image file: D25481: Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file.
Nov 28 2023, 12:47 · PHP 8 support
aklapper created T15678: PHP 8.1 "strlen(null)" exception after removing custom alt text from image file.
Nov 28 2023, 12:46 · PHP 8 support

Nov 27 2023

aklapper added a comment to D25479: Display default "Page Size" value in Maniphest Advanced Search form.

Is this the only place where we have a "Page size" exposed in the search?

Nov 27 2023, 19:36
aklapper added a comment to D25479: Display default "Page Size" value in Maniphest Advanced Search form.

Hmm I guess the Test Plan should also cover testing with Conduit. Not sure this may shake something up.

Nov 27 2023, 16:37
aklapper added a comment to D25479: Display default "Page Size" value in Maniphest Advanced Search form.

Another option would be to extend the class PhabricatorSearchTextField and make the new class PhabricatorSearchPageSizeField only overwrite function getDefaultValue(), however class PhabricatorSearchTextField is marked as final and I am reluctant to change that.

Nov 27 2023, 15:49
aklapper requested review of D25479: Display default "Page Size" value in Maniphest Advanced Search form.
Nov 27 2023, 15:45
aklapper added a revision to T15676: Empty "Page Size" field in Maniphest Advanced Search should display "100" by default: D25479: Display default "Page Size" value in Maniphest Advanced Search form.
Nov 27 2023, 15:45
aklapper created T15676: Empty "Page Size" field in Maniphest Advanced Search should display "100" by default.
Nov 27 2023, 15:35

Nov 25 2023

aklapper added a comment to D25477: Visually indicate new user accounts.

This code change adds a small star to handles of new user accounts:

Screenshot from 2023-11-25 12-52-14-phorge-new-user.png (385×1 px, 70 KB)

Nov 25 2023, 12:32
aklapper updated the diff for D25477: Visually indicate new user accounts.

Fix variable names

Nov 25 2023, 12:31
aklapper requested review of D25477: Visually indicate new user accounts.
Nov 25 2023, 12:29
aklapper added a revision to T15675: Visually indicate new user accounts: D25477: Visually indicate new user accounts.
Nov 25 2023, 12:29 · Feature Requests
aklapper created T15675: Visually indicate new user accounts.
Nov 25 2023, 12:22 · Feature Requests

Nov 24 2023

aklapper updated the test plan for D25476: Avoid "Action with no effect" for auto-claim statuses after manually removing assignee.
Nov 24 2023, 21:43
aklapper requested review of D25476: Avoid "Action with no effect" for auto-claim statuses after manually removing assignee.
Nov 24 2023, 21:42
aklapper added a revision to T15164: Resolving without Claiming causes error "Action with no effect": D25476: Avoid "Action with no effect" for auto-claim statuses after manually removing assignee.
Nov 24 2023, 21:42 · Maniphest, User-valerio.bozzolan
aklapper added a comment to T15164: Resolving without Claiming causes error "Action with no effect".

Obviously, any fixes should be in ManiphestTransactionEditor and not spill into generic parent PhabricatorApplicationTransactionEditor.

Nov 24 2023, 21:24 · Maniphest, User-valerio.bozzolan
aklapper added a comment to T15164: Resolving without Claiming causes error "Action with no effect".

Historical references: rP69eab4196de462e42b07b60e2b52071631f4a3c8 and rP4041a7e0f66406dbaa31faa3807d50833b7c7efd (which didn't help much).

Nov 24 2023, 21:24 · Maniphest, User-valerio.bozzolan
aklapper updated the task description for T15164: Resolving without Claiming causes error "Action with no effect".
Nov 24 2023, 21:06 · Maniphest, User-valerio.bozzolan

Nov 20 2023

aklapper added a comment to T15055: Import translations from translatewiki.net.

Probably this was moved?

Nov 20 2023, 12:44 · Localization, Affects-Wikimedia, Phorge

Nov 18 2023

aklapper added a comment to D25474: Disallow webcrawlers to index Diffusion commits.

If someone strongly feels that I should revert, please say so - thanks! :)

Nov 18 2023, 08:31
aklapper added a comment to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.

Valerio: Uhm, I'm sorry, I had not seen your comment here before I landed the patch (as I had checked my Differential page instead of my notifications).

Nov 18 2023, 08:29 · Diffusion, Discussion Needed

Nov 17 2023

aklapper closed T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers as Resolved by committing rP05f4d5071fdc: Disallow webcrawlers to index Diffusion commits.
Nov 17 2023, 07:45 · Diffusion, Discussion Needed
aklapper closed D25474: Disallow webcrawlers to index Diffusion commits.
Nov 17 2023, 07:45
aklapper committed rP05f4d5071fdc: Disallow webcrawlers to index Diffusion commits.
Disallow webcrawlers to index Diffusion commits
Nov 17 2023, 07:45

Nov 16 2023

aklapper updated the diff for D25418: Catch RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73.

Thanks for the additional debugging and finding steps to reproduce! In this case, I'd prefer not to log the issue and to only show a message to the user explaining what's the issue, including their requested bogus encoding.

Nov 16 2023, 11:01
aklapper added a comment to T15624: RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73.

Heh, very good catch! I can confirm, yes.

Nov 16 2023, 11:00
aklapper updated the test plan for D25418: Catch RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73.
Nov 16 2023, 10:48
valerio.bozzolan awarded D25474: Disallow webcrawlers to index Diffusion commits a Evil Spooky Haunted Tree token.
Nov 16 2023, 10:24
aklapper retitled D25474: Disallow webcrawlers to index Diffusion commits from Disallow webcrawlers to follow Paste line number anchor links
Nov 16 2023, 10:12
aklapper requested review of D25474: Disallow webcrawlers to index Diffusion commits.
Nov 16 2023, 10:11
aklapper added a revision to T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers: D25474: Disallow webcrawlers to index Diffusion commits.
Nov 16 2023, 10:11 · Diffusion, Discussion Needed
aklapper closed T15662: Disallow webcrawlers to follow Paste line number anchor links as Resolved by committing rP76ed0c7ff7be: Disallow webcrawlers to follow Paste line number anchor links.
Nov 16 2023, 10:00
aklapper closed D25461: Disallow webcrawlers to follow Paste line number anchor links.
Nov 16 2023, 10:00
aklapper committed rP76ed0c7ff7be: Disallow webcrawlers to follow Paste line number anchor links.
Disallow webcrawlers to follow Paste line number anchor links
Nov 16 2023, 10:00
aklapper created T15670: Diffusion repository commits: avoid to be a black hole for webcrawlers.
Nov 16 2023, 09:55 · Diffusion, Discussion Needed
aklapper closed T15646: Renaming several Pholio Mockup images creates neverending daemon task (PhutilProxyException due to Array to string conversion) as Resolved by committing rPf42dd5819e98: Fix possible array to string conversion renaming Pholio Mockup image.
Nov 16 2023, 09:42 · Affects-Wikimedia, Bug Reports
aklapper closed D25441: Fix possible array to string conversion renaming Pholio Mockup image.
Nov 16 2023, 09:42
aklapper committed rPf42dd5819e98: Fix possible array to string conversion renaming Pholio Mockup image.
Fix possible array to string conversion renaming Pholio Mockup image
Nov 16 2023, 09:42
aklapper added a comment to D25441: Fix possible array to string conversion renaming Pholio Mockup image.

Thanks for the deeper investigation! I can confirm that with the last version and following my original steps to reproduce, no stuck daemon task about the mock looping due to an exception on http://phorge.localhost/daemon/ anymore, so I'm going to land this.

Nov 16 2023, 09:40

Nov 14 2023

aklapper added a comment to T15547: Alternative hashtag of milestone has no primary slug, thus project URL redirects to 404 /tag//.

This might be a duplicate of T15636

Nov 14 2023, 11:20
aklapper updated the diff for D25418: Catch RuntimeException: mb_convert_encoding(): Illegal character encoding specified at PhabricatorTextDocumentEngine.php:73.

Good points. This patch puts also the exception message into phlog.

Nov 14 2023, 10:34

Nov 13 2023

aklapper closed D25452: Do not expose Contact Numbers settings panel when no SMS support configured.
Nov 13 2023, 13:04
aklapper closed T15486: Do not expose "Contact Numbers" in user settings when no SMS support is set up in Phorge as Resolved by committing rP282e37aaf682: Do not expose Contact Numbers settings panel when no SMS support configured.
Nov 13 2023, 13:04 · Policy
aklapper committed rP282e37aaf682: Do not expose Contact Numbers settings panel when no SMS support configured.
Do not expose Contact Numbers settings panel when no SMS support configured
Nov 13 2023, 13:04

Nov 12 2023

aklapper closed T15622: PHP 8.1 "strlen(null)" exception rendering PHUISegmentBar without a label as Resolved by committing rP5d80b3fd88d1: Fix PHP 8.1 "strlen(null)" exception rendering PHUISegmentBar without a label.
Nov 12 2023, 07:54 · PHP 8 support
aklapper closed T15622: PHP 8.1 "strlen(null)" exception rendering PHUISegmentBar without a label, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Nov 12 2023, 07:54 · PHP 8 support
aklapper closed D25414: Fix PHP 8.1 "strlen(null)" exception rendering PHUISegmentBar without a label.
Nov 12 2023, 07:54
aklapper committed rP5d80b3fd88d1: Fix PHP 8.1 "strlen(null)" exception rendering PHUISegmentBar without a label.
Fix PHP 8.1 "strlen(null)" exception rendering PHUISegmentBar without a label
Nov 12 2023, 07:54

Nov 11 2023

aklapper updated the diff for D25414: Fix PHP 8.1 "strlen(null)" exception rendering PHUISegmentBar without a label.

Update per last comment

Nov 11 2023, 15:23
aklapper added a comment to D25441: Fix possible array to string conversion renaming Pholio Mockup image.

Maybe I have to test this against PHP 8.1

Nov 11 2023, 12:48
aklapper closed D25450: Add Diffusion policy capability "Can Edit and View Identities".
Nov 11 2023, 12:27
aklapper closed T15443: Add Diffusion policy capability "Can Edit and View Identities" as Resolved by committing rP90f651d669e4: Add Diffusion policy capability "Can Edit and View Identities".
Nov 11 2023, 12:27 · Diffusion, Policy
aklapper committed rP90f651d669e4: Add Diffusion policy capability "Can Edit and View Identities".
Add Diffusion policy capability "Can Edit and View Identities"
Nov 11 2023, 12:27

Nov 10 2023

aklapper requested review of D25461: Disallow webcrawlers to follow Paste line number anchor links.
Nov 10 2023, 11:57
aklapper added a revision to T15662: Disallow webcrawlers to follow Paste line number anchor links: D25461: Disallow webcrawlers to follow Paste line number anchor links.
Nov 10 2023, 11:57
aklapper created T15662: Disallow webcrawlers to follow Paste line number anchor links.
Nov 10 2023, 11:51
aklapper closed T15661: Make "git cat-file" exception messages include repository monogram/slug as Resolved by committing rP87e9c936ad1c: Make "git cat-file" exception messages include repository monogram/slug.
Nov 10 2023, 10:40
aklapper closed D25460: Make "git cat-file" exception messages include repository monogram/slug.
Nov 10 2023, 10:40
aklapper committed rP87e9c936ad1c: Make "git cat-file" exception messages include repository monogram/slug.
Make "git cat-file" exception messages include repository monogram/slug
Nov 10 2023, 10:40

Nov 9 2023

aklapper closed T15652: Unhandled Exception: Call to undefined method PhabricatorTokenGivenQuery::withIDs() as Resolved by committing rPdfa15726ea5a: Fix cursor paging issue in Given Token query call.
Nov 9 2023, 20:01 · Bug Reports
aklapper closed D25455: Fix cursor paging issue in Given Token query call.
Nov 9 2023, 20:01
aklapper committed rPdfa15726ea5a: Fix cursor paging issue in Given Token query call.
Fix cursor paging issue in Given Token query call
Nov 9 2023, 20:01
aklapper added a comment to D25460: Make "git cat-file" exception messages include repository monogram/slug.

If this is considered too dangerous to merge, I could first test this in downstream for a while.

Nov 9 2023, 19:25
aklapper requested review of D25460: Make "git cat-file" exception messages include repository monogram/slug.
Nov 9 2023, 19:24
aklapper added a revision to T15661: Make "git cat-file" exception messages include repository monogram/slug: D25460: Make "git cat-file" exception messages include repository monogram/slug.
Nov 9 2023, 19:24
aklapper created T15661: Make "git cat-file" exception messages include repository monogram/slug.
Nov 9 2023, 19:14

Nov 8 2023

aklapper awarded D25458: Adjust message in timezone conflict form a Love token.
Nov 8 2023, 08:00

Nov 7 2023

aklapper added a comment to T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID'.

Initially, the task is in the project's default column:

MariaDB [phabricator_project]> SELECT cp.id, p.name AS projectName, cp.boardPHID, c.name AS columnName, cp.columnPHID FROM project_columnposition cp INNER JOIN project_column c ON cp.columnPHID = c.phid INNER JOIN phabricator_project.project p ON cp.boardPHID = p.phid WHERE objectPHID ="PHID-TASK-f6ri2kdpcvtb3yncho2n";
+-----+----------------+--------------------------------+------------+--------------------------------+
| id  | projectName    | boardPHID                      | columnName | columnPHID                     |
+-----+----------------+--------------------------------+------------+--------------------------------+
| 509 | T139396-parent | PHID-PROJ-yt43plz2cxlidyu4dlia | Backloggg  | PHID-PCOL-no7jbin6vngwkrghrmrk |
+-----+----------------+--------------------------------+------------+--------------------------------+
Nov 7 2023, 23:00 · Affects-Wikimedia, Bug Reports

Nov 6 2023

valerio.bozzolan awarded T15443: Add Diffusion policy capability "Can Edit and View Identities" a Like token.
Nov 6 2023, 05:57 · Diffusion, Policy

Nov 5 2023

aklapper added a comment to D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.

Would anyone be willing to give this another review? TIA

Nov 5 2023, 14:42