Make PhabricatorDifferentialRevisionTestDataGenerator::generateDescription() have more than one sentence
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mon, May 19
Mon, May 19
Sun, May 18
Sun, May 18
git rebase master
aklapper updated the diff for D26023: Ignore bogus cards parameter string values in Hovercards calls.
Sigh, I swear I grep'ed for isArray before but I was in a parallel CamelCase world in that moment
aklapper requested review of D26023: Ignore bogus cards parameter string values in Hovercards calls.
aklapper renamed T16075: TypeError: idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php from TypeError) idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php to TypeError: idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php.
Sat, May 17
Sat, May 17
remove some unneeded brackets in regex
Right...hmm, now I also wonder. :)
Should probably be iPhone|iPod|Android.*(Chrome/[.0-9]* Mobile|Mobile.*Firefox/[.0-9]*) (it's still that Firefox on Android has that Android string first, thus the brackets).
or with slash and version:
We shall keep version. There"s a good number of user-agent strings out there concatenating random browser names while not being these browsers.
aklapper closed T15689: built in exception display is missing top line as Resolved by committing rPb7ff9ba6f8ab: Unhandled Exception: Add last call to error message.
git rebase master
git rebase master
Fri, May 16
Fri, May 16
wrap long string to make lint happy
but in Firefox seems easier, we can just match "Mobile.*Firefox" probably
Per https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/User-Agent/Firefox (and other pages like https://www.whatismybrowser.com/guides/the-latest-user-agent/firefox ), the current regex check in Phorge requiring the string Chrome won't even try to match Firefox browsers on mobile (e.g. Mozilla/5.0 (Android 15; Mobile; rv:138.0) Gecko/138.0 Firefox/138.0).
Reverting rARC29575b4f91876bf0a95739eba50f792e2aa78c0c and rP6619fef2ff977ea81092b970e58abbb33e78f644 makes Phorge throw errors again:
Firefox says This page is in Quirks Mode. Page layout may be impacted.,
Chromium says net::ERR_CONTENT_DECODING_FAILED 200 (OK)),
both because the deprecation warning is added before the usual HTML header created by AphrontPageView, as curl shows:
[acko@foo phorge (master *$|u=)]$ curl 'http://phorge.localhost' <br /> <b>Deprecated</b>: Constant E_STRICT is deprecated in <b>/var/www/html/phorge/phorge/support/startup/PhabricatorStartup.php</b> on line <b>391</b><br /> <!DOCTYPE html><html data-developer-mode="1"><head><meta charset="UTF-8" /><title>Home</title><meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=yes" /><link rel="mask-icon" color="#3D4B67" [...]
We don't end up calling PhutilErrorHandler::handleError() or PhutilErrorLog::onError() or PhutilSystem::writeStderr() here.
aklapper updated the task description for T16071: Avoid large layout shifts while page loading on mobile.
seems manually uploaded by an user, but it's not
Thu, May 15
Thu, May 15
Wed, May 14
Wed, May 14
git rebase master
git rebase master
Tue, May 13
Tue, May 13
That was my patch initially but it felt like too much duplicated code... I don't have a strong opinion though; I'm also fine with that other approach. :)
What's the expectation for classes which have a child class extending them? Marking them as abstract though they are really not abstract at all? protected class? Uhm.
Mon, May 12
Mon, May 12
aklapper requested review of D26019: Add two trivial PHPDocs lines to PhabricatorTypeaheadDatasource.
Sun, May 11
Sun, May 11
Sat, May 10
Sat, May 10
Fri, May 9
Fri, May 9
@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.
another round of bin/celerity map
I guess this welcomes another review / testing. Works fine here.™
Also update comment
aklapper closed T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4) as Resolved by committing rP6619fef2ff97: Remove use of deprecated E_STRICT PHP constant.
In D25887#26923, @valerio.bozzolan wrote:Just for my curiosity, can you please also follow the tip from the screenshot (before the patch), so, using --trace?
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0