Page MenuHomePhorge
Feed Advanced Search

Wed, May 14

aklapper closed D26015: Remove orphan CSS selectors in phui/phui-lightbox.css.
Wed, May 14, 22:12
aklapper committed rP06cf73177919: Remove orphan CSS selectors in phui/phui-lightbox.css.
Wed, May 14, 22:12

Tue, May 13

aklapper added a comment to D26020: Add workboard column trigger to assign only unassigned tasks.

That was my patch initially but it felt like too much duplicated code... I don't have a strong opinion though; I'm also fine with that other approach. :)

Tue, May 13, 13:33
aklapper added a comment to D26020: Add workboard column trigger to assign only unassigned tasks.

What's the expectation for classes which have a child class extending them? Marking them as abstract though they are really not abstract at all? protected class? Uhm.

Tue, May 13, 11:42
aklapper requested review of D26020: Add workboard column trigger to assign only unassigned tasks.
Tue, May 13, 11:39
aklapper added a revision to T16064: New Column Trigger: Assign only unassigned tasks on move: D26020: Add workboard column trigger to assign only unassigned tasks.
Tue, May 13, 11:39 · Feature Requests
aklapper closed D26019: Add two trivial PHPDocs lines to PhabricatorTypeaheadDatasource.
Tue, May 13, 07:18
aklapper committed rP94a9724637ae: Add two trivial PHPDocs lines to PhabricatorTypeaheadDatasource.
Tue, May 13, 07:18

Mon, May 12

aklapper requested review of D26019: Add two trivial PHPDocs lines to PhabricatorTypeaheadDatasource.
Mon, May 12, 18:41
aklapper added a project to T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)": Bug Reports.
Mon, May 12, 18:35 · Bug Reports
aklapper created T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)".
Mon, May 12, 18:35 · Bug Reports

Sun, May 11

aklapper closed T15859: Set "preconnect" HTTP header when "security.alternate-file-domain" is set as Resolved by committing rP1f19cbf7486a: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
Sun, May 11, 07:27 · Wikimedia Hackathon 2025, Feature Requests
aklapper closed D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
Sun, May 11, 07:27
aklapper committed rP1f19cbf7486a: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
Sun, May 11, 07:27

Sat, May 10

aklapper requested review of D26018: Remove pre-2014 webfont formats (EOT, SVG, TTF).
Sat, May 10, 17:52
aklapper requested review of D26017: Remove orphan CSS selectors in diffusion/diffusion-*.css.
Sat, May 10, 12:15
aklapper requested review of D26016: Remove orphan CSS selectors in core/remarkup.css.
Sat, May 10, 12:12
aklapper requested review of D26015: Remove orphan CSS selectors in phui/phui-lightbox.css.
Sat, May 10, 11:51
aklapper updated the summary of D26011: Remove orphan CSS selectors in phui/phui-form-view.css.
Sat, May 10, 11:48
aklapper updated the summary of D26013: Remove orphan CSS selectors in phui/phui-crumbs-view.css.
Sat, May 10, 11:48
aklapper requested review of D26014: Remove orphan CSS selectors in phui/phui-document*.css.
Sat, May 10, 11:48
aklapper requested review of D26013: Remove orphan CSS selectors in phui/phui-crumbs-view.css.
Sat, May 10, 11:45
aklapper requested review of D26012: Remove orphan CSS selectors in phui/phui-remarkup-preview.css.
Sat, May 10, 11:40
aklapper requested review of D26011: Remove orphan CSS selectors in phui/phui-form-view.css.
Sat, May 10, 11:35
aklapper requested review of D26010: Remove orphan CSS selectors in core/z-index.css.
Sat, May 10, 11:25
aklapper created T16067: Uploaded image files after transformations become/remain public.
Sat, May 10, 10:38

Fri, May 9

aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.

Fri, May 9, 13:10
aklapper requested review of D26009: Remove orphan CSS selectors in phui/phui-action-panel.css.
Fri, May 9, 13:02
aklapper requested review of D26008: Remove orphan CSS selectors in phui/phui-header-view.css.
Fri, May 9, 12:57
aklapper updated the summary of D26007: Remove unused CSS file aphront/panel-view.css.
Fri, May 9, 12:57
aklapper requested review of D26007: Remove unused CSS file aphront/panel-view.css.
Fri, May 9, 12:40
aklapper requested review of D26006: Remove unused FatCow icon files.
Fri, May 9, 11:17
aklapper updated the diff for D26005: Remove unused keyboard shortcuts code.

another round of bin/celerity map

Fri, May 9, 11:01
aklapper requested review of D26005: Remove unused keyboard shortcuts code.
Fri, May 9, 10:57
aklapper created T16065: PHP Deprecation warnings in STDERR can make arc fail.
Fri, May 9, 10:17
aklapper added a comment to D25955: Unhandled Exception: Add last call to error message.

I guess this welcomes another review / testing. Works fine here.™

Fri, May 9, 09:40
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Also update comment

Fri, May 9, 09:35
aklapper edited the content of Next Up.
Fri, May 9, 09:27
aklapper edited the content of Next Up.
Fri, May 9, 09:26
aklapper closed D25886: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 09:24
aklapper committed rARC29575b4f9187: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 09:24
aklapper closed T15989: `arc` commands: Constant E_STRICT is deprecated (with PHP 8.4) as Resolved by committing rP6619fef2ff97: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 09:23 · Deprecation Notice, PHP 8 support, Bug Reports
aklapper closed D25887: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 09:23
aklapper committed rP6619fef2ff97: Remove use of deprecated E_STRICT PHP constant.
Fri, May 9, 09:23
aklapper added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

Just for my curiosity, can you please also follow the tip from the screenshot (before the patch), so, using --trace?

Fri, May 9, 09:21
aklapper added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

I'd still not expect it to actually break anything - the docs say this const is "deprecated" not "removed", so I'd expect a warning and everything to keep working.

Fri, May 9, 08:04
aklapper added a comment to D25886: Remove use of deprecated E_STRICT PHP constant.

Since using E_STRICT is deprecated, I thought the simple fact of using it from whatever Arcanist CLI

Fri, May 9, 08:00
aklapper added a comment to D25955: Unhandled Exception: Add last call to error message.

Garrr this still needs shortening the two comment lines

Fri, May 9, 07:26
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Use PhutilErrorHandler::adjustFilePath instead of manually manipulating the filepath string

Fri, May 9, 07:24
aklapper added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

After upgrading to PHP 8.4 this issue blocks me now from doing development work as arc diff fails:

Screenshot From 2025-05-09 09-15-08.png (710×1 px, 136 KB)

And Phorge fails to render at all in both Firefox and Chromium (Phorge renders after applying this very patch):
Screenshot From 2025-05-09 09-00-07.png (973×1 px, 112 KB)

Fri, May 9, 07:18
aklapper closed D26004: README: Update URI of FatCow icon set.
Fri, May 9, 03:46
aklapper committed rP8d688f59d123: README: Update URI of FatCow icon set.
Fri, May 9, 03:46

Thu, May 8

aklapper requested review of D26004: README: Update URI of FatCow icon set.
Thu, May 8, 17:50
aklapper closed D25999: Remove orphan CSS selectors in ponder/ponder-view.css.
Thu, May 8, 16:37
aklapper committed rP07e40af06a7a: Remove orphan CSS selectors in ponder/ponder-view.css.
Thu, May 8, 16:37
aklapper edited the content of Next Up.
Thu, May 8, 16:37
aklapper closed D26002: Remove orphan CSS selectors in config/config-options.css.
Thu, May 8, 16:35
aklapper committed rPa5868f388f16: Remove orphan CSS selectors in config/config-options.css.
Thu, May 8, 16:35
aklapper edited the content of Next Up.
Thu, May 8, 14:53
aklapper closed D26003: Remove orphan CSS selectors in slowvote/slowvote.css.
Thu, May 8, 14:53
aklapper committed rP67880e5c4406: Remove orphan CSS selectors in slowvote/slowvote.css.
Thu, May 8, 14:53
aklapper edited the content of Next Up.
Thu, May 8, 14:47
aklapper closed D26001: Remove orphan CSS selectors in maniphest/task-summary.css.
Thu, May 8, 14:46
aklapper committed rP6c4ccf1dc93b: Remove orphan CSS selectors in maniphest/task-summary.css.
Thu, May 8, 14:46
aklapper created T16064: New Column Trigger: Assign only unassigned tasks on move.
Thu, May 8, 14:42 · Feature Requests
aklapper requested review of D26003: Remove orphan CSS selectors in slowvote/slowvote.css.
Thu, May 8, 14:19
aklapper requested review of D26002: Remove orphan CSS selectors in config/config-options.css.
Thu, May 8, 14:17
aklapper requested review of D26001: Remove orphan CSS selectors in maniphest/task-summary.css.
Thu, May 8, 14:15
aklapper updated the summary of D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.
Thu, May 8, 13:50
aklapper requested review of D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.
Thu, May 8, 13:49
aklapper requested review of D25999: Remove orphan CSS selectors in ponder/ponder-view.css.
Thu, May 8, 13:18
aklapper requested review of D25998: Remove orphan CSS selectors in base/main-menu-view.css.
Thu, May 8, 13:06
aklapper edited the content of Next Up.
Thu, May 8, 12:22
aklapper closed D25985: Remove unused feed/feed.css and maniphest/task-edit.css.
Thu, May 8, 12:21
aklapper committed rP5f7250fea617: Remove unused feed/feed.css and maniphest/task-edit.css.
Thu, May 8, 12:21
aklapper retitled D25985: Remove unused feed/feed.css and maniphest/task-edit.css from Remove unused CSS files feed/feed.css and maniphest/task-edit.css
Thu, May 8, 12:21
aklapper updated the diff for D25985: Remove unused feed/feed.css and maniphest/task-edit.css.

git rebase master

Thu, May 8, 11:24

Wed, May 7

aklapper requested review of D25997: Remove orphan CSS selectors for differential-haunt-mode.
Wed, May 7, 23:25
aklapper requested review of D25996: Remove unused CSS file differential/revision-list.css.
Wed, May 7, 23:13
aklapper retitled D25985: Remove unused feed/feed.css and maniphest/task-edit.css from Remove some unused CSS files to Remove unused CSS files feed/feed.css and maniphest/task-edit.css.
Wed, May 7, 23:10
aklapper requested review of D25995: Remove orphan CSS selectors in PHUIFormView.
Wed, May 7, 17:00
aklapper edited the content of Next Up.
Wed, May 7, 16:24
aklapper closed T16062: PHP 8.1 "strlen(null)" exceptions searching in Conpherence as Resolved by committing rP66bad4e5eebe: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 16:24 · PHP 8 support
aklapper closed T16062: PHP 8.1 "strlen(null)" exceptions searching in Conpherence, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Wed, May 7, 16:24 · PHP 8 support
aklapper closed D25994: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 16:24
aklapper committed rP66bad4e5eebe: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 16:24
aklapper added a revision to T16062: PHP 8.1 "strlen(null)" exceptions searching in Conpherence: D25994: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 13:29 · PHP 8 support
aklapper requested review of D25994: Fix PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 13:29
aklapper created T16062: PHP 8.1 "strlen(null)" exceptions searching in Conpherence.
Wed, May 7, 13:22 · PHP 8 support
aklapper added a comment to D25992: Remove unused anchor-target CSS for Conpherence message pane.

Makes sense. The only mention of anchor-target I can (and could at the time of introducing that CSS) can find is in webroot/rsrc/js/core/behavior-watch-anchor.js but still clueless how to ever trigger that in conpherence - it's related to an anchor link like Z2#26 but that doesn't have the parent classes of the CSS selector.

Wed, May 7, 12:38
aklapper updated the diff for D25991: Column triggers: Allow assigning user who performs the move.

Do not concatenate strings (patchwork messages; lego messages) in getRuleViewDescription() so translations can be correct

Wed, May 7, 11:01
aklapper updated the diff for D25878: Project archival dialog: Mention affected Herald rule conditions.

Use getProductionURI(), not getEnvConfig()

Wed, May 7, 10:51
aklapper added inline comments to D25878: Project archival dialog: Mention affected Herald rule conditions.
Wed, May 7, 10:49
aklapper retitled D25823: arc browse: add support for Subversion repos from arc browse: add support to Subversion repos
Wed, May 7, 09:38 · Arcanist
aklapper accepted D25823: arc browse: add support for Subversion repos.

Reading (and testing) this again/more, after our first round in person a few days ago, now that I have a local SVN repo, I cannot find anything wrong or non-working, still I'd ideally appreciate another pair of eyes.
Added two more small comments.

Wed, May 7, 09:38 · Arcanist
aklapper added a comment to D25987: Add CSS class to object handle if user object is system agent.

Note that in the screenshots I used an extremely broad CSS selector as that broad one was specifically mentioned in the previous comment here.

Wed, May 7, 08:58
aklapper added inline comments to D25991: Column triggers: Allow assigning user who performs the move.
Wed, May 7, 08:23
aklapper closed D25993: Remove orphan CSS selectors in UIExample.
Wed, May 7, 08:16
aklapper committed rPa3cad3a3623e: Remove orphan CSS selectors in UIExample.
Wed, May 7, 08:16

Tue, May 6

aklapper updated the diff for D25889: Add "Authored Tasks" view / item to user profile menu.

Keep route / path in both places as tasks-assigned/ for consistency

Tue, May 6, 21:39