That was my patch initially but it felt like too much duplicated code... I don't have a strong opinion though; I'm also fine with that other approach. :)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Wed, May 14
Tue, May 13
What's the expectation for classes which have a child class extending them? Marking them as abstract though they are really not abstract at all? protected class? Uhm.
Mon, May 12
Sun, May 11
Sat, May 10
Fri, May 9
@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.
another round of bin/celerity map
I guess this welcomes another review / testing. Works fine here.™
Also update comment
In D25887#26923, @valerio.bozzolan wrote:Just for my curiosity, can you please also follow the tip from the screenshot (before the patch), so, using --trace?
In D25887#26917, @avivey wrote:I'd still not expect it to actually break anything - the docs say this const is "deprecated" not "removed", so I'd expect a warning and everything to keep working.
In D25886#24266, @valerio.bozzolan wrote:Since using E_STRICT is deprecated, I thought the simple fact of using it from whatever Arcanist CLI
Garrr this still needs shortening the two comment lines
Use PhutilErrorHandler::adjustFilePath instead of manually manipulating the filepath string
After upgrading to PHP 8.4 this issue blocks me now from doing development work as arc diff fails:
And Phorge fails to render at all in both Firefox and Chromium (Phorge renders after applying this very patch):
Thu, May 8
git rebase master
Wed, May 7
Makes sense. The only mention of anchor-target I can (and could at the time of introducing that CSS) can find is in webroot/rsrc/js/core/behavior-watch-anchor.js but still clueless how to ever trigger that in conpherence - it's related to an anchor link like Z2#26 but that doesn't have the parent classes of the CSS selector.
Do not concatenate strings (patchwork messages; lego messages) in getRuleViewDescription() so translations can be correct
Use getProductionURI(), not getEnvConfig()
Reading (and testing) this again/more, after our first round in person a few days ago, now that I have a local SVN repo, I cannot find anything wrong or non-working, still I'd ideally appreciate another pair of eyes.
Added two more small comments.
Note that in the screenshots I used an extremely broad CSS selector as that broad one was specifically mentioned in the previous comment here.
Tue, May 6
Keep route / path in both places as tasks-assigned/ for consistency