I wonder if we should just extend PhabricatorProjectTriggerRule. So, leaving PhabricatorProjectTriggerManiphestOwnerRule as-is 🤔 any opinion about that?

Better now, thanks again @avivey

Tested right now. Unexpected pleasure! thanks! :3 :3

Uhm this is a damn rabbit hole.

Maybe also we can drop something from ./webroot/rsrc/css/core/remarkup.css - since it seems to contain .aphront-panel-preview ( .aphront-panel-preview .phabricator-remarkup-mention-unknown)

Thanks. I pinpoint also here your super-relevant extra details: https://we.phorge.it/D25887#26924

Trying the ManiphestTransactionEditor leads to a dead end. Added personal notes about it...

Just for my curiosity, can you please also follow the tip from the screenshot (before the patch), so, using --trace?

Uh I've found a workaround.

This looks very useful. I think somewhere there is a thing that truncates this kind of pathnames to say <phorge>/path/to. I would like to invest some time to reuse that, so, no need of substr(strlen(substr(realpath

Nice name btw

Thaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaanks

Thaaaaaaaaaaaaanks. It works also on my computer woooo

Closed all inline comments.

• adopt suggested indentation in ArcanistRepositoryRef.php:91-94
• adopt explicit "TODO" in ArcanistRepositoryRef.php:138-139

A related task (maybe not a sub-task?) is probably that the advanced search of herald ( https://we.phorge.it/herald/ ) does not allow to find these by involved project(s).

In D25987#26708, @aklapper wrote:

Note that in the screenshots I used an extremely broad CSS selector as that broad one was specifically mentioned

This also

ArcanistRepositoryAPI: apply suggested inline comment:

@matmarex: please look at the screenshots of Andre above: can I ask if such new selector would really simplify your downstream job? or, is there anything else missing / that we should do instead?

I have not a strong opinion about author usernames (T16052) but if you say to decline that makes sense, especially if at least as small compromise we simplify bot recognition, T16051 and D25987, so that local installs can rewrite their UX without completely nuking their past history and doing complicated comment→transaction migrations on past data.

The CSS rule has never been applied. After the change it will be. Please help by adding a line in the test plan about how to reproduce it if you have some time 🙏

Thaaanks

implement avivey's feedbacks

Ready for review :3 based on the other one.

add a potential performance TODO in legacy code: T16061: PhabricatorEnv isSelfURI(): add small cache of these self-URIs

Avoid $array[$key]=1 and use $array[$key]=$key as suggested

I suggest testing by setting window width = 1791px (e.g. CTRL+shift+M on Firefox), and then passing to window width = 1792px. So we can see that the content max width at the moment always seems ~ 800px.

Uhm - but looking at your screenshot, at looking here T15920, it seems a regression

Patch welcome, with "Ref T15920"

Uhm. I don't know why but locally I cannot find the selector. Also this should help in getting the selector but without success, both from the home, or from a task created and assigned to a bot.

Nice. Just for fun I've played intensively with https://developer.mozilla.org/en-US/docs/Web/CSS/font-smooth without being able to notice whatsoever difference, so, green light I assume. Thanks

drop newline

add some inline documentation about $array[$v] = 1

Generated with

Feel free to throw the patch as-is, as I usual I love to cleanup and test more loool

Generate a super-useful documentation table in Remarkup