Also remove now unused private $objectPHID

Remove a needless ->setObjectPHID($object_phid) call I missed now that we pass $object

I still don't like the solution of using place-holder text for that

Thanks for the review (and for your patience!).

This is the same as Q132: Why is there an `outline-style: none;` declaration for all links within Phorge/Phabricator?

Cleaner attempt in D25546 Diff 2113.

Allow to setEditEngine when constructing a PhabricatorApplicationTransactionCommentView

Thanks for the pointers, I really appreciate them.

Ah, thanks, makes sense now. I'd probably rephrase "but harms the authors constraint" a little bit to explicitly cover what you explained well in D25676#18549 - an author PHID in $this->responsibles might not always be a member of a project or owner of a package, so the query results were incomplete beforehand.

Hi bekay, thanks for looking into this, very appreciated!

There is no reason to expose "Manage" for admins only. I'm abandoning this in favor of D25687.

Could you clarify if this is only supposed to work for import an .ics URI and not for importing a single event via an .ics file? Maybe I'm overcomplicating things, what I tried:

I admit I am quite interested in the changes in src/applications/people/query/PhabricatorPeopleUserEmailQuery.php adding $userPhids and $isVerified as I have a downstream use case for them.
Would be lovely to get them in, nevertheless where the actual calendar feature request is going.

Use PhabricatorMarkupEngine::summarizeSentence() instead of mb_substr().

So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

Ah, thanks.

I cannot find getDateTranslations anywhere so I'm having the (probably very stupid) question where this function was called once upon a time (edit: oh well, I now realize it's a test case so I guess this just gets executed when running tests. sigh.).

Add minimal PHPDoc

I proposed two related patches in D25683 and D25685, both of them obsoleted by: D25687.

/settings/panel/multifactor/ requires users to add a custom Name so there is likely code to adapt/reuse for /settings/panel/apitokens/

https://we.phorge.it/source/phorge/browse/master/src/applications/auth/adapter/PhutilGitHubAuthAdapter.php$57-58 uses a boring
$future->addHeader('User-Agent', __CLASS__); for this.

Use consistent CSS scopes. Tested. And really really last change for now. I think.

Use consistent class scope; fix a typo

IMHO this is ready to review.

Avoid non-ASCII bytes in CSS by using FontAwesome

Display custom collapse/expand arrows only on mobile screens; display them after the column header name instead of before

Add PHPDoc for setCollapsible

Fix syntax

Not sure if we prefer to make isCollabsable a property of the base classes, instead of making them non-final

Yeah right, NuanceFormItemType returns an array so NuanceGitHubEventItemType should also return an empty array. Good point, thanks!

kill it

@valerio.bozzolan: Y U so sirious??? :D

Thanks! Confirming that the link on https://we.phorge.it/book/dev/class/PhutilDaemon/ is a 404, and that the file was deleted in https://secure.phabricator.com/rPHU720c8116845bb9dc19334170e6c0702aa0210c78