Cleaner attempt in D25546 Diff 2113.

Allow to setEditEngine when constructing a PhabricatorApplicationTransactionCommentView

Thanks for the pointers, I really appreciate them.

Ah, thanks, makes sense now. I'd probably rephrase "but harms the authors constraint" a little bit to explicitly cover what you explained well in D25676#18549 - an author PHID in $this->responsibles might not always be a member of a project or owner of a package, so the query results were incomplete beforehand.

Ah I see below it assumes string. Thanks!

Is it possible tasks isn’t a string in this case, where non_empty_scalar might be more of a match?

seems good, ty!

Thanks. Moreover, looking at PhutilKeyValueCache it seems that setKey(null) has no sense. So thanks also for that extra care you already set.

Hi bekay, thanks for looking into this, very appreciated!

There is no reason to expose "Manage" for admins only. I'm abandoning this in favor of D25687.

I will then need a rebase for D25363

Could you clarify if this is only supposed to work for import an .ics URI and not for importing a single event via an .ics file? Maybe I'm overcomplicating things, what I tried:

I admit I am quite interested in the changes in src/applications/people/query/PhabricatorPeopleUserEmailQuery.php adding $userPhids and $isVerified as I have a downstream use case for them.
Would be lovely to get them in, nevertheless where the actual calendar feature request is going.

Use PhabricatorMarkupEngine::summarizeSentence() instead of mb_substr().

thanks you

To me it makes sense thanks. Maybe just add a comment somewhere to say that the menu should be automatically generated - T15224

So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

So PHP, very wow

Test plan: I finished my ideas. It seems it just works 🤔

In D25685#18805, @avivey wrote:

this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

As T15224 suggest, this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

Better than before.

all those tears shed by devastated users after clicking the Calendar menu item

Ah, thanks.

No, it never was called anywhere. Read the HTML comment this commit deletes.

I cannot find getDateTranslations anywhere so I'm having the (probably very stupid) question where this function was called once upon a time (edit: oh well, I now realize it's a test case so I guess this just gets executed when running tests. sigh.).

Add minimal PHPDoc

I proposed two related patches in D25683 and D25685, both of them obsoleted by: D25687.

Maybe a good moment for minimal PHPDoc with

I will update the screenshots. Let's wait another +1 on strings.

Tried to re-phrase a bit, thanks to feedback from Italian coworkers and Andrè. lol