I posted this in a separate thread, but it is definitely related: https://we.phorge.it/T15524

I'm unable to reproduce:
I've deleted a file in arcanist library, and ran arc liberate. I got no error message and the __phutil_library_map__.php was updated correctly.

I think we can consider this as resolved by our dear @jacques since I just tried and it finally works ✨

I honestly have nothing more to be done here. I would like to set as resolved but there are sub-tasks opened

In T12071, @epriestly mentions that individually selecting env-vars to copy "build[s] some resistance to "Shellshock" class vulnerabilities", which is kind of a compelling argument.

Ok, looks like my personal install is missing $HOME as well, so I can probably try to reproduce.

In T15188#9488, @speck wrote:

It looks like upstream just straight-up removed the call to utf8_decode() in the master branch: https://secure.phabricator.com/diffusion/ARC/browse/master/src/utils/utf8.php$290-292

It looks like upstream just straight-up removed the call to utf8_decode() in the master branch: https://secure.phabricator.com/diffusion/ARC/browse/master/src/utils/utf8.php$290-292

It would be helpful to have reproducing steps here, but probably this was never reproduced by the reporter, just found from TranslateWiki

If you want additional glory, feel free to add an answer below, mentioning your task and your patch. Thanks again :) and feel free to land, since it's approved now (arc land).

Created T15412 and D25237 to fix this issue.

Thanks!

Whooops, added! :)

@valerio.bozzolan have you added me to the Trusted Contributors group? I don't seem to have the permission to create any new tasks. Happy to create the task for this bug and the diff to fix it.

Hi @jkimbo thank you for your bug report. Now you are a Trusted Contributors. Feel free to elevate this question as a Task under PHP 8 support

In T15364#8952, @avivey wrote:

"tooling for chains of diffs" might need its own topic, with a design of the what the whole thing should look like in an ideal world, and how to get to it.
Even if not all of the stuff fits nicely into Phorge, there's probably a lot that can work, and some conduit methods can be added to implement the rest.

"tooling for chains of diffs" might need its own topic, with a design of the what the whole thing should look like in an ideal world, and how to get to it.
Even if not all of the stuff fits nicely into Phorge, there's probably a lot that can work, and some conduit methods can be added to implement the rest.

Chaining Diffs is something that we would like to use more often, and it is definitely not used enough today. FreeBSD is a large codebase and making any change that is bigger than trivial often involves touching multiple parts of the system, the most difficult kind of change is architectural changes. We are limited by our tooling to a certain degree:

• Keeping everything in one Diff makes it very difficult to review as well as reach consensus, as there are often multiple responsible parties involved. It also violates the ethos of Phab/Phorge of having small atomic changes.
• Breaking changes down in smaller chunks has lots of downsides too - it is very hard to track and changes often get lost in depths of Differential.

mmm... I've never really worked where many changes are made of lots of dependent revisions - it's possible I've never even seen a chain of 3 revisions in the same repo. So I'm not sure about workflows for this kind of scenarios.

Yea, today I have about 50 lines of shell scripting that gets the different bits of data from the condon API point and then bashes them into a nearly acceptable commit message....

Ok, so here's my thoughts on moving this forward:

It hadn't happened in a while, so I guess it was something strange in my machine.

By the way the only usages are:

FWIW I think the test plan is configurable (that requirement can be disabled in phabricator's config server side which should remove it from commit messages in arc)

Yeah no problem!

In T15368#8316, @valerio.bozzolan wrote:

Hi @aklapper. Are you affected by this as well?

@valerio.bozzolan right, I forgot the important bit, sorry :D

Note that probably @ton you have resolved, but anybody else nope :D The patch D25205 still needs review and land

Thank you speck, very interesting.

Hi @aklapper. Are you affected by this as well?

@ton yep thanks, really! that will be handled here:

What are the reasons for doing commit message rendering on the server side?

In an ideal world the solution should be as simple as having a template somewhere in {{repo_root}}/.arcanist/commit_template.j2 that arcanist injects values in and renders.

arc patch problem is likely fixed. But I encountered similar problem here
https://we.phorge.it/T15351#8287

This seems to have fixed the problem. But let me try a bit more Diffs to be extra sure

We can probably come up with a way to allow an extension to customize the "render template" implementation without forking (e.g., just add a hook in differential.getcommitmessage), but it would have to be very carful about the whole form-thing.
Maybe just adding an "for landing" flag in differential.getcommitmessage (or adding a different method) would solve this problem...

In T15364#8281, @ton wrote:

The template is actually generated server side, not in arcanist, so it just a matter of getting the BSD Phorge server to have the right opinions.
Some of the sections can be configured already

Please point me in the right place in the code where I can find the template

In upstream phabricator I worked with Evan to update the Mercurial API in a way that all mercurial commands/futures are executed through a common path and allow making modifications to only those executions. For this we should look at something similar so that we're only passing $HOME to git commands and not to others.

The template is actually generated server side, not in arcanist, so it just a matter of getting the BSD Phorge server to have the right opinions.
Some of the sections can be configured already

re @avivey : arc land --hold sort of works but look at the ergonomics:

Alternatively - there's also arc land --hold, which does almost everything except for the git push, which would allow the user to update the commit message. Have anyone tried that?

thanks @ton - these look very actionable:

Hi @ton can I ask you if, manually patching Arcanist with the indicated diff in the Task description, fixes for you?

more details about arc land - https://we.phorge.it/T15364

Maybe this is the root problem:

I just want to note down that this stack trace has no sense to me: