Thank you speck, very interesting.

Hi @aklapper. Are you affected by this as well?

@ton yep thanks, really! that will be handled here:

What are the reasons for doing commit message rendering on the server side?

In an ideal world the solution should be as simple as having a template somewhere in {{repo_root}}/.arcanist/commit_template.j2 that arcanist injects values in and renders.

arc patch problem is likely fixed. But I encountered similar problem here
https://we.phorge.it/T15351#8287

This seems to have fixed the problem. But let me try a bit more Diffs to be extra sure

We can probably come up with a way to allow an extension to customize the "render template" implementation without forking (e.g., just add a hook in differential.getcommitmessage), but it would have to be very carful about the whole form-thing.
Maybe just adding an "for landing" flag in differential.getcommitmessage (or adding a different method) would solve this problem...

In T15364#8281, @ton wrote:

The template is actually generated server side, not in arcanist, so it just a matter of getting the BSD Phorge server to have the right opinions.
Some of the sections can be configured already

Please point me in the right place in the code where I can find the template

In upstream phabricator I worked with Evan to update the Mercurial API in a way that all mercurial commands/futures are executed through a common path and allow making modifications to only those executions. For this we should look at something similar so that we're only passing $HOME to git commands and not to others.

The template is actually generated server side, not in arcanist, so it just a matter of getting the BSD Phorge server to have the right opinions.
Some of the sections can be configured already

re @avivey : arc land --hold sort of works but look at the ergonomics:

Alternatively - there's also arc land --hold, which does almost everything except for the git push, which would allow the user to update the commit message. Have anyone tried that?

thanks @ton - these look very actionable:

Hi @ton can I ask you if, manually patching Arcanist with the indicated diff in the Task description, fixes for you?

more details about arc land - https://we.phorge.it/T15364

Maybe this is the root problem:

I just want to note down that this stack trace has no sense to me:

In T15281#7096, @speck wrote:

Could you check the server configuration of php.ini for the value of variable_orders? This open task on phab suggests that on servers it should enforce including E causing phab's environment to be passed to sub-commands, but does not want to mess with it on users' machines.

https://secure.phabricator.com/T12071

Could you check the server configuration of php.ini for the value of variable_orders? This open task on phab suggests that on servers it should enforce including E causing phab's environment to be passed to sub-commands, but does not want to mess with it on users' machines.

I can no longer reproduce this, so I'm guessing it was something bad in my setup.

Dear @goddenrich you are now mentioned in the Change Log > 2023 Week 2 :) Thanks again

Wow. Probably this can be considered resolved.

I think that @goddenrich is executing a lint on a personal private project, so it's not easy for you to share the project itself, to reproduce this quickly. Isn't it?

@ton welcome, glad to have your input here.