Differential D25018
Add conduit endpoints for querying legalpad Authored by roguelazer on Aug 4 2021, 23:28. Tags None Referenced Files
Subscribers Tokens
Details
This diff adds conduit methods for searching for legalpad documents and signatures. This is very helpful for auditing who's actually signed a document. It also fixes the "contributorPHIDs" constraint in the existing search engine. In order to expose legalpad signatures through Conduit, this adds a phid column to the legalpad_documentsignature table. It includes a migration (in the style of many previous phid-adding migrations) to actually populate the column. We run this on my company's internal fork and it seems to work okay. I don't think any other conduit methods anywhere have tests (???), but if you can point me at one I'm glad to write a unit test!
Diff Detail
Event TimelineComment Actions Wow, this is something I developed for wikimedia but not nearly as extensive! I'll try to give some code review when I have a few minutes to look this over. Comment Actions I'm not familiar with the search engine or legalpad frameworks but things look like they line up
Comment Actions FWIW here is my implementation which overlaps somewhat: https://phabricator.wikimedia.org/rPHAB4e9fe6e8a314ceb2be1e74dd448fe91bc5f78182 I don't think I innovated anything and your code looks roughly better than mine I think. Comment Actions Ok my implementation had a couple of additional search constraints which are missing here. Otherwise this looks good to me and is more complete. I'll probably abandon my patch and apply this one if you don't mind including the additional search constraints. (See suggested edits.)
Comment Actions I think this looks good, and based on the (non-search-engine) conduit API stuff I'm familiar with I think everything looks correct. One thing I'd like to increase on Phorge changes is adding comment documentation where it makes sense. I'm not sure what additional documentation would make sense here, as most of understanding this is understanding the existing Legal Document/Signature models and the Search Engine framework.
Comment Actions I'm going to look at trying to land this today. Additionally I created T15042 to avoid situations like this where the changes are accepted but don't get landed for some time. Comment Actions Thanks for landing, and sorry for the delay; was away on vacation. I'll try to be more responsive in the future! | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
