Page MenuHomePhorge

PonderQuestion: add method isStatusClosed() and test cases
AbandonedPublic

Authored by valerio.bozzolan on Mar 23 2023, 14:32.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 13:00
Unknown Object (File)
Wed, May 1, 09:41
Unknown Object (File)
Mon, Apr 29, 19:39
Unknown Object (File)
Mon, Apr 29, 19:39
Unknown Object (File)
Mon, Apr 29, 19:39
Unknown Object (File)
Mon, Apr 29, 11:14
Unknown Object (File)
Mon, Apr 29, 10:43
Unknown Object (File)
Fri, Apr 26, 02:45

Details

Summary

This modification should not change anything logically.

Now you can call $ponderQuestion->isStatusClosed() that just returns true
for whatever closed status, and false otherwise.

The next step then is:

https://we.phorge.it/T15166

This is a very small change but this also adds two unit tests,
so there are more files edited than expected to keep the linter
happy.

Ref T15166

Test Plan
  • Verify that nothing has changed logically

Diff Detail

Event Timeline

valerio.bozzolan retitled this revision from PonderQuestion: add method isStatusClosed() and test cases This modification should not change anything logically. So, now you can call $ponderQuestion->isStatusClosed() that it just returns true for whatever closed status, and false... to PonderQuestion: add method isStatusClosed() and test cases.Mar 23 2023, 14:32
valerio.bozzolan edited the summary of this revision. (Show Details)

For some reasons, this patch was not auto closed from:

D25086: Ponder: strike code of resolved questions in query results

I mark this as abandoned but it's merged really automatically by arc diff.

https://we.phorge.it/rP5eac69b79dbb37b5efa29c3d7383605ea64426e0