Show title entirely and cut of secondary information gracefully in typeahead results of main search
ClosedPublic
Actions

Authored by bekay on Jan 18 2024, 13:24.

Details

Reviewers

valerio.bozzolan
avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15715: Typehead results of main search should not truncate important information

Commits

rPb035743ce38f: Show title entirely and cut of secondary information gracefully in typeahead…

Summary

This revision increases the usability of the typeahead results of the main search (on the right in the top bar).
The result texts wont't overflow in a reasonable way.

Before	After

The result title (red box) will now break so the user can read and understand it.
The result type (blue box) will be cut off inside the padding with an ellipsis.

See T15715

Test Plan

Check it out and use the main search in the top bar to create typeahead result with very long titles ;)

Nothing changes for short titles.

Diff Detail

Repository

rP Phorge

Branch

T15715

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1033
Build 1033: arc lint + arc unit

Event Timeline

bekay created this revision.Jan 18 2024, 13:24

Owners added a reviewer: O1: Blessed Committers.Jan 18 2024, 13:24

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJan 18 2024, 13:24

bekay requested review of this revision.Jan 18 2024, 13:24

Harbormaster completed remote builds in B1026: Diff 1644.Jan 18 2024, 13:24

bekay attached a referenced file: F715296: image.png. (Show Details)Jan 18 2024, 13:25

bekay mentioned this in T15715: Typehead results of main search should not truncate important information.

Tested and I like it. Thanks :3

Please wait a couple of days at least before landing, to have more watchers

This revision is now accepted and ready to land.Jan 18 2024, 13:50

valerio.bozzolan edited the summary of this revision. (Show Details)Jan 18 2024, 13:51

valerio.bozzolan edited the test plan for this revision. (Show Details)

valerio.bozzolan attached a referenced file: F715385: image.png. (Show Details)

please make the title more descriptive of the actual change (what it's doing) - "improve usability" is very vague.
maybe "don't hide title in search" or something like that.

bekay retitled this revision from Increases usability of typeahead results of main search to Show title completly and cut of secondary information grave in typeahead results of main search.Jan 18 2024, 13:58

bekay retitled this revision from Show title completly and cut of secondary information grave in typeahead results of main search to Show title entirely and cut of secondary information gracefully in typeahead results of main search.

Thanks
also - need to run bin/celerity map before landing?

valerio.bozzolan mentioned this in T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.Jan 18 2024, 14:08