This makes the set of hooks easily extensible, as a first step toward integrating more 3rd party CI in phorge.
Details
Details
- Reviewers
Matthew - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15018: Make Harbormaster more generally usable and extendable
- Commits
- rPe7740c8669b4: Add HarbormasterHookController as an entry point for all Harbormaster hooks
Send requests to /harbormaster/hook/circleci/ and /harbormaster/hook/buildkite/ and check they run the proper handler.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- extensiblehook
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 12 Build 12: arc lint + arc unit
Event Timeline
| src/applications/harbormaster/integration/HarbormasterHookHandler.php | ||
|---|---|---|
| 24–26 | Could we add documentation to these for future implementations know what's expected? I think in particular getName() actually affects the expected URL to be hit from an external CI, correct? Would a UT be appropriate to ensure that implementations of HarbormasterHookHandler don't overlap their names? | |
Comment Actions
This change looks solid but I am a little concerned about pushing up feature/functional changes prior to getting all the branding work done for T15006: Re-brand Phorge. I haven't been able to spend as much time on that recently as I'd like and would appreciate any assistance on it. I'll update the task to clarify the strategy/approaches that I think we need to address.