HomePhorge

Add HarbormasterHookController as an entry point for all Harbormaster hooks
Concern Raisede7740c8669b4

Description

Add HarbormasterHookController as an entry point for all Harbormaster hooks

Summary: This makes the set of hooks easily extensible, as a first step toward integrating more 3rd party CI in phorge.

Test Plan: Send requests to /harbormaster/hook/circleci/ and /harbormaster/hook/buildkite/ and check they run the proper handler.

Reviewers: O1 Blessed Committers, Matthew

Reviewed By: O1 Blessed Committers, Matthew

Subscribers: Matthew, speck, tobiaswiese

Maniphest Tasks: T15018

Differential Revision: https://we.phorge.it/D25005

Details

Auditors
Ekubischta
Provenance
deadalnixAuthored on Jun 19 2021, 13:09
deadalnixPushed on Jun 21 2021, 10:48
Reviewer
Restricted Owners Package
Differential Revision
D25005: Add HarbormasterHookController as an entry point for all Harbormaster hooks
Parents
rP2258ba8535d5: Add package.json for aphlict
Branches
Unknown
Tags
Unknown
Tasks
T15018: Make Harbormaster more generally usable and extendable

Event Timeline

Ekubischta added a subscriber: Ekubischta.

I feel we should revert this change from master and back into a revision

We are not ready for functional changes to the platform, and D25005 has no unit tests or lint coverage reported

This commit now has outstanding concerns.Jun 23 2021, 02:57