Page MenuHomePhorge

Add HarbormasterHookController as an entry point for all Harbormaster hooks

Authored by deadalnix on Jun 19 2021, 14:55.
Referenced Files
Unknown Object (File)
Mon, Apr 8, 09:53
Unknown Object (File)
Mon, Apr 8, 09:49
Unknown Object (File)
Mon, Apr 8, 08:17
Unknown Object (File)
Sun, Apr 7, 02:03
Unknown Object (File)
Sun, Mar 31, 20:52
Unknown Object (File)
Sat, Mar 30, 01:15
Unknown Object (File)
Mon, Mar 25, 19:34
Unknown Object (File)
Mon, Mar 25, 17:53



This makes the set of hooks easily extensible, as a first step toward integrating more 3rd party CI in phorge.

Test Plan

Send requests to /harbormaster/hook/circleci/ and /harbormaster/hook/buildkite/ and check they run the proper handler.

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

Matthew subscribed.

Looks good to me.

I've created a task to track these changes, by the way.

This revision is now accepted and ready to land.Jun 20 2021, 21:37

Could we add documentation to these for future implementations know what's expected? I think in particular getName() actually affects the expected URL to be hit from an external CI, correct? Would a UT be appropriate to ensure that implementations of HarbormasterHookHandler don't overlap their names?

This change looks solid but I am a little concerned about pushing up feature/functional changes prior to getting all the branding work done for T15006: Re-brand Phorge. I haven't been able to spend as much time on that recently as I'd like and would appreciate any assistance on it. I'll update the task to clarify the strategy/approaches that I think we need to address.