Page MenuHomePhorge

Fix source code viewer background color when using Dark Mode in Diffusion
ClosedPublic

Authored by bob on Aug 16 2023, 14:41.
Tags
None
Referenced Files
F3657608: D25396.1745452470.diff
Tue, Apr 22, 23:54
F3647874: D25396.1745412623.diff
Tue, Apr 22, 12:50
F3645456: D25396.1745376726.diff
Tue, Apr 22, 02:52
F3605124: D25396.1745252561.diff
Sun, Apr 20, 16:22
F3604947: D25396.1745246286.diff
Sun, Apr 20, 14:38
F3587887: D25396.1745144587.diff
Sat, Apr 19, 10:23
F3576774: D25396.1745069604.diff
Fri, Apr 18, 13:33
F3374792: D25396.1744297117.diff
Wed, Apr 9, 14:58

Details

Summary

This CSS fix replaces the hard coded white background value by the diff.background CSS variable. This is a proposal
to address this issue but it may be a good idea to create a different CSS variable (for instance source.background)
in order to avoid any potential side effect in the future.

BeforeAfter
screenshot-phorge-bug-darkmode-source-view-before.png (536×1 px, 30 KB)
screenshot-phorge-bug-darkmode-source-view-after.png (536×1 px, 49 KB)

Fix : T15056

Test Plan
  • Flush all Phorge caches
  • Sign in
  • Open a diffusion repository
  • Open any file
  • Check that viewer background color is consistent with the theme.

Diff Detail

Repository
rP Phorge
Branch
css-source-code-view
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 765
Build 765: arc lint + arc unit

Event Timeline

bob requested review of this revision.Aug 16 2023, 14:41

Updating D25396: Include updated celerity map file

Nice thaaanks

I agree that a follow-up change could improve even more the situation, but this just looks great both in white mode, and in dark mode.

Tested, no nuclear implosions, and celerity is updated, I also brushed my teeth correctly.

sgtm

This revision is now accepted and ready to land.Aug 17 2023, 08:25