Page MenuHomePhorge

Fix source code viewer background color when using Dark Mode in Diffusion
ClosedPublic

Authored by bob on Aug 16 2023, 14:41.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 13:00
Unknown Object (File)
Sat, May 4, 13:00
Unknown Object (File)
Fri, May 3, 21:33
Unknown Object (File)
Fri, May 3, 13:05
Unknown Object (File)
Wed, Apr 24, 22:22
Unknown Object (File)
Wed, Apr 24, 21:50
Unknown Object (File)
Apr 5 2024, 14:09
Unknown Object (File)
Apr 1 2024, 03:49

Details

Summary

This CSS fix replaces the hard coded white background value by the diff.background CSS variable. This is a proposal
to address this issue but it may be a good idea to create a different CSS variable (for instance source.background)
in order to avoid any potential side effect in the future.

BeforeAfter
screenshot-phorge-bug-darkmode-source-view-before.png (536×1 px, 30 KB)
screenshot-phorge-bug-darkmode-source-view-after.png (536×1 px, 49 KB)

Fix : T15056

Test Plan
  • Flush all Phorge caches
  • Sign in
  • Open a diffusion repository
  • Open any file
  • Check that viewer background color is consistent with the theme.

Diff Detail

Repository
rP Phorge
Branch
css-source-code-view
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 764
Build 764: arc lint + arc unit

Event Timeline

bob requested review of this revision.Aug 16 2023, 14:41

Updating D25396: Include updated celerity map file

Nice thaaanks

I agree that a follow-up change could improve even more the situation, but this just looks great both in white mode, and in dark mode.

Tested, no nuclear implosions, and celerity is updated, I also brushed my teeth correctly.

sgtm

This revision is now accepted and ready to land.Aug 17 2023, 08:25