Add (Advanced) Custom Fields to Item List
AcceptedPublic
Actions

Authored by avivey on Mar 1 2024, 11:03.

Details

Reviewers

aklapper
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15133: Differential List View should show Repository
T15512: Make Flags more useful
T15750: Integrate CustomField into more interfaces

Summary

Allow PHP-coded Custom Fields to show things in Lists.

Also add Repository to Revision List and Flags to Maniphest lists.

Closes T15133. Ref T15512, T15750

Test Plan

Look at Repository List and Task lists that have flags.

Diff Detail

Repository

rP Phorge

Branch

customfield-list

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/view/DifferentialRevisionListView.php:56	XHP16	TODO Comment
Advice	src/applications/search/engine/PhabricatorApplicationSearchEngine.php:1646	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 1085
Build 1085: arc lint + arc unit

Event Timeline

avivey created this revision.Mar 1 2024, 11:03

avivey held this revision as a draft.

Owners added a reviewer: O1: Blessed Committers.Mar 1 2024, 11:03

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMar 1 2024, 11:03

Harbormaster completed remote builds in B1085: Diff 1731.Mar 1 2024, 11:03

avivey edited the summary of this revision. (Show Details)Mar 1 2024, 11:36

avivey edited the test plan for this revision. (Show Details)

avivey added tasks: T15750: Integrate CustomField into more interfaces, T15512: Make Flags more useful, T15133: Differential List View should show Repository.

avivey added inline comments.Mar 1 2024, 11:38

src/applications/maniphest/query/ManiphestTaskSearchEngine.php
396–412	Moving this here is a small improvement, but in reality the "$handles" array used in this flow is inferior to just using `$viewer->renderHandle()`, and should be replace with that. Before this change, we'd actually load all the labels twice using the old, uncached mechanism.

ready for review

Harbormaster completed remote builds in B1086: Diff 1732.Mar 1 2024, 11:38

avivey published this revision for review.Mar 1 2024, 11:39

avivey added a child revision: D25549: Add Standard Custom Fields to Item List.Mar 1 2024, 16:26

small fix

Harbormaster completed remote builds in B1088: Diff 1734.Mar 1 2024, 16:34

avivey mentioned this in Z1: Phorge.Mar 30 2024, 10:44

IIUC this adds Flags in Differential, Maniphest, etc list views, and adds the repository in Differential list view?

Functionality wise this looks great and works as expected for me:

Screenshot from 2024-04-01 19-27-51.png (970×948 px, 98 KB)

Screenshot from 2024-04-01 19-25-22.png (526×948 px, 107 KB)

Use Results > Export Data > CSV in both Differential and Maniphest query result lists does not include a repository column (that is fine) and is still valid CSV.

Wondering if rendered flags should be links to http://phorge.localhost/flag/ but that would be a separate request anyway.

Giving a +1 on personal capacity; I don't really feel knowledgeable enough to give a +1 as O1 (yet).

(Flags only show up in Maniphest on this one; I'll add them to more apps in a layer diff)

I'm shocked to see the flag on the revisions list. Turns out it's already a thing (on master!). Did not know about it, I'll have to look for it in the code.

Thanks!

Traced the Flags in Revision back to its origin in https://secure.phabricator.com/T1557. I knew about this one - but I was 100% sure that the feature was lost when the SearchEngine classes were introduced.

I see "Unknown object" if the Diff repository is unset. Is that known?