Page MenuHomePhorge
Differential D25133

Countdown: fix PhutilMissingSymbolException
ClosedPublic
Actions

Authored by Dylsss on Apr 24 2023, 00:31.
Tags
None
Referenced Files
F2176825: D25133.diff
Fri, May 3, 17:12
Unknown Object (File)
Thu, May 2, 09:53
Unknown Object (File)
Wed, May 1, 19:11
Unknown Object (File)
Thu, Apr 25, 10:48
Unknown Object (File)
Thu, Apr 25, 10:48
Unknown Object (File)
Thu, Apr 25, 05:22
Unknown Object (File)
Wed, Apr 24, 22:23
Unknown Object (File)
Thu, Apr 11, 04:29
View All 81 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15271: Fix Exception "PhutilMissingSymbolException" that can happen after new Countdown permission
Commits
rP98c1267e5f16: Countdown: fix PhutilMissingSymbolException
Summary

A previous change added a couple of Countdown-related classes:

7ed35123a347a05c70c97eba2bec2b36eb2b3218

This change updates the related library map (arc liberate) in order to
fix any related regression (like PhutilMissingSymbolException).

Closes T15271

Test Plan
  • you run arc liberate and the file does not change
  • you do not see any PhutilMissingSymbolException exception

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 265
Build 265: arc lint + arc unit

Event Timeline

Dylsss created this revision.Apr 24 2023, 00:31
Owners added a reviewer: O1: Blessed Committers.Apr 24 2023, 00:31
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptApr 24 2023, 00:31
Harbormaster completed remote builds in B265: Diff 513.Apr 24 2023, 00:31
Dylsss requested review of this revision.Apr 24 2023, 00:31
Dylsss mentioned this in D25052: Add and use new RemarkupMetadata class.Apr 24 2023, 01:57
valerio.bozzolan added a comment.Apr 25 2023, 10:26

So you executed the famous "arc liberate". Isn't it?

If yes, it would be interesting to discover why all lints / units from D25101 passed

valerio.bozzolan accepted this revision.Apr 25 2023, 10:26
This revision is now accepted and ready to land.Apr 25 2023, 10:26
valerio.bozzolan retitled this revision from Fix out of date library map regression to Countdown: fix out of date library map regression.Apr 25 2023, 10:29
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan edited the test plan for this revision. (Show Details)
valerio.bozzolan mentioned this in rP7ed35123a347: Countdown: add a capability to decide who can Create.
valerio.bozzolan added a comment.EditedApr 25 2023, 10:59

Just as a side note, from my perspective this change is needed but it's really not related to any frontend / log issue. I still get the error Error: Empty ID passed to JX.$()! and it seems it's related to the persistent chat, and its metadata usage, and not to the Calendar itself.

So I recommend this change but we probably cannot call the mentioned commit a "regression" since it really causes no issues apparently.

valerio.bozzolan retitled this revision from Countdown: fix out of date library map regression to Countdown: add new classes to library map.Apr 25 2023, 11:05
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan edited the test plan for this revision. (Show Details)
valerio.bozzolan retitled this revision from Countdown: add new classes to library map to Countdown: fix PhutilMissingSymbolException.Apr 25 2023, 11:09
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan edited the test plan for this revision. (Show Details)
valerio.bozzolan edited the summary of this revision. (Show Details)Apr 25 2023, 11:12
valerio.bozzolan mentioned this in Z1: Phorge.Apr 25 2023, 11:15
valerio.bozzolan added a comment.EditedApr 25 2023, 11:19

Let's report also here that:

D25101 · rP7ed35123a347a05c70c97eba2bec2b36eb2b3218#904

↑ This recent specific commit now causes to me a PhutilMissingSymbolException when loading the home of Phorge.

Failed to load symbol "PhabricatorCountdownCreateCapability" (of type "class or interface").

I absolutely have no idea about why during the local test of the patch I hadn't had any issue at all, why the unit tests were OK, why the lints were OK, etc., but now we have definitely a clear problem here and the fix is: D25133: Countdown: fix PhutilMissingSymbolException

valerio.bozzolan mentioned this in D25025: Unify user-select CSS directives.Apr 25 2023, 11:30
valerio.bozzolan edited the summary of this revision. (Show Details)Apr 25 2023, 13:08
valerio.bozzolan added a task: T15271: Fix Exception "PhutilMissingSymbolException" that can happen after new Countdown permission.
valerio.bozzolan mentioned this in Next Up.Apr 25 2023, 13:15
Closed by commit rP98c1267e5f16: Countdown: fix PhutilMissingSymbolException. · Explain WhyApr 25 2023, 13:37
This revision was automatically updated to reflect the committed changes.
avivey added a commit: rP98c1267e5f16: Countdown: fix PhutilMissingSymbolException.
valerio.bozzolan mentioned this in Next Up (since Week 18).Apr 25 2023, 13:41

Revision Contents
Changeset List

Diff 513

View Options

src/__phutil_library_map__.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0