Page MenuHomePhorge

Update default wordmark and logo
ClosedPublic

Authored by avivey on Aug 22 2022, 19:12.
Tags
None
Referenced Files
F184176: D25048.id262.diff
Wed, Sep 28, 13:08
F184175: D25048.id.diff
Wed, Sep 28, 13:08
Unknown Object (File)
Tue, Sep 27, 17:37
Unknown Object (File)
Tue, Sep 27, 03:12
Unknown Object (File)
Sun, Sep 25, 17:02
Unknown Object (File)
Tue, Sep 20, 15:50
Unknown Object (File)
Tue, Sep 20, 15:48
Unknown Object (File)
Mon, Sep 19, 00:18

Details

Summary

The current default wordmark is "Phabricator" which is trademarked and the
default logo is also copyright.

(This change was made by @speck directly in the deployed instnace, bringing it into master now).

Test Plan

should be fine.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey requested review of this revision.Aug 22 2022, 19:12

looks like the favicon doesn't actually work :/

Could it be cached?

webroot/rsrc/css/application/base/main-menu-view.css
50

There’s probably an html file that needs to use this updated css name

I didn't want to do this, but I'm actually going to test this change.

Favicons are somehow cached server side:
<link rel="icon" id="favicon" href="http://localhost.localhost:8080/file/data/jvpvboup37hwjgpn3viv/PHID-FILE-xhmdncm6ydmubbkrfdj4/favicon" />

And they are actually located at https://we.phorge.it/source/phorge/browse/master/resources/builtin/favicon/ , not this file.
I'll remove this piece for now - I think it's not actually trademarked/copyrighted, so we can keep it for a little while longer.

webroot/rsrc/css/application/base/main-menu-view.css
50

I found a place to make this change, and I can't figure out if it did anything...

  • remove favicon, update css in php
This revision is now accepted and ready to land.Aug 22 2022, 19:57
This revision was automatically updated to reflect the committed changes.