Page MenuHomePhorge

Update default wordmark and logo
ClosedPublic

Authored by avivey on Aug 22 2022, 19:12.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 15:34
Unknown Object (File)
Thu, Apr 11, 04:34
Unknown Object (File)
Mon, Apr 8, 06:55
Unknown Object (File)
Sun, Mar 31, 14:06
Unknown Object (File)
Fri, Mar 29, 22:51
Unknown Object (File)
Thu, Mar 28, 00:52
Unknown Object (File)
Wed, Mar 27, 18:44
Unknown Object (File)
Sun, Mar 24, 00:22

Details

Summary

The current default wordmark is "Phabricator" which is trademarked and the
default logo is also copyright.

(This change was made by @speck directly in the deployed instnace, bringing it into master now).

Test Plan

should be fine.

Diff Detail

Repository
rP Phorge
Branch
phorge (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 80
Build 80: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Aug 22 2022, 19:12

looks like the favicon doesn't actually work :/

Could it be cached?

webroot/rsrc/css/application/base/main-menu-view.css
50

There’s probably an html file that needs to use this updated css name

I didn't want to do this, but I'm actually going to test this change.

Favicons are somehow cached server side:
<link rel="icon" id="favicon" href="http://localhost.localhost:8080/file/data/jvpvboup37hwjgpn3viv/PHID-FILE-xhmdncm6ydmubbkrfdj4/favicon" />

And they are actually located at https://we.phorge.it/source/phorge/browse/master/resources/builtin/favicon/ , not this file.
I'll remove this piece for now - I think it's not actually trademarked/copyrighted, so we can keep it for a little while longer.

webroot/rsrc/css/application/base/main-menu-view.css
50

I found a place to make this change, and I can't figure out if it did anything...

  • remove favicon, update css in php
This revision is now accepted and ready to land.Aug 22 2022, 19:57
This revision was automatically updated to reflect the committed changes.