Personal Workboard of @valerio.bozzolan.
Feel free to add a weird icon.
This project is archived only in order to avoid boring notifications to the end users.
Personal Workboard of @valerio.bozzolan.
Feel free to add a weird icon.
This project is archived only in order to avoid boring notifications to the end users.
@valerio.bozzolan Can this be closed nowadays?
PhabricatorFileImageTransform defines getTransformedDimensions(). There is no such method existing for video files as videos have no transforms.
The transform dimensions for image files are defined (and hardcoded) in its child class https://we.phorge.it/source/phorge/browse/master/src/applications/files/transform/PhabricatorFileThumbnailTransform.php$73-76. There is no way to reuse them anyway - 220px feels small.
@Cigaryno: Hi, do you still plan to work on this? Just asking to avoid cookie-licking :)
P.S. please help in reviewing the colors in D25491 - I absolutely don't know which color would be nice
In T15056#21859, @danielyepezgarces wrote:
Patch ready for testing in my production as usual lol D25569
Added web archive links to the task, because secure isn't loading right now.
The patch is already approved but maybe it's nice to bring more attention to extension developers
The scenario in which this index would be needed is far from being normal. The patch D26027 that would benefit for it, is able to avoid that query in 99% of cases (it only needs such query when you want to destroy a profile picture, AND that picture was manually un-attached... why was it manually un-attached? by a spam click? by a faulty mouse?). So, the normal scenario is too small and unclear to justify a new index.