Page MenuHomePhorge

ManiphestProject
ActivePublic

Members (2)

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Tue, Nov 15

arcadien added a comment to T15062: Introducing Phixator 2.

Looks great. I implemented a rough and simple logging feature over Phrequent, your extension looks more precise. I would think its better to merge/replace Phrequent rather than adding more implementations, though

Tue, Nov 15, 09:50 · Phrequent, Phorge General/Unknown, Dashboards, Governance, Maniphest

Oct 21 2022

Cigaryno created T15131: Add Workboards support for Differential.
Oct 21 2022, 16:01 · Projects, Differential

Oct 15 2022

Cigaryno added a member for Maniphest: Cigaryno.
Oct 15 2022, 08:02

Sep 21 2022

Matthew closed D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Sep 21 2022, 17:26 · Maniphest

Sep 7 2022

20after4 added a comment to T15101: Assigned to - Required Field.

https://secure.phabricator.com/book/phabricator/article/custom_fields/ custom fields allow you to set the required property in configuration. I'm not sure if you can use this to override a default built-in field but you could possibly replace the built in field with a custom field with same/similar name and type: users.

Sep 7 2022, 16:45 · Maniphest

Aug 27 2022

Higgs updated subscribers of T15109: Subpress listing of Projects in subscriber search.

@avivey Thanks a lot for the hints. I will take a look at the Spaces. That sounds like it could be helpful for our purposes.
@rraval Could you or someone else verify that a project that is made visible only to Administrators still shows up when a user opens the search selection list on the Subscribers field? And is this considered to be a bug or a feature? Of course i can set up a new Task for this if that makes sense.

Aug 27 2022, 17:39 · Maniphest, Config, Projects

Aug 25 2022

avivey added a comment to T15109: Subpress listing of Projects in subscriber search.

(Regarding the original task description:)

Aug 25 2022, 17:39 · Maniphest, Config, Projects
rraval added a comment to T15109: Subpress listing of Projects in subscriber search.

But still it is worrisome that we can configure visibility only by Administrators, yet everybody can assign the project as subscriber... Maybe that is a bug ?

Aug 25 2022, 13:13 · Maniphest, Config, Projects
Higgs added a comment to T15109: Subpress listing of Projects in subscriber search.

@rraval Right, i overlooked this setting. I managed to hide most projects from the Subscribers Search panel. We also have reduced the number of Projects to keep things more tidy.

Aug 25 2022, 13:04 · Maniphest, Config, Projects

Aug 24 2022

rraval added a comment to T15109: Subpress listing of Projects in subscriber search.

@Higgs You should be able to ProjectEdit DetailsVisible ToProject Members. Does that do what you expect?

Aug 24 2022, 14:03 · Maniphest, Config, Projects
Higgs added a comment to T15109: Subpress listing of Projects in subscriber search.

We use Projects for grouping users into teams. But unfortunately every user can see all Projects and assign them as subscribers to Tasks, regardless if they are members or not. Normally (in our case) Tasks are only relevant for users in the same project. Having the other projects displayed in the subscribers selection is unfortunate in this case.

Aug 24 2022, 08:37 · Maniphest, Config, Projects

Aug 23 2022

rraval added a comment to T15109: Subpress listing of Projects in subscriber search.

Our instance uses a ton of projects as "groups of people that need to be notified", so we use project subscribers a lot.

Aug 23 2022, 19:38 · Maniphest, Config, Projects
Higgs created T15109: Subpress listing of Projects in subscriber search.
Aug 23 2022, 10:55 · Maniphest, Config, Projects

Jul 26 2022

avivey added a comment to T15101: Assigned to - Required Field.

I don't think we have this capability right now.

Jul 26 2022, 15:18 · Maniphest

Jul 1 2022

Matthew lowered the priority of T15101: Assigned to - Required Field from Unbreak Now! to Needs Triage.

Please do not triage tasks yourself, we will integrate it into the roadmap as we go.

Jul 1 2022, 16:17 · Maniphest
SmoothPlay triaged T15101: Assigned to - Required Field as Unbreak Now! priority.
Jul 1 2022, 07:31 · Maniphest
SmoothPlay created T15101: Assigned to - Required Field.
Jul 1 2022, 07:31 · Maniphest

Jun 14 2022

Ekubischta added a comment to T15034: Show confirmation dialog when closing a modal if form contents have been changed.

Hit esc today - Lost lots of typing

Jun 14 2022, 16:11 · Maniphest

May 18 2022

dtf added a member for Maniphest: dtf.
May 18 2022, 18:54

Dec 1 2021

speck added a comment to T15062: Introducing Phixator 2.

Time tracking is an interesting topic. At my company we addressed this by having a Herald WebHook hit our internal server whenever activity we're interested in tracking happens. Our internal server tracks these activities from multiple sources (not just Phab/Phorge) and users can go in to see all their activity linked up and input the approximate time spent on those activities.

Dec 1 2021, 16:55 · Phrequent, Phorge General/Unknown, Dashboards, Governance, Maniphest

Nov 25 2021

Labricator added a comment to T15062: Introducing Phixator 2.

I'd definitely love to see this later. I MIGHT be able to get to this later.

Nov 25 2021, 17:41 · Phrequent, Phorge General/Unknown, Dashboards, Governance, Maniphest

Nov 23 2021

Ekubischta added a comment to T15062: Introducing Phixator 2.

This looks pretty great! - I think T15030 is the general covering task for Extensions

Nov 23 2021, 20:06 · Phrequent, Phorge General/Unknown, Dashboards, Governance, Maniphest

Nov 22 2021

motla updated subscribers of T15062: Introducing Phixator 2.
Nov 22 2021, 15:15 · Phrequent, Phorge General/Unknown, Dashboards, Governance, Maniphest
motla created T15062: Introducing Phixator 2.
Nov 22 2021, 15:15 · Phrequent, Phorge General/Unknown, Dashboards, Governance, Maniphest

Oct 13 2021

speck accepted D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Thanks!

Oct 13 2021, 21:08 · Maniphest
Ekubischta accepted D25015: Show confirmation dialog when closing a modal if form contents have been changed.
Oct 13 2021, 20:53 · Maniphest
Ekubischta added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#826, @speck wrote:

I think that makes sense. Could you make a task to address this so we don’t lose track of it? Then let’s get this landed.

Oct 13 2021, 20:52 · Maniphest
speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I think that makes sense. Could you make a task to address this so we don’t lose track of it? Then let’s get this landed.

Oct 13 2021, 16:35 · Maniphest
Ekubischta added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I feel like we should move translation to a new revision, so we can move forward with this one.

Oct 13 2021, 01:47 · Maniphest

Oct 5 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I'm down to do a https://meet.jit.si/ with someone else who is also down for this idea as well as the idea of translatable generic confirm() and alert() dialogs that can trivially go from pht() in PHP to JavaScript. Anyone?

Oct 5 2021, 03:43 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

We can have a i18n option for both confirmDialog and alertDialog.... Let's do this, who is down?

Oct 5 2021, 03:38 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#793, @dcog wrote:
In D25015#792, @dcog wrote:

Thanks -- Can anyone think of a more generic solution here as far as dialogs? Something for both confirm() and prompt().

One thing to note here: Native JavaScript blocks execution when these functions are used. This is apparently nearly impossible behavior to mimic exactly, but we can solve this with asynchronous functions with our generic and platform-specific confirm() and alert() functions. Otherwise, should there be an always-available global translation for both alert() and confirm()?

Example of custom confirm():

JX.confirm({
  message: "Form data may have changed. Are you sure you want to close this dialog?",
  buttonConfirm: "Discard Changes",
  buttonCancel: "Cancel",
  onConfirm: function() {
    // Something something
  }
});

But it would need translation added...

Oct 5 2021, 03:37 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#792, @dcog wrote:

Thanks -- Can anyone think of a more generic solution here as far as dialogs? Something for both confirm() and prompt().

One thing to note here: Native JavaScript blocks execution when these functions are used. This is apparently nearly impossible behavior to mimic exactly, but we can solve this with asynchronous functions with our generic and platform-specific confirm() and alert() functions. Otherwise, should there be an always-available global translation for both alert() and confirm()?

Oct 5 2021, 03:36 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Thanks -- Can anyone think of a more generic solution here as far as dialogs? Something for both confirm() and prompt().

Oct 5 2021, 03:35 · Maniphest

Sep 22 2021

speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#735, @avivey wrote:

I may be late for the party, but can't the translated verbiage be provided to the dialog in the $form_attributes in AphrontDialogView.php:337, and read using form.getAttribute(key) in the js?

I looked at the $form_attributes a week or so back but I think those end up being transformed into the literal HTML attributes of the dialog's <form> element. I think we need to add a new field to the dialog, something like setMetadata() that @dcog found in the workboard view.

Sep 22 2021, 01:16 · Maniphest

Sep 20 2021

avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

I may be late for the party, but can't the translated verbiage be provided to the dialog in the $form_attributes in AphrontDialogView.php:337, and read using form.getAttribute(key) in the js?

Sep 20 2021, 15:04 · Maniphest

Sep 17 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

What if, to get this functionality pushed through, we for now change the verbiage to two English words -- "Discard changes?"

Sep 17 2021, 02:17 · Maniphest

Sep 13 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Dug up some more info as well...

Sep 13 2021, 20:29 · Maniphest
speck updated subscribers of D25015: Show confirmation dialog when closing a modal if form contents have been changed.

@Leon95 updated/included some translated text for calendar widgets under D25016 which may also be useful as reference. However one big difference is that the calendar widget has its own explicit view/behavior, whereas front-end workflows have multiple varying uses with different content.

Sep 13 2021, 00:12 · Maniphest

Sep 4 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#678, @speck wrote:

It looks like there is a JX.phtize() which appears to be used to create a function that mimics pht() in JavaScript but I believe requires that whatever is passed to phtize() is effectively a map of translations which is presumably passed from the server somewhere. I've not yet uncovered this later part.

Sep 4 2021, 22:28 · Maniphest
speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

It looks like there is a JX.phtize() which appears to be used to create a function that mimics pht() in JavaScript but I believe requires that whatever is passed to phtize() is effectively a map of translations which is presumably passed from the server somewhere. I've not yet uncovered this later part.

Sep 4 2021, 19:10 · Maniphest

Aug 24 2021

speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#633, @avivey wrote:

In this case I think the error text is agnostic of the instance of the dialog.

I was thinking about this use-case, which implies to me that the dialog author should be involved in the error text:

image.png (206×423 px, 14 KB)

Aug 24 2021, 18:51 · Maniphest

Aug 20 2021

avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

What are the implications of making changes to the javelinjs.com https://github.com/phacility/javelin/ library?

Aug 20 2021, 06:58 · Maniphest

Aug 19 2021

dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Also I don’t believe javelin.io is related to the Javalin used in Phab.

Aug 19 2021, 05:45 · Maniphest
speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Ah I did not look closely enough. Dang. We should be attaching the message to the view on the server then, somehow.

Aug 19 2021, 04:51 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

Oh, another potential concern...

Aug 19 2021, 04:34 · Maniphest
dcog added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.
In D25015#616, @speck wrote:

In this case I think the error text is agnostic of the instance of the dialog. From looking at AphrontDialogView I didn't see any obvious way to include additional fields/text that could be pulled out here on the front end. Looking elsewhere in this file (line ~297) it looks like some other generic text is used

if (!this._paused) {
  JX.$E('Resuming a workflow which is not paused!');
}

However that's the only case where JX.$E is used outside of an is-development check. I'm not sure where these Javascript translations would go or when the translation file is generated.

Aug 19 2021, 04:33 · Maniphest
speck added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

In this case I think the error text is agnostic of the instance of the dialog. From looking at AphrontDialogView I didn't see any obvious way to include additional fields/text that could be pulled out here on the front end. Looking elsewhere in this file (line ~297) it looks like some other generic text is used

if (!this._paused) {
  JX.$E('Resuming a workflow which is not paused!');
}
Aug 19 2021, 01:34 · Maniphest

Aug 18 2021

20after4 added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

+1 this has bitten me before.

Aug 18 2021, 18:08 · Maniphest

Jul 28 2021

avivey added a comment to D25015: Show confirmation dialog when closing a modal if form contents have been changed.

The translated text can be a property of the dialogue itself, if we're worried about having extra objects laying around - the confirmation feels like it's a feature of the dialogue anyway.

Jul 28 2021, 07:20 · Maniphest