Page MenuHomePhorge
Create Task
Maniphest T15193

Clarify the difference between a "Removed" comment and a "Deleted" one
Closed, ResolvedPublic
Actions

Description

It would be nice to clarify the difference between a "Removed" comment and a "Deleted" one.

Resources:

https://we.phorge.it/rP58f66fea804ede7c3827895458c62f1604e0c776

https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/storage/PhabricatorApplicationTransactionComment.php

...

AFAIK, a "Removed" comment is in a logical state where it should not display its value to end-users. A "Deleted" comment has also lost its storage. But, I do not understand what the storage is, for a comment.

Anyway, if this is true, the related Diff should be correct now.

D25095: Removed Comments: add CSS class "phui-timeline-shell-removed"

Revisions and Commits

rP Phorge
AbandonedD25095 Removed Comments: add CSS class "phui-timeline-shell-removed"

Related Objects
Search...

Event Timeline

valerio.bozzolan created this task.Mar 25 2023, 19:02
valerio.bozzolan triaged this task as Normal priority.
valerio.bozzolan created this object in space S1 Public.
valerio.bozzolan added a revision: D25095: Removed Comments: add CSS class "phui-timeline-shell-removed".
valerio.bozzolan added a project: User-valerio.bozzolan.Mar 28 2023, 09:04
valerio.bozzolan closed this task as Resolved.Apr 1 2023, 16:37
valerio.bozzolan claimed this task.

I'm quite sure that:

  • removed: soft flag, something is just hidden
  • deleted: something was also removed in the database / storage
avivey edited projects, added Maniphest; removed Maniphest (archived).Apr 6 2023, 10:52
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0