Page MenuHomePhorge
People bob

bob (Stéphane Railhet)
Engineering

Projects

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 4 2023, 14:08 (71 w, 4 d)
Availability
Available
Timezone
Europe/Paris

Recent Activity
View All

Nov 22 2023

bob added a comment to D25403: Improve CelerityDarkModePostprocessor shade colors.

I didn't give up on this one and, since I prefer using the dark theme on my day to day activity, I know there are a lot of work to be done to reach something nice.
I'll try to move forward on next weeks...

Nov 22 2023, 16:10
bob closed T15629: PHP 8.1 "strlen(null)" exception when importing a subversion commit as Resolved by committing rPcf8d5d60a594: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.
Nov 22 2023, 15:56 · PHP 8 support
bob closed T15629: PHP 8.1 "strlen(null)" exception when importing a subversion commit, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Nov 22 2023, 15:56 · PHP 8 support
bob closed D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.
Nov 22 2023, 15:56
bob committed rPcf8d5d60a594: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser
Nov 22 2023, 15:56
bob closed T15628: PHP 8.1 "strlen(null)" exception when displaying a 'recent' subversion commit as Resolved by committing rPacfb44d6679e: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Nov 22 2023, 15:55 · PHP 8 support
bob closed T15628: PHP 8.1 "strlen(null)" exception when displaying a 'recent' subversion commit, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Nov 22 2023, 15:55 · PHP 8 support
bob closed D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Nov 22 2023, 15:55
bob committed rPacfb44d6679e: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page
Nov 22 2023, 15:55
bob closed T15610: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Nov 22 2023, 15:54 · PHP 8 support
bob closed T15610: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer as Resolved by committing rP5bd526646144: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Nov 22 2023, 15:54 · PHP 8 support
bob closed D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Nov 22 2023, 15:54
bob committed rP5bd526646144: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Nov 22 2023, 15:54

Nov 20 2023

bob added a comment to D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Great, I'm a little bit busy, professionally speaking but, I'll try to land it this week !

Nov 20 2023, 21:15

Sep 20 2023

bob added a comment to D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Honestly, I don't know why we have old commits improperly filled, you can maybe play with svnadmin command on a dummy repo as described here : Change author of SVN commit

Sep 20 2023, 12:05

Aug 28 2023

bob requested review of D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.
Aug 28 2023, 13:05
bob added a revision to T15629: PHP 8.1 "strlen(null)" exception when importing a subversion commit: D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.
Aug 28 2023, 13:04 · PHP 8 support
bob updated the summary of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Aug 28 2023, 13:01
bob updated the summary of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Aug 28 2023, 13:01
bob added a revision to T15628: PHP 8.1 "strlen(null)" exception when displaying a 'recent' subversion commit: D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Aug 28 2023, 12:48 · PHP 8 support
bob updated the summary of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Aug 28 2023, 12:48
bob requested review of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Aug 28 2023, 12:47
bob added a comment to T15628: PHP 8.1 "strlen(null)" exception when displaying a 'recent' subversion commit.

Finally, after additional tests, I guess these issue are not related (as related in T15629)

Aug 28 2023, 12:40 · PHP 8 support
bob created T15629: PHP 8.1 "strlen(null)" exception when importing a subversion commit.
Aug 28 2023, 12:39 · PHP 8 support
bob created T15628: PHP 8.1 "strlen(null)" exception when displaying a 'recent' subversion commit.
Aug 28 2023, 11:19 · PHP 8 support
bob updated the test plan for D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 28 2023, 09:09
bob added a comment to D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

You're right valerio, this sign in is an automatic reflex since my Phorge instance is private ;)

Aug 28 2023, 08:47
bob attached a referenced file: F332921: screenshot-phorge-bug-darkmode-ponder-answer-before.png.
Aug 28 2023, 08:40
bob attached a referenced file: F332922: screenshot-phorge-bug-darkmode-ponder-answer-after.png.
Aug 28 2023, 08:40
bob closed D25393: Fix answer background color when using Dark Mode in Ponder.
Aug 28 2023, 08:39
bob committed rP0ec3291ff4a9: Fix answer background color when using Dark Mode in Ponder.
Fix answer background color when using Dark Mode in Ponder
Aug 28 2023, 08:39

Aug 18 2023

bob updated the test plan for D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 13:51
bob closed T15608: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in subversion repository, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 18 2023, 13:50 · PHP 8 support
bob closed T15608: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in subversion repository as Resolved by committing rP8876f75fbb99: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 13:50 · PHP 8 support
bob closed D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 13:50
bob committed rP8876f75fbb99: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Aug 18 2023, 13:50
bob added a comment to D25403: Improve CelerityDarkModePostprocessor shade colors.

Ouch ! Thanks for reporting ! I'll have a look on UI examples (these pages are really cool !) to improve the proposal !
BTW, I'll be away next week so... This will not move forward right now...

Aug 18 2023, 10:51
bob closed D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 10:48
bob closed T15609: PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 18 2023, 10:48 · PHP 8 support
bob closed T15609: PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer as Resolved by committing rP6ec89e9f0866: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 10:48 · PHP 8 support
bob committed rP6ec89e9f0866: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Aug 18 2023, 10:48
bob added a comment to D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Great, let's prepare for landing ! BTW, I like your images, espacially this one...

Aug 18 2023, 10:47
bob closed T15605: PHP 8.1 "strlen(null)" exception when deploying a new instance of Phorge, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 18 2023, 07:20 · PHP 8 support
bob closed T15605: PHP 8.1 "strlen(null)" exception when deploying a new instance of Phorge as Resolved by committing rP0ef08baf6452: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 07:20 · PHP 8 support
bob closed D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 18 2023, 07:20
bob committed rP0ef08baf6452: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Aug 18 2023, 07:20
bob closed D25401: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument.
Aug 18 2023, 07:20
bob committed rP7f46a252f21e: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument.
Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument
Aug 18 2023, 07:20
bob added a comment to D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Great news ! I'll land it right now !

Aug 18 2023, 07:16

Aug 17 2023

bob created T15612: Missing "Authored on" commit date for Subversion commits.
Aug 17 2023, 13:25 · User-valerio.bozzolan, Diffusion, Bug Reports
bob added a comment to D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Revision has been updated. Any idea why tests/lint were skipped ?

Aug 17 2023, 12:00
bob updated the diff for D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Updating D25394: Simplify base_uri variable check

Aug 17 2023, 11:58
bob updated the task description for T15056: Improve Dark Mode.
Aug 17 2023, 11:17 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
bob closed D25402: Fix hovercard background color when using Dark Mode.
Aug 17 2023, 11:17
bob committed rP7cffe557ac24: Fix hovercard background color when using Dark Mode.
Fix hovercard background color when using Dark Mode
Aug 17 2023, 11:17
bob updated the summary of D25403: Improve CelerityDarkModePostprocessor shade colors.
Aug 17 2023, 11:15
bob requested review of D25403: Improve CelerityDarkModePostprocessor shade colors.
Aug 17 2023, 11:10
bob added a revision to T15056: Improve Dark Mode: D25403: Improve CelerityDarkModePostprocessor shade colors.
Aug 17 2023, 11:10 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
bob added a comment to D25394: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

IMO, this depends on the objective of this check, I mean, does this check aim to verify if this parameter is defined or does it aim to verify if this parameter looks valid...
Maybe I'm wrong but I guess that the first option was in mind here else a regex would probable be a better approach since the "1" would be considered as a valid URI whereas "0" would not...

Aug 17 2023, 09:42
bob added a comment to D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Several ideas/leads about the fact you cannot reproduce :

Aug 17 2023, 09:27
bob updated the task description for T15056: Improve Dark Mode.
Aug 17 2023, 09:22 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
bob requested review of D25402: Fix hovercard background color when using Dark Mode.
Aug 17 2023, 09:21
bob updated the task description for T15056: Improve Dark Mode.
Aug 17 2023, 09:01 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
bob requested review of D25401: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument.
Aug 17 2023, 08:53
bob closed T15598: PHP 8.2 : rtrim(): Passing null to parameter #1 ($string) of type string is deprecated when checking notification servers as Resolved by committing rP747d7db24161: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Aug 17 2023, 08:41 · PHP 8 support
bob closed T15598: PHP 8.2 : rtrim(): Passing null to parameter #1 ($string) of type string is deprecated when checking notification servers, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 17 2023, 08:41 · PHP 8 support
bob closed D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Aug 17 2023, 08:41
bob committed rP747d7db24161: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument
Aug 17 2023, 08:41
bob added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.

As a minion, I'm only working for the glory of my boss ! :P

Aug 17 2023, 08:41
bob closed D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
Aug 17 2023, 08:32
bob committed rP17befe9bca5b: Fix source code viewer background color when using Dark Mode in Diffusion.
Fix source code viewer background color when using Dark Mode in Diffusion
Aug 17 2023, 08:31
bob updated the diff for D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.

Updating D25399: Reverting formatUser method prototype

Aug 17 2023, 08:26
bob added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.

Thanks for the patch suggestion ! Then we can :

Aug 17 2023, 08:20
bob closed T15607: PHP 8.2 "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated" in diffusion as Resolved by committing rPa5d8b2d5cfd6: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument.
Aug 17 2023, 08:17 · PHP 8 support
bob closed T15607: PHP 8.2 "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated" in diffusion, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 17 2023, 08:17 · PHP 8 support
bob closed D25397: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument.
Aug 17 2023, 08:17
bob committed rPa5d8b2d5cfd6: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument.
Fix a PHP 8.1 deprecated use of preg_match with a NULL argument
Aug 17 2023, 08:16

Aug 16 2023

bob requested review of D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 16 2023, 16:17
bob added a revision to T15610: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer: D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 16 2023, 16:17 · PHP 8 support
bob requested review of D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 16 2023, 16:05
bob added a revision to T15609: PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer: D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 16 2023, 16:05 · PHP 8 support
bob created T15610: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer.
Aug 16 2023, 15:56 · PHP 8 support
bob created T15609: PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer.
Aug 16 2023, 15:48 · PHP 8 support
bob added a revision to T15608: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in subversion repository: D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 16 2023, 15:44 · PHP 8 support
bob updated the summary of D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 16 2023, 15:44
bob requested review of D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Aug 16 2023, 15:38
bob created T15608: PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in subversion repository.
Aug 16 2023, 15:23 · PHP 8 support
bob updated the diff for D25397: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument.

I removed another diff's modification included by Arcanist (there is definitely something about arc command that I'm missing...)

Aug 16 2023, 15:18
bob requested review of D25397: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument.
Aug 16 2023, 15:15
bob added a revision to T15607: PHP 8.2 "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated" in diffusion: D25397: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument.
Aug 16 2023, 15:15 · PHP 8 support
bob created T15607: PHP 8.2 "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated" in diffusion.
Aug 16 2023, 14:56 · PHP 8 support
bob updated the task description for T15056: Improve Dark Mode.
Aug 16 2023, 14:51 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
bob added a comment to T15056: Improve Dark Mode.

When an fatal exception is triggered :

Aug 16 2023, 14:51 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
bob updated the summary of D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
Aug 16 2023, 14:50
bob added a comment to T15056: Improve Dark Mode.

Because there are more and more referenced issues and, because some of them may need further discussion in order to find the best solution, IMHO it may be a good idea to create a sub task for each issue reported isn't it ?

Aug 16 2023, 14:46 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
bob updated the task description for T15056: Improve Dark Mode.
Aug 16 2023, 14:44 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
bob updated the diff for D25396: Fix source code viewer background color when using Dark Mode in Diffusion.

Updating D25396: Include updated celerity map file

Aug 16 2023, 14:43
bob requested review of D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
Aug 16 2023, 14:41
bob updated the test plan for D25393: Fix answer background color when using Dark Mode in Ponder.
Aug 16 2023, 14:38
bob added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.

I was updating the diff when I saw below that function getWebsocketURI may also be affected by a NULL issue :

Aug 16 2023, 12:53
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0