Page MenuHomePhorge
Feed All Stories

Fri, Oct 18

aklapper closed D25815: Bump PHP version requirement from 5.2.3 to 7.2.25.
Fri, Oct 18, 12:20
aklapper committed rP23a49eb403c9: Bump PHP version requirement from 5.2.3 to 7.2.25.
Bump PHP version requirement from 5.2.3 to 7.2.25
Fri, Oct 18, 12:20
s.quinn added a comment to Q153: php-fpm memory leak.

What is the normal memory usage for the update daemon during the repository update? It seems to be peaking around 8GB per process for our repositories. Maybe I need to add more RAM, i.e. 32 GB to satisfy this, but that's not easy on AWS.

Fri, Oct 18, 11:19
s.quinn updated the answer details for Q153: php-fpm memory leak (Answer 195).
Fri, Oct 18, 11:13
avivey added a comment to Q153: php-fpm memory leak.

Repository update is based on how recent the last commit is, but that's only for collecting the list of commits to analyze.
But that should be done in the Daemons, which should at least recover nicely and not break the web side of the application. I don't know if they should be running as php or php-fpm.

Fri, Oct 18, 06:44

Thu, Oct 17

s.quinn updated the answer details for Q153: php-fpm memory leak (Answer 195).
Thu, Oct 17, 15:22
s.quinn added a comment to Q153: php-fpm memory leak.

OK, not the monitoring issue.

Thu, Oct 17, 15:22
s.quinn updated the answer details for Q153: php-fpm memory leak (Answer 195).
Thu, Oct 17, 15:02
s.quinn added Q153: php-fpm memory leak (Answer 195).
Thu, Oct 17, 15:02
s.quinn reopened Q153: php-fpm memory leak.
Thu, Oct 17, 14:56
nhg159083 added a watcher for Trusted Contributors: nhg159083.
Thu, Oct 17, 13:25

Wed, Oct 16

Iniquity added a comment to Update From Phabricator.

@Iniquity - Problem solved by removing that sentence lol - thanks. Now seems super-freshy

Thanks! :)

Wed, Oct 16, 09:35
valerio.bozzolan added a comment to D25773: Fix submitting forms in a new tab using Ctrl+Return.

@BlankEclair Do you want a little help to land this?

Wed, Oct 16, 09:25
valerio.bozzolan added a comment to Update From Phabricator.

@Iniquity - Problem solved by removing that sentence lol - thanks. Now seems super-freshy

Wed, Oct 16, 09:08
valerio.bozzolan edited the content of Update From Phabricator.
Wed, Oct 16, 09:08
valerio.bozzolan added a member for Trusted Contributors: bojan.
Wed, Oct 16, 08:53
valerio.bozzolan edited the content of Update From Phabricator.
Wed, Oct 16, 08:52
bojan added a comment to Update From Phabricator.

Arcanist is misspelled as "Archanist" in the 3rd step of "Updating" section.

Wed, Oct 16, 08:41
valerio.bozzolan added Q157: Retrieving task comments using conduit (Answer 194).
Wed, Oct 16, 07:36
sicenul asked Q157: Retrieving task comments using conduit.
Wed, Oct 16, 07:19
sicenul attached a referenced file: F195188: image.png.
Wed, Oct 16, 07:11

Oct 15 2024

avivey created Blog Post: 2024 Summer Edition.
Oct 15 2024, 16:48
avivey edited the content of Change Log.
Oct 15 2024, 16:42
avivey committed rPd3c0a7edc3fc: Promote 2024.35 to stable.
Promote 2024.35 to stable
Oct 15 2024, 16:42
avivey committed rARC05abd055019c: Promote 2024.35 to stable.
Promote 2024.35 to stable
Oct 15 2024, 16:37
valerio.bozzolan added a comment to T15949: Herald comment attributed to the wrong user in email notifications.

Uh! Out of curiosity, what does the notification look like in your web notifications?

Oct 15 2024, 06:52 · Herald, Maniphest
valerio.bozzolan added a member for Trusted Contributors: keithzg.
Oct 15 2024, 06:51
keithzg closed Q147: How does one get the value of a custom field in a custom field extension? as resolved.
Oct 15 2024, 04:15 · Maniphest
keithzg added a comment to Q147: How does one get the value of a custom field in a custom field extension? (Answer 183).

Okay, I got it! For future reference if anyone in a similar situation is stumbling across this and wants a fully working example to go off of, my more-than-a-little-cargo-culted code is currently:

Oct 15 2024, 04:15

Oct 14 2024

keithzg added a comment to Q147: How does one get the value of a custom field in a custom field extension? (Answer 183).

Many thanks, @20after4! That all largely did it; in addition to setting up the object a bit wrong (I knew it was a ManiphestTask instance, but was failing to get the actual object of it), I was also just using essentially my:custom-field rather than std:maniphest:my:custom-field.

Oct 14 2024, 23:07
Tgr updated the task description for T15949: Herald comment attributed to the wrong user in email notifications.
Oct 14 2024, 19:10 · Herald, Maniphest
Tgr created T15949: Herald comment attributed to the wrong user in email notifications.
Oct 14 2024, 19:09 · Herald, Maniphest
s.quinn closed Q153: php-fpm memory leak as invalid.
Oct 14 2024, 13:44
s.quinn added a comment to Q153: php-fpm memory leak.

Appears to be internal monitoring software causing this (not phorge), thanks for the replies.

Oct 14 2024, 13:43
valerio.bozzolan closed Q156: How to support project commercialy? as resolved.
Oct 14 2024, 13:25
valerio.bozzolan updated the answer details for Q156: How to support project commercialy? (Answer 193).
Oct 14 2024, 13:24
valerio.bozzolan added a member for Trusted Contributors: syncer.
Oct 14 2024, 13:13
valerio.bozzolan added Q156: How to support project commercialy? (Answer 193).
Oct 14 2024, 07:16

Oct 10 2024

syncer updated the question details for Q156: How to support project commercialy?.
Oct 10 2024, 23:09
syncer asked Q156: How to support project commercialy?.
Oct 10 2024, 22:48
sirocyl added a comment to T15630: Fix Fonts.

Noting a user complaint (I'm using a mildly hacked-up Phorge to host https://blog.styx-os.org/ - but the font stack is unchanged): https://fe.disroot.org/objects/5d376f6a-0acc-44fc-bd37-31de8630b647

Oct 10 2024, 09:21
avivey awarded T15948: Allow public API access when equivalent public web access exists a Like token.
Oct 10 2024, 06:54 · Conduit, Phorge

Oct 9 2024

20after4 added a comment to T15947: Add method to query if user is member of a list of projects.

Maybe express it as allowed by Policy xxx? (Related to T15277)

Oct 9 2024, 18:23 · Feature Requests
20after4 added a comment to T15947: Add method to query if user is member of a list of projects.

So essentially this:

Oct 9 2024, 18:17 · Feature Requests
20after4 added a comment to T15948: Allow public API access when equivalent public web access exists.

If I were starting today I would probably design the back-end APIs first, then make the web interface derive from those APIs, such that web requests and api requests are not really any different, at least with regard to enforcing access controls.

Oct 9 2024, 18:07 · Conduit, Phorge
valerio.bozzolan awarded T15948: Allow public API access when equivalent public web access exists a Mountain of Wealth token.
Oct 9 2024, 14:56 · Conduit, Phorge
fgaz created T15948: Allow public API access when equivalent public web access exists.
Oct 9 2024, 14:25 · Conduit, Phorge
avivey added a comment to T15947: Add method to query if user is member of a list of projects.

Maybe express it as allowed by Policy xxx? (Related to T15277)

Oct 9 2024, 10:29 · Feature Requests
aklapper created T15947: Add method to query if user is member of a list of projects.
Oct 9 2024, 09:46 · Feature Requests
valerio.bozzolan edited the content of 2024 week 35.
Oct 9 2024, 09:36
aklapper closed T15944: RuntimeException passing a bogus "service" URL parameter to Diffusion commit view as Resolved by committing rPb0bf1c689a9d: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit….
Oct 9 2024, 09:19
aklapper closed D25826: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit view.
Oct 9 2024, 09:19
aklapper committed rPb0bf1c689a9d: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit….
Avoid RuntimeException passing bogus "service" parameter to Diffusion commit…
Oct 9 2024, 09:19
aklapper added a comment to T15944: RuntimeException passing a bogus "service" URL parameter to Diffusion commit view.

No clue :)

Oct 9 2024, 09:17
valerio.bozzolan added a comment to D25827: Allow zooming on pages.

P.S. maybe relevant - maybe not :D lol https://we.phorge.it/T15945#19568

Oct 9 2024, 08:26
20after4 accepted D25826: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit view.
Oct 9 2024, 08:07
20after4 awarded D25826: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit view a Yellow Medal token.
Oct 9 2024, 08:07
20after4 awarded D25827: Allow zooming on pages a Yellow Medal token.
Oct 9 2024, 08:06
20after4 accepted D25827: Allow zooming on pages.

This one seems worthy of a rubber stamp. And a gold star.

Oct 9 2024, 08:05
20after4 updated the answer details for Q155: Is there a way to add new tokens? (Answer 192).
Oct 9 2024, 08:03
20after4 added Q155: Is there a way to add new tokens? (Answer 192).
Oct 9 2024, 08:00
20after4 added a comment to Q153: php-fpm memory leak.

Are you importing some huge git repo or something? I haven't seen a lot of OOM with php-fpm on phorge/phabricator. It's generally not been an issue in the past so this is either a new bug or something specific to the environment. Then again, I've almost always ran Phorge with much more than 8GB of ram available.

Oct 9 2024, 07:50
20after4 added a comment to Q147: How does one get the value of a custom field in a custom field extension? (Answer 183).

For another example, here is a fairly straightforward use of that API which takes place entirely outside of a custom field subclass:

Oct 9 2024, 07:41
20after4 added a comment to Q147: How does one get the value of a custom field in a custom field extension? (Answer 183).

There is a pretty complicated and not really easy to follow subclass of ManiphestCustomField over here: https://phabricator.wikimedia.org/source/phab-extensions/browse/wmf%252Fstable/src/customfields/ReleaseDetailsCustomField.php

Oct 9 2024, 07:33
20after4 added a comment to Q147: How does one get the value of a custom field in a custom field extension? (Answer 183).

@keithzg what you might be missing is

$object = $this->getObject()
Oct 9 2024, 07:31
20after4 updated subscribers of T15501: Voluntary Usage Survey App.

There is a significant amount of Phabricator dark matter out there - companies/people using the software, it works well enough, not really easy to know they exist or anything about their usage. I'm sure at least some of them have moved to Phorge. Automattic/wordpress.com have moved to Phorge and I wasn't even aware that they were using Phabricator before that. This is despite the fact that I did a pretty extensive amount of research to identify every company using Phabricator back in ~2019 as part of my work for Wikimedia, with the goal of reaching out and trying to organize an informal Phabricator users group. We had the idea that the various corporate users probably had good reasons to be collaborating and at least talking to each other since most of them were not active in the upstream project. Anyway, that never really panned out, although it did trigger a flurry of interest and some ongoing discussions via email (maybe even one video meeting but I can't remember the details now.)

Oct 9 2024, 07:16 · Discussion Needed

Oct 8 2024

fgaz created T15946: Support downloading a compressed working copy (tar/zip) of a repository at a specific ref (commit, branch, or tag).
Oct 8 2024, 17:14 · Diffusion, Phorge
valerio.bozzolan added a comment to T15944: RuntimeException passing a bogus "service" URL parameter to Diffusion commit view.

Any guess about a supposed right value for service? lol Just for my curiosity

Oct 8 2024, 12:12

Oct 2 2024

valerio.bozzolan added a comment to T15945: Allow zooming Phorge pages on mobile.

Just talking about accessibility, maybe interesting, Wikipedia on mobile allows to scale, but setting a minimum and maximum scale:

Oct 2 2024, 14:47 · Accessibility
aklapper updated the summary of D25827: Allow zooming on pages.
Oct 2 2024, 12:45
aklapper requested review of D25827: Allow zooming on pages.
Oct 2 2024, 12:44
aklapper added a revision to T15945: Allow zooming Phorge pages on mobile: D25827: Allow zooming on pages.
Oct 2 2024, 12:44 · Accessibility
BlankEclair updated the answer wiki for Q155: Is there a way to add new tokens?.
Oct 2 2024, 11:53
BlankEclair added a comment to Q155: Is there a way to add new tokens? (Answer 191).

Thanks for the very detailed answer! I may or may not take a stab at this if the person who originally asked for it decides that this is worth the effort.

Oct 2 2024, 11:52
valerio.bozzolan updated the answer details for Q155: Is there a way to add new tokens? (Answer 191).
Oct 2 2024, 09:54
valerio.bozzolan updated the answer details for Q155: Is there a way to add new tokens? (Answer 191).
Oct 2 2024, 09:49
valerio.bozzolan added Q155: Is there a way to add new tokens? (Answer 191).
Oct 2 2024, 09:48
BlankEclair asked Q155: Is there a way to add new tokens?.
Oct 2 2024, 04:40

Oct 1 2024

aklapper created T15945: Allow zooming Phorge pages on mobile.
Oct 1 2024, 18:17 · Accessibility
aklapper added inline comments to D25825: Validate some user provided calendar query range dates.
Oct 1 2024, 15:19
aklapper added a comment to D25738: Avoid RuntimeException on "Skip past this commit" when commit still importing.

Stumbled upon https://we.phorge.it/rP95e179d9a4f31b8c5c2cbb4db8f7fa9f2d3867d6 which also mentions

We may not have a commit object for a given identifier if the commit has not imported yet.

So this can indeed happen.

Oct 1 2024, 15:12
aklapper requested review of D25826: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit view.
Oct 1 2024, 15:10
aklapper added a revision to T15944: RuntimeException passing a bogus "service" URL parameter to Diffusion commit view: D25826: Avoid RuntimeException passing bogus "service" parameter to Diffusion commit view.
Oct 1 2024, 15:10
aklapper created T15944: RuntimeException passing a bogus "service" URL parameter to Diffusion commit view.
Oct 1 2024, 14:35

Sep 30 2024

valerio.bozzolan added a comment to Q153: php-fpm memory leak.

free -h ?

Sep 30 2024, 14:30
aklapper closed T15836: ArcanistHardpointTask calls non-existent constructor for ArcanistHardpointFutureList as Resolved by committing rARC285e31f4c743: Fix invalid constructor call for ArcanistHardpointFutureList.
Sep 30 2024, 13:36 · Arcanist
aklapper closed D25708: Fix invalid constructor call for ArcanistHardpointFutureList.
Sep 30 2024, 13:36
aklapper committed rARC285e31f4c743: Fix invalid constructor call for ArcanistHardpointFutureList.
Fix invalid constructor call for ArcanistHardpointFutureList
Sep 30 2024, 13:36
valerio.bozzolan closed Q154: Modifying Celerity postprocessors - is there a cache I should flush? as resolved.
Sep 30 2024, 11:29
sirocyl added Q154: Modifying Celerity postprocessors - is there a cache I should flush? (Answer 190).
Sep 30 2024, 09:08
sirocyl added a comment to Q154: Modifying Celerity postprocessors - is there a cache I should flush?.

Ah, hadn't even thought to check Developer Mode, I assumed I had it enabled. I did a "Purge Caches" from there and that didn't do anything, but turning devmode on did.

Sep 30 2024, 09:06
avivey added a comment to Q154: Modifying Celerity postprocessors - is there a cache I should flush?.

it might be in the APCu cache (https://we.phorge.it/config/cache/) - I'll try to check later. Also make sure you've set the Developer Mode in settings.

Sep 30 2024, 06:34
sirocyl asked Q154: Modifying Celerity postprocessors - is there a cache I should flush?.
Sep 30 2024, 01:11

Sep 28 2024

avivey added a comment to D25823: arc browse: add support to Subversion repos.

Ok, so --branch probably doesn't make much sense in that case, right.

Sep 28 2024, 18:58

Sep 26 2024

valerio.bozzolan added a comment to D25823: arc browse: add support to Subversion repos.

mm, isBranchJustFilesystemPath() makes more sense now, as in "the branch name is part of the URI path"...

Sep 26 2024, 14:54
avivey added a comment to D25823: arc browse: add support to Subversion repos.

mm, isBranchJustFilesystemPath() makes more sense now, as in "the branch name is part of the URI path"...

Sep 26 2024, 13:59
valerio.bozzolan added a comment to D25823: arc browse: add support to Subversion repos.

Maybe I should just try to improve the ArcanistRepositoryAPI#getDefaultBranch() 🤔 since the root problem is there, and the current solution just involves more code to avoid to fallback on that "master" default

Sep 26 2024, 09:54

Sep 25 2024

s.quinn added a comment to Q35: Does Phorge provide single sign-on to Microsoft Azure B2C? (Answer 53).

done

Sep 25 2024, 18:29
valerio.bozzolan updated the diff for D25823: arc browse: add support to Subversion repos.

move confusing comment

Sep 25 2024, 15:35
valerio.bozzolan added a comment to D25823: arc browse: add support to Subversion repos.

a. I'm not sure I like isBranchJustFilesystemPath() to check Is this SVN - if we're trying to be generic, then there may be a different vcs that does this particular trick, but has different logic; And if we're not trying to be generic, then isSVN() is probably a good-ish name? or isVCS('SVN').

Sep 25 2024, 15:29