This one seems worthy of a rubber stamp. And a gold star.

Are you importing some huge git repo or something? I haven't seen a lot of OOM with php-fpm on phorge/phabricator. It's generally not been an issue in the past so this is either a new bug or something specific to the environment. Then again, I've almost always ran Phorge with much more than 8GB of ram available.

For another example, here is a fairly straightforward use of that API which takes place entirely outside of a custom field subclass:

There is a pretty complicated and not really easy to follow subclass of ManiphestCustomField over here: https://phabricator.wikimedia.org/source/phab-extensions/browse/wmf%252Fstable/src/customfields/ReleaseDetailsCustomField.php

@keithzg what you might be missing is

$object = $this->getObject()

There is a significant amount of Phabricator dark matter out there - companies/people using the software, it works well enough, not really easy to know they exist or anything about their usage. I'm sure at least some of them have moved to Phorge. Automattic/wordpress.com have moved to Phorge and I wasn't even aware that they were using Phabricator before that. This is despite the fact that I did a pretty extensive amount of research to identify every company using Phabricator back in ~2019 as part of my work for Wikimedia, with the goal of reaching out and trying to organize an informal Phabricator users group. We had the idea that the various corporate users probably had good reasons to be collaborating and at least talking to each other since most of them were not active in the upstream project. Anyway, that never really panned out, although it did trigger a flurry of interest and some ongoing discussions via email (maybe even one video meeting but I can't remember the details now.)

Any guess about a supposed right value for service? lol Just for my curiosity

Just talking about accessibility, maybe interesting, Wikipedia on mobile allows to scale, but setting a minimum and maximum scale:

Thanks for the very detailed answer! I may or may not take a stab at this if the person who originally asked for it decides that this is worth the effort.

Stumbled upon https://we.phorge.it/rP95e179d9a4f31b8c5c2cbb4db8f7fa9f2d3867d6 which also mentions

We may not have a commit object for a given identifier if the commit has not imported yet.

So this can indeed happen.

free -h ?

Ah, hadn't even thought to check Developer Mode, I assumed I had it enabled. I did a "Purge Caches" from there and that didn't do anything, but turning devmode on did.

it might be in the APCu cache (https://we.phorge.it/config/cache/) - I'll try to check later. Also make sure you've set the Developer Mode in settings.

Ok, so --branch probably doesn't make much sense in that case, right.

In D25823#22041, @avivey wrote:

mm, isBranchJustFilesystemPath() makes more sense now, as in "the branch name is part of the URI path"...

mm, isBranchJustFilesystemPath() makes more sense now, as in "the branch name is part of the URI path"...

Maybe I should just try to improve the ArcanistRepositoryAPI#getDefaultBranch() 🤔 since the root problem is there, and the current solution just involves more code to avoid to fallback on that "master" default

done

move confusing comment

In D25823#22023, @avivey wrote:

a. I'm not sure I like isBranchJustFilesystemPath() to check Is this SVN - if we're trying to be generic, then there may be a different vcs that does this particular trick, but has different logic; And if we're not trying to be generic, then isSVN() is probably a good-ish name? or isVCS('SVN').

wow, it also makes sense to add --branch support to SVN! added

integrate tips

a. I'm not sure I like isBranchJustFilesystemPath() to check Is this SVN - if we're trying to be generic, then there may be a different vcs that does this particular trick, but has different logic; And if we're not trying to be generic, then isSVN() is probably a good-ish name? or isVCS('SVN').

Visit this page: https://we.phorge.it/F2517458 and Edit thanks

How do I do that?

Note that I introduced the method isBranchJustFilesystemPath() that returns something different for Subversion, just to recognize Subversion,

(Please mark the file as visible to everybody - thanks)

We have a working solution. Attached. Problem is it needs the BaseURI hard coding (replaced ours with XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX in the attached code). Can anyone merge this into the baseline code?

1. List Item

Nice test plan thanks

Sounds good! It's about what I expected, really.
(I did set up an experimental install on a whim, with the repository on-disk being (symlinked to) the root of the running install, and arcanist wasn't happy landing changes to it, probably for good reason heh.)

Uh, looking at line 112, the return status seems correct and expected. I had not seen that first. Thanks for fixing the constructor.

Basically, premising that the constructor of newFromFutures() seems legit, it's not clear to me why its return result should make sense and be compatible with the expected one. If somebody can clarify this, maybe it's at least something more.

In general the reporter should really find a small way to reproduce their problem, also because among all the things written here (https://we.phorge.it/book/contrib/article/bug_reports/), everybody may agree with the first point:

So this patch which changes (and hopefully also fixes) definitely broken code will be blocked for good due to lack of a test plan (which I won't be able to figure out)?
Or does anyone can come up with any other option?

Going to abandon for now as I'm not convinced either that this is something worth to change only to make PHPStan happier.
Note that https://we.phorge.it/book/libphutil/function/assert_instances_of/ might be an option when/if I want to look into this again at some future point.

Hello boz,

Slam-accept

Dear arp, please clone and hack a lot on Phorge :) Thanks and feel free to share any question

What's the status of this one? Just curious if we should fork and hack around it ourselves for now or if it's coming soon.

Don't create an empty title array when there is no $query_text

Uhhh you found the place where the empty array comes from! <3 I failed!