Small recap:

I can confirm that the change fixes the exception locally on git master for me. Thanks!

All three changes superseded by D25250 in my understanding. If not, then please reopen. Thanks!

It might not happen on any other card, because we might not be rendering Remarkup on any other card. Interesting....

So this is quite an edge-case:

• PhabricatorMentionRemarkupRule wants to give the mention a different color, depending on if the user can view the "context object", in this case the Project.
• There's an automatic rule, saying a member of a project can always view the project
• When loading the project for the hovercard, we don't bother loading all the member list
• When loading the user for the mention, we don't bother loading all its projects
• so data is not available at the rendering point.

nice, tyty

swap cases - thanks @speck - please double-accept if this is what was suggested :D

I prefer to invert the logic and return early, to avoid having the entire function contents inside a nested level - up to you but this looks good.

simplified logic - thanks @speck

DisableUsernameEditEventListener.php is the root cause.

Another good simple candidate GDPR-friendly:

I flag this as resolved since Code Differences between Phabricator and Phorge solves the problem at the moment. Also because there are no changes in upstream since 2023.

Premising that we may want to rollback 328aee033fbd, probably this line is broken:

Ouch. Probably partially my fault. Feel free to escalate this as Task under Bug Reports - close this as obsolete then

I can't immediately reproduce with that version either. I'll try again later.
In the meanwhile:

• Try clearing your browser's cache
• Try updating Phorge to the latest commit
• Try disabling this extension: assets/DisableUsernameEditEventListener.php

Implement the actual deep clone

I can reproduce this on master with basically any string search.

https://we.phorge.it just works fine. :L

2. Phorge installation

I can't reproduce this.
Which version of phorge/arc do you have (git log -1)?
How did you install the new Instance?

Interesting. This cannot be reproduced here in this website https://we.phorge.it? isn't it? I think no

:p

(Please edit file Visibility to make them Public :D It's another bug ihih - thanks! <3)

remove unrelated stuff

The exception throw out when I search text in search bar:

Please also include your exact search. I think you are searching by https://foo and that is unfortunately not possible without "doing this"

Ouch

update testplan

fix linting issues

Continued work, now using proper transactions and beeing able to copy comments

So I got this mostly working locally, it's actually fairly trivial to reuse the existing token storage and infrastructure. Actually displaying the tokens might not be the most efficient of operations when there are a lot of comments on a given object. I still need to write an optimized query to fetch all of the token given in one query rather than many and then figure out how to display the tokens inline with the comments.

Thanks for your answer. Yes, the restart item on the Build Plan display is also wrong then.