Premising that we invested so much efforts in over-engineering this stuff, and premising that this is objectively good:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
May 20 2023
Allowing extensions to override things, but, stop replacing user input just to show weird errors (and log instead)
I discussed with aklapper and, hoping to be useful to save the time of this precious contributor, I will update with the patch that we have seen together in live during Wikimedia Hackaton (so you don't need to amend and etc.)
Premising I very like the strategy in this patch that is "don't parse unuseful stuff" in order to "don't suppress weird errors", so, causing to preserve the user input.
Apparently we need some time on this little puppy class
add a bit of inline documentation with what I've understood so far
Thanks for this patch and for our live ping-pong
whops, remove my newline
applied a proposed amend after discussing with the kind @aklapper
I was a bit suspicious about Conduit API possibilities (https://we.phorge.it/conduit/method/maniphest.edit/) and I was able to cause a crash with a numerical point like 2 via JSON:
Tested locally following the test plan and something more, no nuclear implosions expected (as I usual say, but this time should be true - as I usual say, but really, this should not cause implosions)
amend small stuff proposed in person to the kind @aklapper
By coincidence, chatting with valerio.bozzolan yesterday made me realize that this rendering rule is merely in place for figlet and cowsay.
Hoping to be useful I will land this approved change in 7 days if the original author can't :) Thanks again
Thanks again for this patch
Thanks for this Task
Thanks for this patch also from me and for your changes
Keep yum included
Thanks - small tip here
Thanks again :)
- small indentation fix
Use minimal fix instead
Thanks again for this patch! Tested locally with and without an "enroll message".
Do you like this patch? :)
May 19 2023
In D25203#6703, @valerio.bozzolan wrote:I'm not bold enough to approve as O1 since they would probably like to keep the "yum" stuff or at least mention both for legacy reasons
In D25120#6777, @valerio.bozzolan wrote:(Ufff I'm always super-hiped when I see "Accepted" in the email notification... but then I realize it's not from Blessed Committers 🥺 What a difficult world for us #PuppyCommitters.)
(it works indeed, so no need from me to red block)
In D25120#6771, @bfs wrote:Makes sense to me, as it mirrors the way the persistent chat tab/box itself is hidden in durable-column.css:
.device .conpherence-durable-column, .printable .conpherence-durable-column, !print .conpherence-durable-column { display: none; }
Yep I confirm my opinion here, let's ping-pong this tomorrow
Makes sense to me, as it mirrors the way the persistent chat tab/box itself is hidden in durable-column.css:
Thanks for this patch (again)!
Just as a proof of concept, now it works:
Thanks for the suggestion, I like this really much more