Page MenuHomePhorge
Feed All Stories

May 20 2023

valerio.bozzolan accepted D25234: Fix exception and error message rendering some markup matching figlet/cowsay regex.

Premising that we invested so much efforts in over-engineering this stuff, and premising that this is objectively good:

May 20 2023, 20:16
valerio.bozzolan updated the summary of D25234: Fix exception and error message rendering some markup matching figlet/cowsay regex.
May 20 2023, 20:13
valerio.bozzolan updated the name of F293294: Phorge Cowsay Figlet showcase.png from "Screenshot_2023_05_20_221216.png" to "Phorge Cowsay Figlet showcase.png".
May 20 2023, 20:13
valerio.bozzolan updated the summary of D25234: Fix exception and error message rendering some markup matching figlet/cowsay regex.
May 20 2023, 20:05
valerio.bozzolan updated the diff for D25234: Fix exception and error message rendering some markup matching figlet/cowsay regex.

Allowing extensions to override things, but, stop replacing user input just to show weird errors (and log instead)

May 20 2023, 19:49
valerio.bozzolan added a comment to D25234: Fix exception and error message rendering some markup matching figlet/cowsay regex.

I discussed with aklapper and, hoping to be useful to save the time of this precious contributor, I will update with the patch that we have seen together in live during Wikimedia Hackaton (so you don't need to amend and etc.)

May 20 2023, 19:48
valerio.bozzolan added a comment to D25234: Fix exception and error message rendering some markup matching figlet/cowsay regex.

Premising I very like the strategy in this patch that is "don't parse unuseful stuff" in order to "don't suppress weird errors", so, causing to preserve the user input.

May 20 2023, 18:30
valerio.bozzolan requested changes to D25234: Fix exception and error message rendering some markup matching figlet/cowsay regex.

Apparently we need some time on this little puppy class

May 20 2023, 18:27
valerio.bozzolan closed T15315: Fix PHP 8.1 exception from DarkConsole: strlen(): Passing null to parameter #1 ($string) of type string is deprecated, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
May 20 2023, 17:18 · PHP 8 support
valerio.bozzolan closed T15315: Fix PHP 8.1 exception from DarkConsole: strlen(): Passing null to parameter #1 ($string) of type string is deprecated as Resolved by committing rPc1c7699c9891: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole.
May 20 2023, 17:18 · DarkConsole, PHP 8 support
valerio.bozzolan closed D25165: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole.
May 20 2023, 17:18
valerio.bozzolan committed rPc1c7699c9891: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole.
Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole
May 20 2023, 17:18
avivey accepted D25165: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the DarkConsole.
May 20 2023, 17:12
valerio.bozzolan updated the diff for D25222: Fix PHP 8.1 "strlen(null)" exception setting Story Points on a Task.

add a bit of inline documentation with what I've understood so far

May 20 2023, 16:07
valerio.bozzolan accepted D25222: Fix PHP 8.1 "strlen(null)" exception setting Story Points on a Task.

Thanks for this patch and for our live ping-pong

May 20 2023, 16:07
valerio.bozzolan retitled D25222: Fix PHP 8.1 "strlen(null)" exception setting Story Points on a Task from Fix PHP 8.1 "strlen(null)" exception setting story points on a task
May 20 2023, 16:01
valerio.bozzolan updated the diff for D25222: Fix PHP 8.1 "strlen(null)" exception setting Story Points on a Task.

whops, remove my newline

May 20 2023, 15:59
valerio.bozzolan updated the diff for D25222: Fix PHP 8.1 "strlen(null)" exception setting Story Points on a Task.

applied a proposed amend after discussing with the kind @aklapper

May 20 2023, 15:58
aklapper closed D25179: Fix PHP 8.1 null parameter exceptions which block rendering the "Browse Projects" overlay dialog.
May 20 2023, 15:49
aklapper committed rP524dc83b4e8c: Fix PHP 8.1 null parameter exceptions which block rendering the "Browse….
Fix PHP 8.1 null parameter exceptions which block rendering the "Browse…
May 20 2023, 15:49
aklapper closed D25203: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.
May 20 2023, 15:47
aklapper closed T15352: Remove outdated PHP version suffixes in package names on "Missing Required Extensions" and replace yum with dnf as Resolved by committing rP17ebf3a11fb5: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.
May 20 2023, 15:47 · Good Starter Task, Config
aklapper committed rP17ebf3a11fb5: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.
Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf
May 20 2023, 15:47
valerio.bozzolan requested changes to D25222: Fix PHP 8.1 "strlen(null)" exception setting Story Points on a Task.

I was a bit suspicious about Conduit API possibilities (https://we.phorge.it/conduit/method/maniphest.edit/) and I was able to cause a crash with a numerical point like 2 via JSON:

May 20 2023, 15:47
aklapper closed T15406: PHP Fatal error in Figlet due to use of curly braces, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
May 20 2023, 15:43 · PHP 8 support
aklapper closed T15406: PHP Fatal error in Figlet due to use of curly braces as Resolved by committing rPf97c9d68d031: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces.
May 20 2023, 15:43 · PHP 8 support
aklapper closed D25233: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces.
May 20 2023, 15:43
aklapper committed rPf97c9d68d031: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces.
Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces
May 20 2023, 15:43
valerio.bozzolan updated the test plan for D25222: Fix PHP 8.1 "strlen(null)" exception setting Story Points on a Task.
May 20 2023, 15:41
valerio.bozzolan accepted D25179: Fix PHP 8.1 null parameter exceptions which block rendering the "Browse Projects" overlay dialog.

Tested locally following the test plan and something more, no nuclear implosions expected (as I usual say, but this time should be true - as I usual say, but really, this should not cause implosions)

May 20 2023, 15:37
valerio.bozzolan updated the diff for D25179: Fix PHP 8.1 null parameter exceptions which block rendering the "Browse Projects" overlay dialog.

amend small stuff proposed in person to the kind @aklapper

May 20 2023, 15:34
aklapper added a comment to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php).

By coincidence, chatting with valerio.bozzolan yesterday made me realize that this rendering rule is merely in place for figlet and cowsay.

May 20 2023, 15:33 · Bug Reports
aklapper requested review of D25234: Fix exception and error message rendering some markup matching figlet/cowsay regex.
May 20 2023, 15:31
aklapper added a revision to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php): D25234: Fix exception and error message rendering some markup matching figlet/cowsay regex.
May 20 2023, 15:31 · Bug Reports
valerio.bozzolan added a comment to D25025: Unify user-select CSS directives.

Hoping to be useful I will land this approved change in 7 days if the original author can't :) Thanks again

May 20 2023, 15:28
valerio.bozzolan updated the test plan for D25233: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces.
May 20 2023, 15:16
valerio.bozzolan accepted D25233: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces.

Thanks again for this patch

May 20 2023, 15:16
valerio.bozzolan accepted D25203: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.
May 20 2023, 15:08
valerio.bozzolan added a comment to T15407: People: profile picture should be editable by their author (not by "No one").

Thanks for this patch

May 20 2023, 14:34 · User-valerio.bozzolan, People
valerio.bozzolan awarded T15407: People: profile picture should be editable by their author (not by "No one") a Doubloon token.
May 20 2023, 14:23 · User-valerio.bozzolan, People
albertoleoncio created T15407: People: profile picture should be editable by their author (not by "No one").
May 20 2023, 14:23 · User-valerio.bozzolan, People
valerio.bozzolan added a member for Trusted Contributors: albertoleoncio.
May 20 2023, 14:22
valerio.bozzolan accepted D25203: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.

Thanks for this patch also from me and for your changes

May 20 2023, 14:00
jgleeson changed the visibility for F293235: Screenshot from 2023-05-20 15-56-17.png.
May 20 2023, 13:06
jgleeson accepted D25203: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.

I've tested this locally and can see the new dnf install command

Screenshot from 2023-05-20 15-56-17.png (1×1 px, 212 KB)

May 20 2023, 12:58
valerio.bozzolan updated the summary of D25203: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.
May 20 2023, 12:56
valerio.bozzolan retitled D25203: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf from Remove PHP version suffixes on "Missing Required Extensions"; Replace yum with dnf
May 20 2023, 12:55
aklapper requested review of D25233: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces.
May 20 2023, 12:50
aklapper added a revision to T15406: PHP Fatal error in Figlet due to use of curly braces: D25233: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces.
May 20 2023, 12:50 · PHP 8 support
valerio.bozzolan added a member for Trusted Contributors: jgleeson.
May 20 2023, 12:47
aklapper updated the task description for T15406: PHP Fatal error in Figlet due to use of curly braces.
May 20 2023, 12:46 · PHP 8 support
aklapper updated the task description for T15406: PHP Fatal error in Figlet due to use of curly braces.
May 20 2023, 12:44 · PHP 8 support
aklapper created T15406: PHP Fatal error in Figlet due to use of curly braces.
May 20 2023, 12:40 · PHP 8 support
aklapper closed T15376: PHP 8.1 "ltrim(null)" exception blocks adding additional user email address, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
May 20 2023, 12:27 · PHP 8 support
aklapper closed T15376: PHP 8.1 "ltrim(null)" exception blocks adding additional user email address as Resolved by committing rP94d45de2f7dd: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email….
May 20 2023, 12:27 · PHP 8 support
aklapper closed D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.
May 20 2023, 12:27
aklapper committed rP94d45de2f7dd: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email… (authored by valerio.bozzolan).
Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email…
May 20 2023, 12:27
aklapper updated the diff for D25203: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.

Keep yum included

May 20 2023, 12:22
valerio.bozzolan added a comment to D25229: Fix PHP 8.1 "explode(null)" exception which blocks rendering "Provide Multi-Factor Credentials" page.

Thanks - small tip here

May 20 2023, 12:16
valerio.bozzolan accepted D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.

Thanks again :)

May 20 2023, 12:03
valerio.bozzolan updated the summary of D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.
May 20 2023, 12:02
valerio.bozzolan updated the diff for D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.
  • small indentation fix
May 20 2023, 11:58
aklapper updated the diff for D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.

Use minimal fix instead

May 20 2023, 09:53
aklapper closed T15386: PHP 8.1 "strlen(null)" exception blocks rendering MFA Provider page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
May 20 2023, 09:48 · PHP 8 support
aklapper closed T15386: PHP 8.1 "strlen(null)" exception blocks rendering MFA Provider page as Resolved by committing rP1b905706b450: Fix PHP 8.1 "strlen(null)" exception which blocks rendering MFA Provider page.
May 20 2023, 09:48 · PHP 8 support
aklapper closed D25218: Fix PHP 8.1 "strlen(null)" exception which blocks rendering MFA Provider page.
May 20 2023, 09:48
aklapper committed rP1b905706b450: Fix PHP 8.1 "strlen(null)" exception which blocks rendering MFA Provider page.
Fix PHP 8.1 "strlen(null)" exception which blocks rendering MFA Provider page
May 20 2023, 09:48
aklapper closed T15391: PHP 8.1 "strlen(null)" exception blocks task Bulk Editor page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
May 20 2023, 09:46 · PHP 8 support
aklapper closed T15391: PHP 8.1 "strlen(null)" exception blocks task Bulk Editor page as Resolved by committing rPbff0f810a7d8: Fix PHP 8.1 "strlen(null)" exception which blocks task Bulk Editor page.
May 20 2023, 09:46 · PHP 8 support
aklapper closed D25223: Fix PHP 8.1 "strlen(null)" exception which blocks task Bulk Editor page.
May 20 2023, 09:46
aklapper committed rPbff0f810a7d8: Fix PHP 8.1 "strlen(null)" exception which blocks task Bulk Editor page.
Fix PHP 8.1 "strlen(null)" exception which blocks task Bulk Editor page
May 20 2023, 09:46
aklapper closed D25232: PhabricatorPhabricatorAuthProvider: Remove unnecessary Remarkup.
May 20 2023, 09:43
aklapper committed rP44f2010a0b60: PhabricatorPhabricatorAuthProvider: Remove unnecessary Remarkup.
PhabricatorPhabricatorAuthProvider: Remove unnecessary Remarkup
May 20 2023, 09:43
valerio.bozzolan accepted D25218: Fix PHP 8.1 "strlen(null)" exception which blocks rendering MFA Provider page.

Thanks again for this patch! Tested locally with and without an "enroll message".

May 20 2023, 08:16
valerio.bozzolan updated the name of F293147: MFA Frontend message.png from "Screenshot_2023_05_20_101523.png" to "MFA Frontend message.png".
May 20 2023, 08:16
valerio.bozzolan added a comment to D25206: Fix PHP 8.1 "strlen(null)" exception from ArcanistRefView which blocks "arc look remotes".

Do you like this patch? :)

May 20 2023, 07:22

May 19 2023

bfs added a comment to D25203: Remove PHP version suffixes on "Missing Required Extensions"; Mention dnf.

I'm not bold enough to approve as O1 since they would probably like to keep the "yum" stuff or at least mention both for legacy reasons

May 19 2023, 23:59
bfs added a comment to D25120: Mobile: hide unuseful "Persistent Chat" checkbox.

(Ufff I'm always super-hiped when I see "Accepted" in the email notification... but then I realize it's not from Blessed Committers 🥺 What a difficult world for us #PuppyCommitters.)

May 19 2023, 23:36
bfs created Image Macro "makeitso".
May 19 2023, 23:35
valerio.bozzolan resigned from D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.

(it works indeed, so no need from me to red block)

May 19 2023, 23:11
valerio.bozzolan added a comment to D25120: Mobile: hide unuseful "Persistent Chat" checkbox.
In D25120#6771, @bfs wrote:

Makes sense to me, as it mirrors the way the persistent chat tab/box itself is hidden in durable-column.css:

.device .conpherence-durable-column,
.printable .conpherence-durable-column,
!print .conpherence-durable-column {
  display: none;
}
May 19 2023, 23:08
valerio.bozzolan requested changes to D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.
May 19 2023, 23:03
valerio.bozzolan added a comment to D25210: Fix PHP 8.1 "ltrim(null)" exception which blocks adding additional user email address.

Yep I confirm my opinion here, let's ping-pong this tomorrow

May 19 2023, 23:03
valerio.bozzolan triaged T15405: Slowvote Application: allow to change the Creation Policy (Default Edit Policy) as Wishlist priority.
May 19 2023, 23:01 · User-valerio.bozzolan, Policy, Affects-Wikimedia
valerio.bozzolan edited the content of Why Migrate from Phabricator to Phorge.
May 19 2023, 22:50
bfs accepted D25120: Mobile: hide unuseful "Persistent Chat" checkbox.

Makes sense to me, as it mirrors the way the persistent chat tab/box itself is hidden in durable-column.css:

May 19 2023, 22:37
valerio.bozzolan moved T15405: Slowvote Application: allow to change the Creation Policy (Default Edit Policy) from Backlog to Code Sprint Candidate on the User-valerio.bozzolan board.
May 19 2023, 22:35 · User-valerio.bozzolan, Policy, Affects-Wikimedia
valerio.bozzolan added a project to T15405: Slowvote Application: allow to change the Creation Policy (Default Edit Policy): User-valerio.bozzolan.
May 19 2023, 22:35 · User-valerio.bozzolan, Policy, Affects-Wikimedia
valerio.bozzolan created T15405: Slowvote Application: allow to change the Creation Policy (Default Edit Policy).
May 19 2023, 22:23 · User-valerio.bozzolan, Policy, Affects-Wikimedia
valerio.bozzolan added inline comments to D25224: Fix PHP 8.1 "trim(null)" exception which blocks rendering Reports' Burnup Rate page.
May 19 2023, 22:15
valerio.bozzolan closed T15404: PhabricatorController: fix Caption (can be a string but also PhutilSafeHTML) causing error in PhabricatorPhabricatorAuthProvider, a subtask of T15279: PHP 8.1 "strlen(null)" exceptions block rendering the Account Creation page after installation, as Resolved.
May 19 2023, 20:17
valerio.bozzolan closed T15404: PhabricatorController: fix Caption (can be a string but also PhutilSafeHTML) causing error in PhabricatorPhabricatorAuthProvider as Resolved by committing rP976a21f6584b: AphrontFormControl: fix regression for some specific Captions.
May 19 2023, 20:17 · Bug Reports, User-valerio.bozzolan
valerio.bozzolan closed D25231: AphrontFormControl: fix regression for some specific Captions.
May 19 2023, 20:17
valerio.bozzolan committed rP976a21f6584b: AphrontFormControl: fix regression for some specific Captions.
AphrontFormControl: fix regression for some specific Captions
May 19 2023, 20:17
avivey accepted D25231: AphrontFormControl: fix regression for some specific Captions.
May 19 2023, 19:49
valerio.bozzolan updated the test plan for D25223: Fix PHP 8.1 "strlen(null)" exception which blocks task Bulk Editor page.
May 19 2023, 19:10
valerio.bozzolan accepted D25223: Fix PHP 8.1 "strlen(null)" exception which blocks task Bulk Editor page.

Thanks for this patch (again)!

May 19 2023, 19:06
valerio.bozzolan added a comment to D25231: AphrontFormControl: fix regression for some specific Captions.

Just as a proof of concept, now it works:

May 19 2023, 18:38
valerio.bozzolan updated the name of F292987: Phorge Auth fixed.png from "Screenshot_2023_05_19_203351.png" to "Phorge Auth fixed.png".
May 19 2023, 18:37
valerio.bozzolan added a comment to D25231: AphrontFormControl: fix regression for some specific Captions.

Thanks for the suggestion, I like this really much more

May 19 2023, 18:36