Page MenuHomePhorge
Differential D25233

Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces
ClosedPublic
Actions

Authored by aklapper on May 20 2023, 12:50.
Tags
None
Referenced Files
F4045985: D25233.1746736943.diff
Wed, May 7, 20:42
F4045984: D25233.1746736942.diff
Wed, May 7, 20:42
F4034106: D25233.1746717142.diff
Wed, May 7, 15:12
F4024734: D25233.1746680827.diff
Wed, May 7, 05:07
F3991342: D25233.1746591926.diff
Tue, May 6, 04:25
F3991340: D25233.1746591924.diff
Tue, May 6, 04:25
F3991256: D25233.1746591623.diff
Tue, May 6, 04:20
F3984040: D25233.1746568322.diff
Mon, May 5, 21:52
View All 67 Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15406: PHP Fatal error in Figlet due to use of curly braces
Commits
rPf97c9d68d031: Fix PHP 8.1 Fatal error in Figlet: Use square brackets instead of curly braces
Summary

Replace curly with square brackets when accessing an array value. See
https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-string-access-curly-brace
https://wiki.php.net/rfc/deprecate_curly_braces_array_access#wasn_t_the_curly_brace_syntax_deprecated_once_before

Closes T15406

Test Plan

Fixed these two lines; afterwards Figlet rendered in task comment preview. Example figlet:

figlet {{{ stuff }}}

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSizePackages
externals/
pear-figlet/
Text/
4 linesO1: Blessed Committers

Diff 763

View Options

externals/pear-figlet/Text/Figlet.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0