In D25966#25739, @bekay wrote:

First of all: you should create the copy button server side. Ideally inside the remark rule for creating a code block. There you can attach the ressources too. And you can add sigils to the button. Javelin uses sigils to attach behaviors and listen to events.

javascript replaced with javelin stuff

@bekay
I tried to use JX.Stratcom.listen but I ran into the following issues:

• I couldn't use mouseenter and mouseleave events for some reason
• when using mousedown in combination with an a-tag with href=#, I don't know how to convert e.preventDefault. e.prevent() didn't work the same

Comments from z1 chat:

ES5 compatibility issues fixed

This looks very pro !

sorry for the late reply.
This looks good to me.

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

Those were just for the looks, but this is of course personal.
I can remove them if you want.

Width overflow fixed

Updating D25790: Make table of contents visible when using wide screens

Update after comments

Updates after comments

Updates after comments

Thanks

In D25709#19616, @valerio.bozzolan wrote:

P.S. Why does Phriction have the field text_metadata? And why does Conpherence have content_metadata? 🤔

In D25705#19508, @valerio.bozzolan wrote:

OK try this to restore your desired situation (so, two diffs)

git stash save

git checkout -b just_phriction
git reset --hard origin/master
arc patch --nobranch --diff 2173
arc diff --update D25705

git checkout -b just_conpherence
git reset --hard origin/master
arc patch --nobranch --diff 2178
arc diff --create

Then you have this benefit that you can repeat as many times you want:

git checkout just_phriction
LOL DO CHANGES
arc diff

git checkout just_conpherence
LOL DO CHANGES
arc diff

Or, get fresh master again:

git checkout master

Ideally, the default assumes that people do not touch master but work in branches, each branch a different feature

In D25705#19485, @valerio.bozzolan wrote:

(Do you need a little help to split the changes in two diffs?)

Updates after comments

Fix file attachment in Conpherence

Update after comments

Updates after comments

Updates after comments

it works indeed for editing Maniphest tasks but not for Phriction documents.
I have been analyzing this "attach code" but it's too complex for me.
It seems that the content_metadata (with the attachedFilePHIDs) is correctly sent by the javascript, but it's not processed in the PHP, which makes it not attach the file object to the wiki page.

Make the Remarkup Help Page Extensible

Make the Remarkup Help Page Extensible

Make the Remarkup Help Page Extensible

I did not add a real index page.
The remarkup reference acts a bit as index page as cowsay and figlet references are referenced in here as hyperlinks.

Make the Remarkup Help Page Extensible

Make the Remarkup Help Page Extensible

I don't understand what happened here?
I only had these files changed/added:

• src/applications/reference/src/application/ReferenceApplication.php
• src/applications/reference/src/controller/CowayReferenceController.php
• src/applications/reference/src/controller/FigletReferenceController.php
• src/applications/reference/src/controller/ReferenceController.php
• src/applications/reference/src/controller/RemarkupReferenceController.php
• src/infrastructure/markup/interface/RemarkupSyntaxDocumentationProvider.php
• src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
• src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php
• src/view/form/control/PhabricatorRemarkupControl.php

Updating D25693: Conduit API: allow phriction.edit to modify viewPolicy and editPolicy