In T15583#13304, @avivey wrote:

go for it.

There may already be a feature somewhere to automatically trigger a re-index because the code changed - I'll try to look for one this week.

edit: looks like it's just "add an autopatch" like resources/sql/autopatches/20191028.uriindex.01.rebuild.php. No worries.

Okay, my proposal:

Okay, I have tried to wrap my head around the ferret engine. Problem is: the repo callsign is not part of the indexed material. So I would have to construct some query like (just a schema): WHERE ferret-query like '%term%' OR callsign like 'term%' - but that is not possible with the phabricator query engine. The ferret query parts are separatly created and every other where clause is merged with AND. I don't think, there is a clean way out of this. You could make TWO queries: The old one and one with the ferret engine. And then merge the results and remove doubles. But I don't know... just doesn't feel right.

In T15583#13296, @avivey wrote:

I suspect that the code in People is the oldest one - this stuff blames to 2011! and does explicit sql stuff!

I have searched through the code a little bit and there is another system for typeahaed results. It is token based. So, how does it work?

There is no ferret involved in my fix. I have already implemented it in our company instance and the devs are loving it. The change is in this line: https://we.phorge.it/source/phorge/browse/master/src/applications/repository/query/PhabricatorRepositoryQuery.php$650

No interest in this? I can send a diff to differential and be mauled there 🦁

Just to illustrate my point - here are the repositories of phorge: https://we.phorge.it/diffusion/

Okay, now how do I land this? Just arc land? Again, in my current setup there is no way of unit testing, so I don't know if it is possible...

Optimizes querying of project edges of multiple documents.

Complete some issues.

Remove count.

In D25303#10634, @valerio.bozzolan wrote:

Probably, the tags, if present, should be listed as last entry. I suggest this since it's an info of variable-length, that is probably better in the footer.

I hope, this is now ready to land... sorry for the long delay 😅

Fix linting problem.

Use willRenderHovercards() to get all project and ancestor handles of potential multiple documents and rewrites inline SQL query.

In D25303#9015, @avivey wrote:

Showing project tags might be unique to tasks - Revisions don't show them, and neither do Owners or Commits. It might make sense not to show it here either.

Fixed the indentation and @valerio.bozzolan should now see the breadcrumb. But even if all else fails, at least Wiki Document will be rendered...

Builds celerity map.

Fixes missing ancestors and css indentation.

In D25303#8985, @valerio.bozzolan wrote:

Nice!

I don't have any idea about the homepage, but having no parents leave the icon alone in a row now, to me:

@speck Did that!

My new proposal:

Moves parent document links to top (merging them with always visible link of wiki homepage) and project tags to extra paragraph.

I think the current revision is a good compromise. The current behavior makes no sense from the perspective of modern UX patterns:

In D25303#8876, @speck wrote:

I like this idea. A few things I want to note

1. Could you post a screenie for what the breadcrumb rendering appears as?
2. Does the name of this new class follow other classes that extend the hierarchy? I’m guessing yes but just want to double-check.
3. Maniphest tasks will render their primary Space (assuming non-default) as a prefix to the title. I think wiki docs should do similar.
4. Do wiki docs have a description field?

In D25303#8804, @valerio.bozzolan wrote:

I wonder if other Hovercards have a quantitative limitation on things like Tags, to be used as additional inspiration

Small style changes.

Okay, this would be the new hovercard:

Here is pretty complete list of dark mode fails from the creator himself: https://secure.phabricator.com/T13540

I can try to make a patch, if there is some code contributuon guide and nobody else is willing to resolve this issue. I know I have to add patches with arcanist - but that's all 😓

T15433: Hovercard of wiki article needs more information

What version of Phabricator/Phorge do you use? Version information can be found under your-phorge-domain.org/config/.

In T15034#2338, @Ekubischta wrote:

Hit esc today - Lost lots of typing

Just an upvote for landing D25015

The clone repo modal could really use some copy buttons.

Then maybe just show the monogram when logged in.