Page MenuHomePhorge
Feed Advanced Search

Thu, Nov 28

aklapper closed T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)" as Resolved by committing rPa68b8daafde3: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
Thu, Nov 28, 11:41 · Herald

Tue, Nov 26

aklapper updated the task description for T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)".
Tue, Nov 26, 18:39 · Herald

Oct 23 2024

aklapper closed T15949: Herald comment attributed to the wrong user in email notifications as Invalid.
Oct 23 2024, 14:09 · Herald, Maniphest

Oct 21 2024

aklapper added a comment to T15949: Herald comment attributed to the wrong user in email notifications.

The email body says Herald added a comment.
The email subject line header says [Changed Project Column] (not [Commented On]).
So I wouldn't say it is incorrectly attributed.
AFAIK there are no Herald rules which trigger a separate email notification on its own (but I agree that the described behavior also has confused me in the past) as Herald rules are always triggered by some other previous action.

Oct 21 2024, 16:50 · Herald, Maniphest

Oct 15 2024

valerio.bozzolan added a comment to T15949: Herald comment attributed to the wrong user in email notifications.

Uh! Out of curiosity, what does the notification look like in your web notifications?

Oct 15 2024, 06:52 · Herald, Maniphest

Oct 14 2024

Tgr updated the task description for T15949: Herald comment attributed to the wrong user in email notifications.
Oct 14 2024, 19:10 · Herald, Maniphest
Tgr created T15949: Herald comment attributed to the wrong user in email notifications.
Oct 14 2024, 19:09 · Herald, Maniphest

Aug 19 2024

valerio.bozzolan added a parent task for T15869: Herald rule referring to a disabled rule silently fails: T15921: Easy way to find broken Herald Rule(s).
Aug 19 2024, 13:01 · Herald
valerio.bozzolan added a parent task for T15885: Herald rule referring to an invalid key silently fails: T15921: Easy way to find broken Herald Rule(s).
Aug 19 2024, 13:01 · Herald
valerio.bozzolan added subtasks for T15921: Easy way to find broken Herald Rule(s): T15887: Herald rule referring to a non-existing action silently fails, T15885: Herald rule referring to an invalid key silently fails, T15869: Herald rule referring to a disabled rule silently fails.
Aug 19 2024, 13:01 · Herald
valerio.bozzolan added a parent task for T15887: Herald rule referring to a non-existing action silently fails: T15921: Easy way to find broken Herald Rule(s).
Aug 19 2024, 13:01 · Herald
valerio.bozzolan created T15921: Easy way to find broken Herald Rule(s).
Aug 19 2024, 13:00 · Herald

Aug 4 2024

aklapper renamed T15885: Herald rule referring to an invalid key silently fails from Fail more verbosely in Herald rules for invalid keys to Herald rule referring to an invalid key silently fails.
Aug 4 2024, 09:32 · Herald

Aug 2 2024

pppery added a project to T15885: Herald rule referring to an invalid key silently fails: Herald.
Aug 2 2024, 18:57 · Herald
pppery added a project to T15887: Herald rule referring to a non-existing action silently fails: Herald.
Aug 2 2024, 18:57 · Herald

Jul 21 2024

aklapper added a revision to T15869: Herald rule referring to a disabled rule silently fails: D25736: Log Herald rules having disabled Herald rules as condition via phlog().
Jul 21 2024, 17:21 · Herald
aklapper added a comment to T15869: Herald rule referring to a disabled rule silently fails.

Ahh but Transcripts do render an exception when it fails at least. I get a HeraldInvalidConditionException printing Invalid Condition: Condition references a rule which does not exist!, triggered in HeraldAdapter::doesConditionMatch() (only if you reach that condition in the evaluation of course, because https://we.phorge.it/source/phorge/browse/master/src/applications/herald/engine/HeraldEngine.php$437-445 ).
That's called in HeraldEngine in the line $is_match = $adapter->doesConditionMatch (note that class also has a method with the very same name).

Jul 21 2024, 17:17 · Herald

Jul 19 2024

aklapper added a comment to T15869: Herald rule referring to a disabled rule silently fails.

Uhmm, transcripts at http://phorge.localhost/herald/transcript/33065/ never ever render a Herald rule condition (disabled or not) within another rule, it seems

Jul 19 2024, 16:05 · Herald

Jun 27 2024

avivey created T15869: Herald rule referring to a disabled rule silently fails.
Jun 27 2024, 10:26 · Herald

Jun 21 2024

pppery added a project to T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)": Herald.
Jun 21 2024, 21:49 · Herald

May 12 2024

avivey added a comment to T15176: Evaluate a global Herald Maniphest action: "Block Task creation with message" (to allow custom Task constraints).

On a more meta level, Maniphest isn't well-suited to be an entry-form to be filled by a non-expert user; Nuance is/was intended for this use-case.

May 12 2024, 14:05 · Herald, Maniphest, User-valerio.bozzolan
avivey added a comment to T15176: Evaluate a global Herald Maniphest action: "Block Task creation with message" (to allow custom Task constraints).

on the technical level, Herald can't block object creation - it runs after the fact, by the Daemons.

May 12 2024, 14:03 · Herald, Maniphest, User-valerio.bozzolan
aklapper added a comment to T15176: Evaluate a global Herald Maniphest action: "Block Task creation with message" (to allow custom Task constraints).

I don't believe in playing whack-a-mole on "could this be a password" but a use case I've been recently thinking of is "Do not allow task creation when task content/data is exactly the defaults provided by the Form used to create the task". Basically: You were supposed to fill in some stuff but you did not when creating your task.

May 12 2024, 13:03 · Herald, Maniphest, User-valerio.bozzolan

Jun 23 2023

valerio.bozzolan added a project to T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool: Bug Reports.
Jun 23 2023, 15:26 · Bug Reports, Affects-Wikimedia, Herald

Jun 12 2023

valerio.bozzolan moved T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool from Backlog to Bug Reports on the Affects-Wikimedia board.
Jun 12 2023, 19:51 · Bug Reports, Affects-Wikimedia, Herald
aklapper closed T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool as Resolved by committing rP54ee51d7abd0: Work around exception in Herald transcript of old tasks: Call to a member….
Jun 12 2023, 19:49 · Bug Reports, Affects-Wikimedia, Herald
aklapper added a comment to T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool.

@valerio.bozzolan Thanks a lot for your help, debugging, deeper investigation! Resolving.

Jun 12 2023, 19:49 · Bug Reports, Affects-Wikimedia, Herald

Jun 7 2023

avivey closed Q56: Herald runs even for non-permanent refs as resolved.
Jun 7 2023, 07:39 · Bug Reports, Herald
smith added a comment to T15449: Herald commit hooks run for non-published refs.

Just trying to convince you.
If the feature works, it adds functionality that can't be easily replicated. You can have a bunch of complex Herald rules and bypass them all just by declaring that ^temp/ refs are now non-permanent. If the feature doesn't work (or maybe doesn't exist, rather), you have to go to each Herald rule and explicitly exclude ^temp/ branches, which is a lot of work for something that (at least for me) looks like it should be simple.

Jun 7 2023, 07:38 · Herald, Bug Reports
avivey added a comment to T15449: Herald commit hooks run for non-published refs.

I'm not, personally, 100% convinced that the hooks should be blocked from running on these refs - there's plenty of edge-cases where this might be even more confusing (commits can become published in a bunch of ways).

Jun 7 2023, 07:33 · Herald, Bug Reports
avivey created T15449: Herald commit hooks run for non-published refs.
Jun 7 2023, 07:31 · Herald, Bug Reports

May 26 2023

aklapper added a revision to T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool: D25246: Work around exception in Herald transcript of old tasks: Call to a member function getAppliedTransactionPHIDs() on bool.
May 26 2023, 14:28 · Bug Reports, Affects-Wikimedia, Herald
aklapper added a comment to T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool.

I could reproduce this locally:

  1. As an admin, go to http://phorge.localhost/herald/create/
  2. Select "Maniphest Tasks"
  3. On http://phorge.localhost/herald/create/?adapter=HeraldManiphestTaskAdapter , select "Global Rule"
  4. Under "Conditions", select any of and set the three conditions Description | contains | Internet Archive, Description | contains | archive.org, Description | contains | Wayback Machine.
  5. Under "Action", select Add projects | someProject
  6. Select "Save Rule"
  7. Trigger the rule by creating a new task.
  8. Wait, wait, and wait, then look at the Herald Transcript linked from the task.
May 26 2023, 14:26 · Bug Reports, Affects-Wikimedia, Herald

May 22 2023

smith asked Q56: Herald runs even for non-permanent refs.
May 22 2023, 09:33 · Bug Reports, Herald

May 8 2023

avivey renamed T15369: Clarify the "Do nothing" Herald Action from Clarify the "Do nothing" Herald rule to Clarify the "Do nothing" Herald Action.
May 8 2023, 12:42 · Herald
valerio.bozzolan updated the task description for T15369: Clarify the "Do nothing" Herald Action.
May 8 2023, 12:39 · Herald
valerio.bozzolan updated the task description for T15369: Clarify the "Do nothing" Herald Action.
May 8 2023, 12:31 · Herald
valerio.bozzolan triaged T15369: Clarify the "Do nothing" Herald Action as Low priority.
May 8 2023, 12:29 · Herald
valerio.bozzolan added a project to T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool: Affects-Wikimedia.
May 8 2023, 12:25 · Bug Reports, Affects-Wikimedia, Herald

May 5 2023

aklapper closed T15348: PHP 8.1 "strlen(null)" exception blocks creating personal and global Herald rules as Resolved by committing rPb0044bad621b: Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global….
May 5 2023, 10:53 · Herald, PHP 8 support

May 4 2023

aklapper added a revision to T15348: PHP 8.1 "strlen(null)" exception blocks creating personal and global Herald rules: D25190: Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules.
May 4 2023, 20:25 · Herald, PHP 8 support
aklapper created T15348: PHP 8.1 "strlen(null)" exception blocks creating personal and global Herald rules.
May 4 2023, 20:24 · Herald, PHP 8 support
valerio.bozzolan updated the task description for T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool.
May 4 2023, 15:09 · Bug Reports, Affects-Wikimedia, Herald
valerio.bozzolan triaged T15343: Herald Transcript of old Tasks: Unhandled Exception: Call to a member function getAppliedTransactionPHIDs() on bool as Wishlist priority.
May 4 2023, 15:08 · Bug Reports, Affects-Wikimedia, Herald

May 1 2023

valerio.bozzolan added a comment to T15176: Evaluate a global Herald Maniphest action: "Block Task creation with message" (to allow custom Task constraints).

It's unclear to me whenever Wikimedia needs this. If yes, feel free to also mark as Affects-Wikimedia. This is probably their use case: https://phabricator.wikimedia.org/T332639

May 1 2023, 10:42 · Herald, Maniphest, User-valerio.bozzolan

Apr 26 2023

valerio.bozzolan updated the task description for T15280: Herald object Diffusion Commit: allow to add a Tag.
Apr 26 2023, 15:28 · User-valerio.bozzolan, Herald, Diffusion

Apr 6 2023

valerio.bozzolan edited projects for T15184: Herald: fix Back button on Object view, added: Herald; removed Herald (archived).
Apr 6 2023, 12:01 · Herald, User-valerio.bozzolan
avivey edited projects for T15211: Evaluate Herald rule "Add Project" also for Personal uses, added: Herald; removed Herald (archived).
Apr 6 2023, 10:57 · Herald, User-valerio.bozzolan
avivey edited projects for T15176: Evaluate a global Herald Maniphest action: "Block Task creation with message" (to allow custom Task constraints), added: Herald; removed Herald (archived).
Apr 6 2023, 10:54 · Herald, Maniphest, User-valerio.bozzolan
avivey created Herald.
Apr 6 2023, 10:53