I mean. See this archived Project (archived Milestone), that is linked from our changelogs:

Premising that I like the implementation but I think it's not the desired solution.

Additional consideration under control: an external class may have extended AphrontTypeaheadTemplateView and defining a renderToken() there, and making this snippet operative (I'm not saying that it's a good practice, I'm saying that it would work). But this extreme corner case is not the case.

Seems super nice. Minor comment. If we do this, the stack trace is NOT shared:

Strip block

Marking as "probably something different should be done"

In short, requireFieldImplementation seems correct in their legacy version, and something is not ideal in the consumer, that has a try catch. That try-catch should be edited.

Note that every unmanaged exception is logged. So if you don't see a log, something is already managing this.

Unrelated but @aklapper I'm curious about the situation in WMF. If you can maybe report something like this:

• was this improving the situation? rPf4d9d6920bcd: The feed "created this task" should be the first one seems yes, accordingly to your comments
• was PhabricatorTransactions::TYPE_CREATE needing a nice action name? yes
• Am I confused about newActionStrengthSortVector? Yes. I don't know why it works, but it works. But this deserves further discussion.

OK I'm stupid. I just need to visit the Milestone and create a Workboard.

Seems that nothing internally accessed that method, and probably nothing externally. But we should probably keep that method since it's public. Thanks.

I was still able to generate QR codes, and I verified with alternative application "Barcode Scanner" that the desired URL is read.

Premising that the root problem is that it's difficult to understand if a project is archived just looking at other parts.

Thanks. Feature makes sense and implementation seems good (but I have untested).

git rebase master (again)

Sorry for waiting.

git rebase master

(↑ isn't this lovely? lol)

This is a low quality image that could be used by "fair use" as meme. Source:

Double-slam-accept! Thanks and happy landing

Yet another orphan method, it seems 🤔

lol

Test plan needed. But I don't know what an "hardpoint" is.

Thanks. I'm quite sure that everything is just calling writeCache().

Please wait at least for another +1, or, a week, before landing this. Since others may have different opinions on PhabricatorTransactions::findOneByType().

@avivey what do you think about a new silly commodity method PhabricatorTransactions::findOneByType(array, string) ?

Partially related to T15822: When a phriction page is moved, history should follow the page move

Or, to just download the current version of D25705 to eventually add some local extra changes, just:

If you would like to download the current version of D25705 to maybe land that, just:

OK. Giving that also the parent::save() will fail, I think yes, feel free to nuke this method to see what happens. lol

P.S. Why does Phriction have the field text_metadata? And why does Conpherence have content_metadata? 🤔

We can avoid phutil_nonempty_string() since PHP pitfalls "Check for non-empty strings" are under control here.

shorter like in D25705

It would be nice to understand why nothing calls save() 🤔 since I guess nothing calls it, or we would have a crash report.

OK. Well, thaanks \o/

I'm really impressed. Tested and it's super-nice, with implicit middle fingers pointed to JavaScript.

About this:

final defuser \o/ thanks

OK thanks! you persuaded me