Page MenuHomePhorge
Feed All Stories

All Stories
Use Results
Edit Query

Fri, May 16

aklapper added a comment to T16065: PHP Deprecation warnings in STDERR can make arc fail.

Reverting rARC29575b4f91876bf0a95739eba50f792e2aa78c0c and rP6619fef2ff977ea81092b970e58abbb33e78f644 makes Phorge throw errors again:
Firefox says This page is in Quirks Mode. Page layout may be impacted.,
Chromium says net::ERR_CONTENT_DECODING_FAILED 200 (OK)),
both because the deprecation warning is added before the usual HTML header created by AphrontPageView, as curl shows:

[acko@foo phorge (master *$|u=)]$ curl 'http://phorge.localhost'
<br />
<b>Deprecated</b>:  Constant E_STRICT is deprecated in <b>/var/www/html/phorge/phorge/support/startup/PhabricatorStartup.php</b> on line <b>391</b><br />
<!DOCTYPE html><html data-developer-mode="1"><head><meta charset="UTF-8" /><title>Home</title><meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=yes" /><link rel="mask-icon" color="#3D4B67" [...]

We don't end up calling PhutilErrorHandler::handleError() or PhutilErrorLog::onError() or PhutilSystem::writeStderr() here.

Fri, May 16, 12:14
dhinus updated the task description for T15828: "Any" & "Not In" query operators should also involve project's direct milestones.
Fri, May 16, 10:54 · Maniphest, Bug Reports
A_smart_kitten renamed T15828: "Any" & "Not In" query operators should also involve project's direct milestones from "Not In" query operator is not respected when searching for project milestones to "Any" & "Not In" query operators are not respected when searching for subprojects/milestones of a given project.
Fri, May 16, 10:25 · Maniphest, Bug Reports
A_smart_kitten added projects to T15828: "Any" & "Not In" query operators should also involve project's direct milestones: Bug Reports, Maniphest.

Gonna boldly call it a bug, given that I was about to file an upstream bug report for https://phabricator.wikimedia.org/T386830 before I came across this task :)

Fri, May 16, 10:21 · Maniphest, Bug Reports
valerio.bozzolan added a comment to D25872: Implements arc work for git workflow.

P.S. Uh, I noticed that arc work also has a --start parameter! I documented a bit the expected behavior in the task T15993.

Fri, May 16, 08:30
valerio.bozzolan added a comment to D25872: Implements arc work for git workflow.

Tested for T15100 and T15993 and I'm a bit surprised to obtain, this very long branch with commas and square brackets (and just the closing bracket? uhm)

Fri, May 16, 08:20
valerio.bozzolan updated the task description for T15993: Support for arc work T12345 (workOnTask workflow).
Fri, May 16, 08:06 · Arcanist
aklapper updated the task description for T16071: Avoid large layout shifts while page loading on mobile.
Fri, May 16, 07:52
valerio.bozzolan updated the summary of D25872: Implements arc work for git workflow.
Fri, May 16, 07:50
valerio.bozzolan updated the diff for D25872: Implements arc work for git workflow.
  • arc lint
  • arc unit
  • fix a couple of id($api) and just use $api
Fri, May 16, 07:44
aklapper created T16071: Avoid large layout shifts while page loading on mobile.
Fri, May 16, 07:38
valerio.bozzolan added a comment to T16070: Understand why Diffusion creates some orphan Files.

Do you know for sure (did Fabio explicitly say so)

Fri, May 16, 06:58 · User-valerio.bozzolan, Diffusion, Files
aklapper added a comment to T16070: Understand why Diffusion creates some orphan Files.

seems manually uploaded by an user, but it's not

Fri, May 16, 05:42 · User-valerio.bozzolan, Diffusion, Files

Thu, May 15

avivey uninstalled Nuance.
Thu, May 15, 18:09
valerio.bozzolan added a comment to T16070: Understand why Diffusion creates some orphan Files.

This is different than T15814: Files: reduce number of orphan transformed files

Thu, May 15, 12:29 · User-valerio.bozzolan, Diffusion, Files
valerio.bozzolan created T16070: Understand why Diffusion creates some orphan Files.
Thu, May 15, 12:01 · User-valerio.bozzolan, Diffusion, Files
aklapper closed D26011: Remove orphan CSS selectors in phui/phui-form-view.css.
Thu, May 15, 06:47
aklapper committed rPb51f3657000c: Remove orphan CSS selectors in phui/phui-form-view.css.
Thu, May 15, 06:47
aklapper updated the summary of D25772: Projects: improve quality of destroy workflow.
Thu, May 15, 06:47 · Projects

Wed, May 14

aklapper updated the diff for D26011: Remove orphan CSS selectors in phui/phui-form-view.css.

git rebase master

Wed, May 14, 22:35
aklapper closed D26010: Remove orphan CSS selectors in core/z-index.css.
Wed, May 14, 22:34
aklapper committed rP854dc7f3f503: Remove orphan CSS selectors in core/z-index.css.
Wed, May 14, 22:34
aklapper updated the diff for D26010: Remove orphan CSS selectors in core/z-index.css.

git rebase master

Wed, May 14, 22:33
aklapper committed rP44b33e6345c6: Remove orphan CSS selectors in phui/phui-remarkup-preview.css.
Wed, May 14, 22:20
aklapper closed D26012: Remove orphan CSS selectors in phui/phui-remarkup-preview.css.
Wed, May 14, 22:20
aklapper closed D26015: Remove orphan CSS selectors in phui/phui-lightbox.css.
Wed, May 14, 22:12
aklapper committed rP06cf73177919: Remove orphan CSS selectors in phui/phui-lightbox.css.
Wed, May 14, 22:12
valerio.bozzolan accepted D26011: Remove orphan CSS selectors in phui/phui-form-view.css.
Wed, May 14, 10:24
valerio.bozzolan accepted D26015: Remove orphan CSS selectors in phui/phui-lightbox.css.
Wed, May 14, 10:23
valerio.bozzolan accepted D26012: Remove orphan CSS selectors in phui/phui-remarkup-preview.css.
Wed, May 14, 10:17
valerio.bozzolan edited the content of Next Up.
Wed, May 14, 08:08
valerio.bozzolan closed T15541: "arc browse <file>" should support Subversion as Resolved by committing rARCc58c780b47ef: arc browse: add support for Subversion repos.
Wed, May 14, 08:04 · Feature Requests, Wikimedia Hackathon 2025, User-valerio.bozzolan, Arcanist
valerio.bozzolan closed D25823: arc browse: add support for Subversion repos.
Wed, May 14, 08:04 · Arcanist
valerio.bozzolan committed rARCc58c780b47ef: arc browse: add support for Subversion repos.
Wed, May 14, 08:04
valerio.bozzolan added a comment to D25823: arc browse: add support for Subversion repos.

OK, tested by 3 hackers, no git regressions, more SVN stability, more inline documentation, more abstraction, very Phorgi, already tracking follow-ups, yuuup

Wed, May 14, 08:04 · Arcanist
valerio.bozzolan added a comment to T15957: 'arc browse .' from the root of the project should work (at least in git and SVN).
In T15957#22436, @keithzg wrote:

Testing this a bit myself again, I discovered that actually this problem affects both Git and SVN

Wed, May 14, 07:15 · Bug Reports, Arcanist
valerio.bozzolan renamed T15957: 'arc browse .' from the root of the project should work (at least in git and SVN) from 'arc browse .' should work in git to 'arc browse .' from the root of the project should work (at least in git and SVN).
Wed, May 14, 07:14 · Bug Reports, Arcanist
keithzg added a comment to T15957: 'arc browse .' from the root of the project should work (at least in git and SVN).

Testing this a bit myself again, I discovered that actually this problem affects both Git and SVN, it just wasn't being noticed in my SVN testing because it doesn't go wrong if run from any subfolder. So for example in a checkout of rARC, running arc browse . in the root directory will pop one into the bogus path of, say, https://we.phorge.it/source/arcanist/browse/master/home/keithzg/Code/git/arcanist, but if I'm in my local ~/Code/git/arcanist/src/ then arc browse . pops open https://we.phorge.it/source/arcanist/browse/master/src as intended.

Wed, May 14, 07:13 · Bug Reports, Arcanist
keithzg accepted D25823: arc browse: add support for Subversion repos.

The only remaining issue I could find in retesting was that, when run on the root of a repo, apparently SVN exhibits the same behaviour as Git does in T15957; and furthermore in my testing actually Git also doesn't have that problem if arc browse . is run in a subfolder rather than the root of a repo. (It's just so much more common to be in the root of a Git repo, and so much less common to be in the true root of an SVN repo, that we didn't notice!)

Wed, May 14, 07:09 · Arcanist
Chlod added a comment to T16054: Conduit API transaction.search with objectType = XACT causes internal error "get_class() expects parameter 1 to be object, null given".

Thanks, @valerio.bozzolan! :D

Wed, May 14, 05:33 · Wikimedia Hackathon 2025, Conduit, Bug Reports

Tue, May 13

valerio.bozzolan created T16069: Mention all necessary/optional PHP extensions needed.
Tue, May 13, 23:16 · User-valerio.bozzolan, Documentation
valerio.bozzolan moved T16058: Workboard column triggers: Allow assigning to user performing the move from Backlog to We did it 😍 on the Wikimedia Hackathon 2025 board.
Tue, May 13, 21:24 · Wikimedia Hackathon 2025, Feature Requests
valerio.bozzolan moved T16057: Conduit transaction.search: document supported values for objectType from Plz Review 🥺 to We did it 😍 on the Wikimedia Hackathon 2025 board.
Tue, May 13, 21:23 · Wikimedia Hackathon 2025, Conduit
valerio.bozzolan moved T16054: Conduit API transaction.search with objectType = XACT causes internal error "get_class() expects parameter 1 to be object, null given" from Plz Review 🥺 to We did it 😍 on the Wikimedia Hackathon 2025 board.
Tue, May 13, 21:23 · Wikimedia Hackathon 2025, Conduit, Bug Reports
valerio.bozzolan added a comment to T16054: Conduit API transaction.search with objectType = XACT causes internal error "get_class() expects parameter 1 to be object, null given".

Thanks @Chlod for this bug report and please also enjoy T16057 and the new documentation table (D25988) that is provided to you for free :3

Tue, May 13, 20:41 · Wikimedia Hackathon 2025, Conduit, Bug Reports
valerio.bozzolan edited the content of Next Up.
Tue, May 13, 20:40
valerio.bozzolan edited the content of Next Up.
Tue, May 13, 20:34
valerio.bozzolan closed T16057: Conduit transaction.search: document supported values for objectType as Resolved by committing rP511379044d2b: transaction.search: add auto-generated documentation for objectType and handle….
Tue, May 13, 20:34 · Wikimedia Hackathon 2025, Conduit
valerio.bozzolan closed T16054: Conduit API transaction.search with objectType = XACT causes internal error "get_class() expects parameter 1 to be object, null given" as Resolved by committing rP511379044d2b: transaction.search: add auto-generated documentation for objectType and handle….
Tue, May 13, 20:34 · Wikimedia Hackathon 2025, Conduit, Bug Reports
valerio.bozzolan closed D25988: transaction.search: add auto-generated documentation for objectType and handle unmanaged exception.
Tue, May 13, 20:34
valerio.bozzolan committed rP511379044d2b: transaction.search: add auto-generated documentation for objectType and handle….
Tue, May 13, 20:34
valerio.bozzolan renamed T16054: Conduit API transaction.search with objectType = XACT causes internal error "get_class() expects parameter 1 to be object, null given" from transaction.search with XACT causes internal error to Conduit API transaction.search with objectType = XACT causes internal error "get_class() expects parameter 1 to be object, null given".
Tue, May 13, 20:33 · Wikimedia Hackathon 2025, Conduit, Bug Reports
avivey accepted D25988: transaction.search: add auto-generated documentation for objectType and handle unmanaged exception.
Tue, May 13, 14:40
avivey edited the content of Update From Phabricator.
Tue, May 13, 14:34
aklapper added a comment to D26020: Add workboard column trigger to assign only unassigned tasks.

That was my patch initially but it felt like too much duplicated code... I don't have a strong opinion though; I'm also fine with that other approach. :)

Tue, May 13, 13:33
valerio.bozzolan added a comment to D26020: Add workboard column trigger to assign only unassigned tasks.

I wonder if we should just extend PhabricatorProjectTriggerRule. So, leaving PhabricatorProjectTriggerManiphestOwnerRule as-is 🤔 any opinion about that?

Tue, May 13, 12:11
aklapper added a comment to D26020: Add workboard column trigger to assign only unassigned tasks.

What's the expectation for classes which have a child class extending them? Marking them as abstract though they are really not abstract at all? protected class? Uhm.

Tue, May 13, 11:42
aklapper requested review of D26020: Add workboard column trigger to assign only unassigned tasks.
Tue, May 13, 11:39
aklapper added a revision to T16064: New Column Trigger: Assign only unassigned tasks on move: D26020: Add workboard column trigger to assign only unassigned tasks.
Tue, May 13, 11:39 · Feature Requests
valerio.bozzolan edited the content of 2025.18.
Tue, May 13, 09:10
valerio.bozzolan edited the content of Next Up.
Tue, May 13, 08:51
valerio.bozzolan added a comment to D25988: transaction.search: add auto-generated documentation for objectType and handle unmanaged exception.

Better now, thanks again @avivey

Tue, May 13, 08:28
aklapper closed D26019: Add two trivial PHPDocs lines to PhabricatorTypeaheadDatasource.
Tue, May 13, 07:18
aklapper committed rP94a9724637ae: Add two trivial PHPDocs lines to PhabricatorTypeaheadDatasource.
Tue, May 13, 07:18
valerio.bozzolan accepted D26019: Add two trivial PHPDocs lines to PhabricatorTypeaheadDatasource.
Tue, May 13, 04:37

Mon, May 12

aklapper requested review of D26019: Add two trivial PHPDocs lines to PhabricatorTypeaheadDatasource.
Mon, May 12, 18:41
aklapper added a project to T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)": Bug Reports.
Mon, May 12, 18:35 · Bug Reports
aklapper created T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)".
Mon, May 12, 18:35 · Bug Reports

Sun, May 11

aklapper closed T15859: Set "preconnect" HTTP header when "security.alternate-file-domain" is set as Resolved by committing rP1f19cbf7486a: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
Sun, May 11, 07:27 · Wikimedia Hackathon 2025, Feature Requests
aklapper closed D25694: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
Sun, May 11, 07:27
aklapper committed rP1f19cbf7486a: Set "preconnect" HTTP header when "security.alternate-file-domain" is set.
Sun, May 11, 07:27

Sat, May 10

valerio.bozzolan accepted D25955: Unhandled Exception: Add last call to error message.

Tested right now. Unexpected pleasure! thanks! :3 :3

Sat, May 10, 18:54
aklapper requested review of D26018: Remove pre-2014 webfont formats (EOT, SVG, TTF).
Sat, May 10, 17:52
aklapper requested review of D26017: Remove orphan CSS selectors in diffusion/diffusion-*.css.
Sat, May 10, 12:15
aklapper requested review of D26016: Remove orphan CSS selectors in core/remarkup.css.
Sat, May 10, 12:12
aklapper requested review of D26015: Remove orphan CSS selectors in phui/phui-lightbox.css.
Sat, May 10, 11:51
aklapper updated the summary of D26011: Remove orphan CSS selectors in phui/phui-form-view.css.
Sat, May 10, 11:48
aklapper updated the summary of D26013: Remove orphan CSS selectors in phui/phui-crumbs-view.css.
Sat, May 10, 11:48
aklapper requested review of D26014: Remove orphan CSS selectors in phui/phui-document*.css.
Sat, May 10, 11:48
aklapper requested review of D26013: Remove orphan CSS selectors in phui/phui-crumbs-view.css.
Sat, May 10, 11:45
aklapper requested review of D26012: Remove orphan CSS selectors in phui/phui-remarkup-preview.css.
Sat, May 10, 11:40
aklapper requested review of D26011: Remove orphan CSS selectors in phui/phui-form-view.css.
Sat, May 10, 11:35
aklapper requested review of D26010: Remove orphan CSS selectors in core/z-index.css.
Sat, May 10, 11:25
aklapper created T16067: Uploaded image files after transformations become/remain public.
Sat, May 10, 10:38

Fri, May 9

mainframe98 accepted D25955: Unhandled Exception: Add last call to error message.
Fri, May 9, 17:37
taavi added projects to T16066: Unnecessary HTML escaping in plain-text email: Mail, Bug Reports.
Fri, May 9, 15:10 · Bug Reports, Mail
taavi created T16066: Unnecessary HTML escaping in plain-text email.
Fri, May 9, 15:09 · Bug Reports, Mail
valerio.bozzolan lowered the priority of T15160: The Feed should not display the old content of an edited Comment as default from Low to Wishlist.

Uhm this is a damn rabbit hole.

Fri, May 9, 14:53 · Feed, Comments, User-valerio.bozzolan
aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.

Fri, May 9, 13:10
aklapper requested review of D26009: Remove orphan CSS selectors in phui/phui-action-panel.css.
Fri, May 9, 13:02
aklapper requested review of D26008: Remove orphan CSS selectors in phui/phui-header-view.css.
Fri, May 9, 12:57
aklapper updated the summary of D26007: Remove unused CSS file aphront/panel-view.css.
Fri, May 9, 12:57
valerio.bozzolan added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

Maybe also we can drop something from ./webroot/rsrc/css/core/remarkup.css - since it seems to contain .aphront-panel-preview ( .aphront-panel-preview .phabricator-remarkup-mention-unknown)

Fri, May 9, 12:44
aklapper requested review of D26007: Remove unused CSS file aphront/panel-view.css.
Fri, May 9, 12:40
aklapper requested review of D26006: Remove unused FatCow icon files.
Fri, May 9, 11:17
aklapper updated the diff for D26005: Remove unused keyboard shortcuts code.

another round of bin/celerity map

Fri, May 9, 11:01
aklapper requested review of D26005: Remove unused keyboard shortcuts code.
Fri, May 9, 10:57
aklapper created T16065: PHP Deprecation warnings in STDERR can make arc fail.
Fri, May 9, 10:17
aklapper added a comment to D25955: Unhandled Exception: Add last call to error message.

I guess this welcomes another review / testing. Works fine here.™

Fri, May 9, 09:40
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Also update comment

Fri, May 9, 09:35
First
Prev
Next
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0