BTW - is something normalizing the header casing?

I'm not skilled enough to look into the bigger picture, however maybe the Edit Column dialog could have a third field apart from Name and Point Limit to also have Task Limit (or Card Limit?). Point Limit and Task Limit then must be mutually exclusive (do not allow to set both for a column, or even...board?), somehow.

Borrow a short sentence from Valerio as his English skills in the morning are much much better than mine

Thanks. Also please show to the end user the same number, using some semantic pirouettes. So this limit is easier to be found.

In D25737#20607, @avivey wrote:

I'm happy to log it, but I'm nos sure this counts as "fixes" the issue - it still requires an admin to monitor the logs.
But then maybe T15887 and its friends can be collected to a single common "more visibility for Herald errors" issue.

Move max task title length into a variable

Make the PHPDoc and the method name shamelessly admit its real intentions to the whole world out there

Correct off-by-one error :P

What Valerio says: Only render OGP tags for anonymous access to public objects; refactor

arc lint no check CSS syntax? Meh

Do whatever Valerio says!

Replace file icon with copy path button in file header bars

What about replacing that legacy "unuseful" file icon on the left, with your new copy-button?

• Split getting values and rendering meta tags into separate private methods
• Fix description length check

• Fix the $award_phids thingy to do the $award_phids[$phid] thing
• I prefer to keep if (!$errors) as that part of code is supposed to check for (any) errors

Before and after it throws an exception; after it involves the return command to do so.

Use canResolve() as found by Valerio (so much for my reading skills)

Could you try arc land instead of git push?

Too lazy, just doing the same as in rP43d3fd9eac6e8e44d8a60110d8ad6f01bb240979: Turn "Required" red after the first attempt

Rebase after merging rP59678094fb777aed3c3eb66e8075c082b3dc393f

Replying to a comment in Z1 from a week ago: When Phorge's curtain doesn't allow someone to access the content, it shows either a 404 ("Access Denied: Restricted Maniphest Task") or the login dialog. In both cases, no OGP meta tags are leaked.

Same results as Valerio after testing more. Also remove unused vars $title and $header_name - they are unused.

The $password variable is not a string anymore in the line after. I guess it's not much more expensive to check if the string $username is nonempty versus comparing to a boolean value

Quick notes:

• For testing code changes, make sure to ./bin/cache purge --caches remarkup
• rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl" once upon a time existed, could provide a base
  • But how to even realize/pass the info that we are rendering strings in a documentation context?
• PhutilRemarkupRule has a isFlatText($text) method but no setFlatText(true) method
• PhutilRemarkupSimpleTableBlockRule::markupText() is handling our $cell which has the meme/macro name as its only string content
• Afterwards, PhabricatorMemeRemarkupRule:apply() is the next step being called